* [dpdk-dev] [PATCH v1] sched: update profile oversubscribe config file @ 2020-10-26 13:41 Savinay Dharmappa 2020-10-27 9:22 ` [dpdk-dev] [PATCH v2] examples/qos_sched: " Savinay Dharmappa 0 siblings, 1 reply; 10+ messages in thread From: Savinay Dharmappa @ 2020-10-26 13:41 UTC (permalink / raw) To: cristian.dumitrescu, jasvinder.singh, dev; +Cc: savinay.dharmappa update the profile_ov config file to support dynamic update of subport rate. Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com> --- examples/qos_sched/profile_ov.cfg | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/qos_sched/profile_ov.cfg b/examples/qos_sched/profile_ov.cfg index ab509d28d7..14c89ae340 100644 --- a/examples/qos_sched/profile_ov.cfg +++ b/examples/qos_sched/profile_ov.cfg @@ -11,6 +11,9 @@ number of subports per port = 1 number of pipes per subport = 32 queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64 +subport 0-8 = 0 + +[subport profile 0] tb rate = 8400000 ; Bytes per second tb size = 100000 ; Bytes -- 2.17.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file 2020-10-26 13:41 [dpdk-dev] [PATCH v1] sched: update profile oversubscribe config file Savinay Dharmappa @ 2020-10-27 9:22 ` Savinay Dharmappa 2020-10-27 9:45 ` Dumitrescu, Cristian 2020-11-17 10:06 ` [dpdk-dev] [PATCH v3] examples/qos_sched: update profile " Savinay Dharmappa 0 siblings, 2 replies; 10+ messages in thread From: Savinay Dharmappa @ 2020-10-27 9:22 UTC (permalink / raw) To: cristian.dumitrescu, jasvinder.singh, dev; +Cc: savinay.dharmappa update the profile_ov config file to support dynamic update of subport rate. Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com> --- v2: renamed the commit subject. --- examples/qos_sched/profile_ov.cfg | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/qos_sched/profile_ov.cfg b/examples/qos_sched/profile_ov.cfg index ab509d28d7..14c89ae340 100644 --- a/examples/qos_sched/profile_ov.cfg +++ b/examples/qos_sched/profile_ov.cfg @@ -11,6 +11,9 @@ number of subports per port = 1 number of pipes per subport = 32 queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64 +subport 0-8 = 0 + +[subport profile 0] tb rate = 8400000 ; Bytes per second tb size = 100000 ; Bytes -- 2.17.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file 2020-10-27 9:22 ` [dpdk-dev] [PATCH v2] examples/qos_sched: " Savinay Dharmappa @ 2020-10-27 9:45 ` Dumitrescu, Cristian 2020-11-05 9:39 ` Dharmappa, Savinay 2020-11-17 10:06 ` [dpdk-dev] [PATCH v3] examples/qos_sched: update profile " Savinay Dharmappa 1 sibling, 1 reply; 10+ messages in thread From: Dumitrescu, Cristian @ 2020-10-27 9:45 UTC (permalink / raw) To: Dharmappa, Savinay, Singh, Jasvinder, dev > -----Original Message----- > From: Dharmappa, Savinay <savinay.dharmappa@intel.com> > Sent: Tuesday, October 27, 2020 9:22 AM > To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Singh, Jasvinder > <jasvinder.singh@intel.com>; dev@dpdk.org > Cc: Dharmappa, Savinay <savinay.dharmappa@intel.com> > Subject: [PATCH v2] examples/qos_sched: update profile oversubscribe > config file > > update the profile_ov config file to support dynamic > update of subport rate. > > Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com> > --- > v2: renamed the commit subject. > --- > examples/qos_sched/profile_ov.cfg | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/examples/qos_sched/profile_ov.cfg > b/examples/qos_sched/profile_ov.cfg > index ab509d28d7..14c89ae340 100644 > --- a/examples/qos_sched/profile_ov.cfg > +++ b/examples/qos_sched/profile_ov.cfg > @@ -11,6 +11,9 @@ number of subports per port = 1 > number of pipes per subport = 32 > queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64 > > +subport 0-8 = 0 > + > +[subport profile 0] > tb rate = 8400000 ; Bytes per second > tb size = 100000 ; Bytes > > -- > 2.17.1 Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file 2020-10-27 9:45 ` Dumitrescu, Cristian @ 2020-11-05 9:39 ` Dharmappa, Savinay 2020-11-05 10:11 ` Thomas Monjalon 2020-11-13 13:58 ` David Marchand 0 siblings, 2 replies; 10+ messages in thread From: Dharmappa, Savinay @ 2020-11-05 9:39 UTC (permalink / raw) To: Dumitrescu, Cristian, Singh, Jasvinder, dev, Thomas Monjalon -----Original Message----- From: Dumitrescu, Cristian <cristian.dumitrescu@intel.com> Sent: Tuesday, October 27, 2020 3:16 PM To: Dharmappa, Savinay <savinay.dharmappa@intel.com>; Singh, Jasvinder <jasvinder.singh@intel.com>; dev@dpdk.org Subject: RE: [PATCH v2] examples/qos_sched: update profile oversubscribe config file > -----Original Message----- > From: Dharmappa, Savinay <savinay.dharmappa@intel.com> > Sent: Tuesday, October 27, 2020 9:22 AM > To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Singh, > Jasvinder <jasvinder.singh@intel.com>; dev@dpdk.org > Cc: Dharmappa, Savinay <savinay.dharmappa@intel.com> > Subject: [PATCH v2] examples/qos_sched: update profile oversubscribe > config file > > update the profile_ov config file to support dynamic update of subport > rate. > > Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com> > --- > v2: renamed the commit subject. > --- > examples/qos_sched/profile_ov.cfg | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/examples/qos_sched/profile_ov.cfg > b/examples/qos_sched/profile_ov.cfg > index ab509d28d7..14c89ae340 100644 > --- a/examples/qos_sched/profile_ov.cfg > +++ b/examples/qos_sched/profile_ov.cfg > @@ -11,6 +11,9 @@ number of subports per port = 1 number of pipes per > subport = 32 queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64 > > +subport 0-8 = 0 > + > +[subport profile 0] > tb rate = 8400000 ; Bytes per second > tb size = 100000 ; Bytes > > -- > 2.17.1 Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> Hi Thomas, >> I see that this patch is not applied on rc2. When can this will be applied ? will it be part of rc3 ?. Please let me know ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file 2020-11-05 9:39 ` Dharmappa, Savinay @ 2020-11-05 10:11 ` Thomas Monjalon 2020-11-13 13:58 ` David Marchand 1 sibling, 0 replies; 10+ messages in thread From: Thomas Monjalon @ 2020-11-05 10:11 UTC (permalink / raw) To: Dharmappa, Savinay; +Cc: Dumitrescu, Cristian, Singh, Jasvinder, dev 05/11/2020 10:39, Dharmappa, Savinay: > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> > Hi Thomas, > I see that this patch is not applied on rc2. When can this will be applied ? will it be part of rc3 ?. Please let me know -rc2 was very busy, and examples were low priority. Will look into examples for -rc3. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file 2020-11-05 9:39 ` Dharmappa, Savinay 2020-11-05 10:11 ` Thomas Monjalon @ 2020-11-13 13:58 ` David Marchand 2020-11-17 7:05 ` Dharmappa, Savinay 1 sibling, 1 reply; 10+ messages in thread From: David Marchand @ 2020-11-13 13:58 UTC (permalink / raw) To: Dharmappa, Savinay Cc: Dumitrescu, Cristian, Singh, Jasvinder, dev, Thomas Monjalon On Thu, Nov 5, 2020 at 10:39 AM Dharmappa, Savinay <savinay.dharmappa@intel.com> wrote: > Hi Thomas, > >> I see that this patch is not applied on rc2. When can this will be applied ? will it be part of rc3 ?. Please let me know Please, pay attention when editing replies, this mail of yours added Cristian token again in patchwork. The commitlog is vague and gives no context. I looked through patchwork and found: https://patchwork.dpdk.org/patch/81666/ So, iiuc, you forgot to update those two examples configuration file and documentations. If so, please submit one patch fixing the qos_sched example (both config and doc) and another patch for fixing the ip_pipeline (doc). In both of them, describe with a Fixes: tag which commits are being fixed. -- David Marchand ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file 2020-11-13 13:58 ` David Marchand @ 2020-11-17 7:05 ` Dharmappa, Savinay 2020-11-17 7:21 ` David Marchand 0 siblings, 1 reply; 10+ messages in thread From: Dharmappa, Savinay @ 2020-11-17 7:05 UTC (permalink / raw) To: David Marchand Cc: Dumitrescu, Cristian, Singh, Jasvinder, dev, Thomas Monjalon -----Original Message----- From: David Marchand <david.marchand@redhat.com> Sent: Friday, November 13, 2020 7:28 PM To: Dharmappa, Savinay <savinay.dharmappa@intel.com> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Singh, Jasvinder <jasvinder.singh@intel.com>; dev@dpdk.org; Thomas Monjalon <thomas@monjalon.net> Subject: Re: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file On Thu, Nov 5, 2020 at 10:39 AM Dharmappa, Savinay <savinay.dharmappa@intel.com> wrote: > Hi Thomas, > >> I see that this patch is not applied on rc2. When can this will be > >> applied ? will it be part of rc3 ?. Please let me know Please, pay attention when editing replies, this mail of yours added Cristian token again in patchwork. The commitlog is vague and gives no context. I looked through patchwork and found: https://patchwork.dpdk.org/patch/81666/ So, iiuc, you forgot to update those two examples configuration file and documentations. If so, please submit one patch fixing the qos_sched example (both config and doc) and another patch for fixing the ip_pipeline (doc). In both of them, describe with a Fixes: tag which commits are being fixed. >> Instead of new patch shall I send v3 of this patch which has (both config and doc) and similarly for https://patchwork.dpdk.org/patch/81666/ patch to have only ip_pipeline (doc). Please let me know. -- David Marchand ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH v2] examples/qos_sched: update profile oversubscribe config file 2020-11-17 7:05 ` Dharmappa, Savinay @ 2020-11-17 7:21 ` David Marchand 0 siblings, 0 replies; 10+ messages in thread From: David Marchand @ 2020-11-17 7:21 UTC (permalink / raw) To: Dharmappa, Savinay Cc: Dumitrescu, Cristian, Singh, Jasvinder, dev, Thomas Monjalon On Tue, Nov 17, 2020 at 8:05 AM Dharmappa, Savinay <savinay.dharmappa@intel.com> wrote: > If so, please submit one patch fixing the qos_sched example (both config and doc) and another patch for fixing the ip_pipeline (doc). > In both of them, describe with a Fixes: tag which commits are being fixed. > > >> Instead of new patch shall I send v3 of this patch which has (both config and doc) and similarly for https://patchwork.dpdk.org/patch/81666/ patch to have only ip_pipeline (doc). Please let me know. Yes, one patch for qos_shed and one patch for ip_pipeline. -- David Marchand ^ permalink raw reply [flat|nested] 10+ messages in thread
* [dpdk-dev] [PATCH v3] examples/qos_sched: update profile config file 2020-10-27 9:22 ` [dpdk-dev] [PATCH v2] examples/qos_sched: " Savinay Dharmappa 2020-10-27 9:45 ` Dumitrescu, Cristian @ 2020-11-17 10:06 ` Savinay Dharmappa 2020-11-20 12:17 ` David Marchand 1 sibling, 1 reply; 10+ messages in thread From: Savinay Dharmappa @ 2020-11-17 10:06 UTC (permalink / raw) To: cristian.dumitrescu, jasvinder.singh, dev, david.marchand Cc: savinay.dharmappa update the qos_sched user guide and profile config file with default subport profile. Fixes: 802d214dc880 ("examples/qos_sched: update subport rate dynamically") Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> --- v3: addressed the review comments of patch v2 --- doc/guides/sample_app_ug/qos_scheduler.rst | 4 ++++ examples/qos_sched/profile_ov.cfg | 3 +++ 2 files changed, 7 insertions(+) diff --git a/doc/guides/sample_app_ug/qos_scheduler.rst b/doc/guides/sample_app_ug/qos_scheduler.rst index 3fb50d3654..e50f3cd536 100644 --- a/doc/guides/sample_app_ug/qos_scheduler.rst +++ b/doc/guides/sample_app_ug/qos_scheduler.rst @@ -135,6 +135,10 @@ The profile file has the following format: [subport 0] number of pipes per subport = 4096 queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64 + + subport 0-8 = 0 ; These subports are configured with subport profile 0 + + [subport profile 0] tb rate = 1250000000; Bytes per second tb size = 1000000; Bytes tc 0 rate = 1250000000; Bytes per second diff --git a/examples/qos_sched/profile_ov.cfg b/examples/qos_sched/profile_ov.cfg index ab509d28d7..14c89ae340 100644 --- a/examples/qos_sched/profile_ov.cfg +++ b/examples/qos_sched/profile_ov.cfg @@ -11,6 +11,9 @@ number of subports per port = 1 number of pipes per subport = 32 queue sizes = 64 64 64 64 64 64 64 64 64 64 64 64 64 +subport 0-8 = 0 + +[subport profile 0] tb rate = 8400000 ; Bytes per second tb size = 100000 ; Bytes -- 2.17.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH v3] examples/qos_sched: update profile config file 2020-11-17 10:06 ` [dpdk-dev] [PATCH v3] examples/qos_sched: update profile " Savinay Dharmappa @ 2020-11-20 12:17 ` David Marchand 0 siblings, 0 replies; 10+ messages in thread From: David Marchand @ 2020-11-20 12:17 UTC (permalink / raw) To: Savinay Dharmappa; +Cc: Cristian Dumitrescu, Singh, Jasvinder, dev On Tue, Nov 17, 2020 at 11:06 AM Savinay Dharmappa <savinay.dharmappa@intel.com> wrote: > > update the qos_sched user guide and profile config file > with default subport profile. > > Fixes: 802d214dc880 ("examples/qos_sched: update subport rate dynamically") > > Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com> > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> Applied, thanks. -- David Marchand ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-11-20 12:17 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-10-26 13:41 [dpdk-dev] [PATCH v1] sched: update profile oversubscribe config file Savinay Dharmappa 2020-10-27 9:22 ` [dpdk-dev] [PATCH v2] examples/qos_sched: " Savinay Dharmappa 2020-10-27 9:45 ` Dumitrescu, Cristian 2020-11-05 9:39 ` Dharmappa, Savinay 2020-11-05 10:11 ` Thomas Monjalon 2020-11-13 13:58 ` David Marchand 2020-11-17 7:05 ` Dharmappa, Savinay 2020-11-17 7:21 ` David Marchand 2020-11-17 10:06 ` [dpdk-dev] [PATCH v3] examples/qos_sched: update profile " Savinay Dharmappa 2020-11-20 12:17 ` David Marchand
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).