For test-pmd adding Aman Singh Signed-off-by: Aman Singh <aman.deep.singh@intel.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 278e5b3226..c4070fe668 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1637,6 +1637,7 @@ F: app/test/sample_packet_forward.h Driver testing tool M: Xiaoyun Li <xiaoyun.li@intel.com> +M: Aman Singh <aman.deep.singh@intel.com> T: git://dpdk.org/next/dpdk-next-net F: app/test-pmd/ F: doc/guides/testpmd_app_ug/ -- 2.17.1
On 10/22/2021 8:19 AM, Aman Singh wrote:
> For test-pmd adding Aman Singh
>
> Signed-off-by: Aman Singh <aman.deep.singh@intel.com>
Thanks Aman for volunteering.
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
22/10/2021 10:57, Ferruh Yigit:
> On 10/22/2021 8:19 AM, Aman Singh wrote:
> > For test-pmd adding Aman Singh
> >
> > Signed-off-by: Aman Singh <aman.deep.singh@intel.com>
>
> Thanks Aman for volunteering.
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
I'll take this opportunity to update the section title. v2 coming.
From: Aman Singh <aman.deep.singh@intel.com> Add Aman Singh as co-maintainer of testpmd. Make the title description more accurate for this tool. Signed-off-by: Aman Singh <aman.deep.singh@intel.com> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com> Signed-off-by: Thomas Monjalon <thomas@monjalon.net> --- v2: update the section title --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index d785363c5c..1b259a3d98 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1691,8 +1691,9 @@ M: Reshma Pattan <reshma.pattan@intel.com> F: app/test/sample_packet_forward.c F: app/test/sample_packet_forward.h -Driver testing tool +Networking features testing tool M: Xiaoyun Li <xiaoyun.li@intel.com> +M: Aman Singh <aman.deep.singh@intel.com> T: git://dpdk.org/next/dpdk-next-net F: app/test-pmd/ F: doc/guides/testpmd_app_ug/ -- 2.33.0
On 11/25/2021 10:01 AM, Thomas Monjalon wrote: > From: Aman Singh <aman.deep.singh@intel.com> > > Add Aman Singh as co-maintainer of testpmd. > > Make the title description more accurate for this tool. > > Signed-off-by: Aman Singh <aman.deep.singh@intel.com> > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> > --- > v2: update the section title > --- > MAINTAINERS | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index d785363c5c..1b259a3d98 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1691,8 +1691,9 @@ M: Reshma Pattan <reshma.pattan@intel.com> > F: app/test/sample_packet_forward.c > F: app/test/sample_packet_forward.h > > -Driver testing tool > +Networking features testing tool "Networking features" scope is a little wide. Not sure if "Networking features" or "Networking drivers" suits better, according previous title it is for driver testing. > M: Xiaoyun Li <xiaoyun.li@intel.com> > +M: Aman Singh <aman.deep.singh@intel.com> > T: git://dpdk.org/next/dpdk-next-net > F: app/test-pmd/ > F: doc/guides/testpmd_app_ug/ >
25/11/2021 14:40, Ferruh Yigit:
> On 11/25/2021 10:01 AM, Thomas Monjalon wrote:
> > -Driver testing tool
> > +Networking features testing tool
>
> "Networking features" scope is a little wide.
> Not sure if "Networking features" or "Networking drivers" suits better,
> according previous title it is for driver testing.
Yes it is for drivers features.
I want to distinguish testpmd and other tools like test-flow-perf
which is also testing networking drivers.
Maybe "Networking drivers features testing tool" ?
On 11/25/2021 3:20 PM, Thomas Monjalon wrote:
> 25/11/2021 14:40, Ferruh Yigit:
>> On 11/25/2021 10:01 AM, Thomas Monjalon wrote:
>>> -Driver testing tool
>>> +Networking features testing tool
>>
>> "Networking features" scope is a little wide.
>> Not sure if "Networking features" or "Networking drivers" suits better,
>> according previous title it is for driver testing.
>
> Yes it is for drivers features.
> I want to distinguish testpmd and other tools like test-flow-perf
> which is also testing networking drivers.
>
> Maybe "Networking drivers features testing tool" ?
>
ack
On 11/25/2021 4:04 PM, Ferruh Yigit wrote:
> On 11/25/2021 3:20 PM, Thomas Monjalon wrote:
>> 25/11/2021 14:40, Ferruh Yigit:
>>> On 11/25/2021 10:01 AM, Thomas Monjalon wrote:
>>>> -Driver testing tool
>>>> +Networking features testing tool
>>>
>>> "Networking features" scope is a little wide.
>>> Not sure if "Networking features" or "Networking drivers" suits better,
>>> according previous title it is for driver testing.
>>
>> Yes it is for drivers features.
>> I want to distinguish testpmd and other tools like test-flow-perf
>> which is also testing networking drivers.
>>
>> Maybe "Networking drivers features testing tool" ?
>>
>
> ack
>
thinking twice what additional meaning does 'features' adds here,
"Networking drivers features testing"
vs
"Networking drivers testing"
Isn't "Networking drivers testing" implies features of drivers?
25/11/2021 17:31, Ferruh Yigit:
> On 11/25/2021 4:04 PM, Ferruh Yigit wrote:
> > On 11/25/2021 3:20 PM, Thomas Monjalon wrote:
> >> 25/11/2021 14:40, Ferruh Yigit:
> >>> On 11/25/2021 10:01 AM, Thomas Monjalon wrote:
> >>>> -Driver testing tool
> >>>> +Networking features testing tool
> >>>
> >>> "Networking features" scope is a little wide.
> >>> Not sure if "Networking features" or "Networking drivers" suits better,
> >>> according previous title it is for driver testing.
> >>
> >> Yes it is for drivers features.
> >> I want to distinguish testpmd and other tools like test-flow-perf
> >> which is also testing networking drivers.
> >>
> >> Maybe "Networking drivers features testing tool" ?
> >>
> >
> > ack
> >
>
> thinking twice what additional meaning does 'features' adds here,
> "Networking drivers features testing"
> vs
> "Networking drivers testing"
>
> Isn't "Networking drivers testing" implies features of drivers?
Yes
I was trying to avoid being too generic,
because the same title could apply to flow-perf.
But not mentioning "performance" should be enough.
OK for "Networking drivers testing tool"
From: Aman Singh <aman.deep.singh@intel.com> Add Aman Singh as co-maintainer of testpmd. Make the title description more accurate for this tool. Signed-off-by: Aman Singh <aman.deep.singh@intel.com> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com> Signed-off-by: Thomas Monjalon <thomas@monjalon.net> --- v2: update the section title v3: update the section title --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index d785363c5c..6e520ca560 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1691,8 +1691,9 @@ M: Reshma Pattan <reshma.pattan@intel.com> F: app/test/sample_packet_forward.c F: app/test/sample_packet_forward.h -Driver testing tool +Networking drivers testing tool M: Xiaoyun Li <xiaoyun.li@intel.com> +M: Aman Singh <aman.deep.singh@intel.com> T: git://dpdk.org/next/dpdk-next-net F: app/test-pmd/ F: doc/guides/testpmd_app_ug/ -- 2.33.0
26/11/2021 11:04, Thomas Monjalon:
> From: Aman Singh <aman.deep.singh@intel.com>
>
> Add Aman Singh as co-maintainer of testpmd.
>
> Make the title description more accurate for this tool.
>
> Signed-off-by: Aman Singh <aman.deep.singh@intel.com>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Applied
Thanks Aman for volunteering.
On 2/10/2022 5:11 PM, Yuying Zhang wrote: > Move 'test-pmd/cmdline_tm.*' files under > "Traffic Management API" component. > Move 'test-pmd/cmdline_mtr.*' files under > "Traffic Metering and Policing API" component. > > Signed-off-by: Yuying Zhang <yuying.zhang@intel.com> > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index c65b753c6b..49fafd8be2 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -406,11 +406,13 @@ F: lib/ethdev/rte_flow* > Traffic Management API - EXPERIMENTAL > M: Cristian Dumitrescu <cristian.dumitrescu@intel.com> > T: git://dpdk.org/next/dpdk-next-net > +F: app/test-pmd/cmdline_tm.* Thanks Yuying, Can you please move the testpm files under the lib files? For both components. > F: lib/ethdev/rte_tm* > > Traffic Metering and Policing API - EXPERIMENTAL > M: Cristian Dumitrescu <cristian.dumitrescu@intel.com> > T: git://dpdk.org/next/dpdk-next-net > +F: app/test-pmd/cmdline_mtr.* > F: lib/ethdev/rte_mtr* > > Baseband API
Move 'test-pmd/bpf_cmd.*' files under BPF component. Signed-off-by: Yuying Zhang <yuying.zhang@intel.com> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index c65b753c6b..bdbf2f9e7f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1616,6 +1616,7 @@ F: lib/bpf/ F: examples/bpf/ F: app/test/test_bpf.c F: doc/guides/prog_guide/bpf_lib.rst +F: app/test-pmd/bpf_cmd.* Graph - EXPERIMENTAL M: Jerin Jacob <jerinj@marvell.com> -- 2.25.1
Move 'test-pmd/cmdline_tm.*' files under "Traffic Management API" component. Move 'test-pmd/cmdline_mtr.*' files under "Traffic Metering and Policing API" component. Signed-off-by: Yuying Zhang <yuying.zhang@intel.com> --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c65b753c6b..49fafd8be2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -406,11 +406,13 @@ F: lib/ethdev/rte_flow* Traffic Management API - EXPERIMENTAL M: Cristian Dumitrescu <cristian.dumitrescu@intel.com> T: git://dpdk.org/next/dpdk-next-net +F: app/test-pmd/cmdline_tm.* F: lib/ethdev/rte_tm* Traffic Metering and Policing API - EXPERIMENTAL M: Cristian Dumitrescu <cristian.dumitrescu@intel.com> T: git://dpdk.org/next/dpdk-next-net +F: app/test-pmd/cmdline_mtr.* F: lib/ethdev/rte_mtr* Baseband API -- 2.25.1
10/02/2022 16:03, Yuying Zhang:
> Move 'test-pmd/bpf_cmd.*' files under BPF component.
>
> Signed-off-by: Yuying Zhang <yuying.zhang@intel.com>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Assuming Konstantin is OK.
Applied, thanks.