DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"geoffrey.lv@gmail.com" <geoffrey.lv@gmail.com>,
	"ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>,
	"stable@dpdk.org" <stable@dpdk.org>,
	"gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>,
	"arybchenko@solarflare.com" <arybchenko@solarflare.com>
Subject: Re: [dpdk-dev] [PATCH v2] bus/pci: fix unexpected resource mapping override
Date: Wed, 31 Oct 2018 19:24:21 +0100	[thread overview]
Message-ID: <2723053.kYWEf3LriZ@xps> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E70611532DD668@SHSMSX103.ccr.corp.intel.com>

30/10/2018 16:19, Zhang, Qi Z:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 27/10/2018 05:20, Qi Zhang:
> > > When scanning an already plugged device, the virtual address of mapped
> > > PCI resource in rte_pci_device will be overridden with 0, that may
> > > cause driver does not work correctly.
> > > The fix is not to update any rte_pci_device's field if the being
> > > scanned device's driver is already probed.
> > >
> > > Bugzilla ID: 85
> > > Fixes: c752998b5e2e ("pci: introduce library and driver")
> > > Cc: stable@dpdk.org
> > >
> > > Reported-by: Lv Geoffrey <geoffrey.lv@gmail.com>
> > > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > 
> > I still think something must be fixed in PCI scan.
> 
> We are fixing something in PCI scan, right?

Yes :)
I was thinking about not scanning an already scanned device.
If the device has been unplugged, it should be removed,
and re-added when plugged, instead of trying to update it.

I understand this is another kind of change and deserves more time
to think about the right design. That's why I will accept the v3
of this patch.

Anyway the road to get hotplug handled right is long :)

      reply	other threads:[~2018-10-31 18:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-27  3:20 Qi Zhang
2018-10-28 23:26 ` Thomas Monjalon
2018-10-30 15:19   ` Zhang, Qi Z
2018-10-31 18:24     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2723053.kYWEf3LriZ@xps \
    --to=thomas@monjalon.net \
    --cc=ajit.khaparde@broadcom.com \
    --cc=anatoly.burakov@intel.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=gaetan.rivet@6wind.com \
    --cc=geoffrey.lv@gmail.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).