From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 522E3A0542; Wed, 26 Oct 2022 23:34:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3848440A7E; Wed, 26 Oct 2022 23:34:04 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 43C5C400D5 for ; Wed, 26 Oct 2022 23:34:02 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id F36F532005C1; Wed, 26 Oct 2022 17:34:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 26 Oct 2022 17:34:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1666820040; x= 1666906440; bh=fQ15x65h/CPdtcJ5t66P3D4YRq6tUlIGogs/PslqQRA=; b=b ZVp2XE3WhgBCVwoLS50uwYZo8PwU+Dfi0/efmPchYIwaKc8a8hDXMSalB9d6M2bo 43aQc3OECHWVYhdMTeRQJDEPJrLgscC2K3G0LlCM2Lch9+aQud7dEIFDBqoNmjkk A3nU00tLNP4mJKInIjmAnVKfgIew1eDN0Fzr0vo4MnqS6yj/4kGlNKaVxdWNLlcf uG7b0G32NAGyTaRgZIn4Z92MR5qaI8wdxpK2ZZ4A8c+27jLswsXQLYbSPF4PhsKs WzP0BlSIxEo4gmbc1BCs/jLdOmMIVGuQwIrFjO1wTduB58EWpXn0/9CFofz72UVY eGhlcCkYgF46cHMNZGx2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1666820040; x= 1666906440; bh=fQ15x65h/CPdtcJ5t66P3D4YRq6tUlIGogs/PslqQRA=; b=N 9G2hW1KObtngUQ6ePPWbyN6bcsYILlzF+aksQIuK38yiQj01HSpbe1WMR6DzGANM NuEqr21Wkr716UDFETNFXFKnDHv9PCm/bnjcGWiZsMN1d3ue387nmhD2wAu5nZ84 K+zMLqhx7HxFmxh8N/Gf37USR128UaCck4j1hnAr/xU+qNVwM5EaFWoeGyzQPGGF 6jiud8HVR3BuugE+3YGzvuSpLMEQDPX4ARNpDG39h4GHSye6s15g6PjwT3fYfsZE U7SEPC5hlbeoqewoJwypWQ4vqxCAsUxuZpfUsJ5zJPL1bAzBAzLTLPoQpnfzDrr+ M+Q+ZP/Ua+CAAJvCTXpdA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrtdefucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh ephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfo ohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtffrrg htthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdeikefgkedu hedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 26 Oct 2022 17:33:59 -0400 (EDT) From: Thomas Monjalon To: "Pattan, Reshma" Cc: Markus Theil , "Hunt, David" , dev@dpdk.org, "Theil, Markus" Subject: Re: [PATCH] power: fix pstate number parsing Date: Wed, 26 Oct 2022 23:33:58 +0200 Message-ID: <2724985.BEx9A2HvPv@thomas> In-Reply-To: References: <20221012113342.7931-1-markus.theil@tu-ilmenau.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/10/2022 14:25, Pattan, Reshma: > > > -----Original Message----- > > From: Markus Theil > > > > +#include > > This is not needed right. > > > #include > > #include > > #include > > @@ -96,7 +97,7 @@ power_read_turbo_pct(uint64_t *outVal) > > > > errno = 0; > > *outVal = (uint64_t) strtol(val, &endptr, 10); > > - if (*endptr != 0 || errno != 0) { > > + if (errno != 0 || (*endptr != 0 && *endptr != '\n')) { > > I encountered today that power library initialization failed and the reason is this \n check. > This fix fixes the issue. > > So if you are sending the next version be removing the above mentioned header file, please keep my Review and Ack tags in next version. Review is enough, it is stronger than ack. Review means you carefully reviewed the change.