DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	stable@dpdk.org, Tal Shnaiderman <talshn@nvidia.com>,
	Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
	"Dmitry Malloy (MESHCHANINOV)" <dmitrym@microsoft.com>,
	Pallavi Kadam <pallavi.kadam@intel.com>,
	Khoa To <khot@microsoft.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [EXTERNAL] [PATCH] eal/windows: use bundled getopt with MinGW
Date: Mon, 05 Oct 2020 09:23:48 +0200	[thread overview]
Message-ID: <2725375.LzpstL7bX6@thomas> (raw)
In-Reply-To: <BY5PR21MB13803ECA5BBDE012389BCFCDD9370@BY5PR21MB1380.namprd21.prod.outlook.com>

> > Clang builds use getopt.c in librte_eal while MinGW provides
> > implementation as part of the toolchain. Statically linking librte_eal
> > to an application that depends on getopt results in undefined reference
> > errors with MinGW. There are no such errors with Clang, because with
> > Clang librte_eal actually defines getopt functions.
> > 
> > Use getopt.c in EAL with Clang and MinGW to get identical behavior.
> > Adjust code for MinGW. Incidentally, this removes a bug when free() is
> > called on uninitialized memory.
> > 
> > Fixes: 5e373e456e6 ("eal/windows: add getopt implementation")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > Reported-by: Khoa To <khot@microsoft.com>
> > Reported-by: Tal Shnaiderman <talshn@nvidia.com>
> > ---
> > 
> > This patch probably supesedes
> > https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
> > work.dpdk.org%2Fpatch%2F78574%2F&amp;data=02%7C01%7Ckhot%40micr
> > osoft.com%7C7f6e47a7db0945b2c93708d860dffaa3%7C72f988bf86f141af91a
> > b2d7cd011db47%7C1%7C0%7C637365862839491238&amp;sdata=%2BQPJ2US
> > hknxQLV97rQRVc0sT55TpTNjNTq1m9oj9eFs%3D&amp;reserved=0.
> 
> Acked-by: Khoa To <khot@microsoft.com>

Applied, thanks



  reply	other threads:[~2020-10-05  7:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-24 23:17 [dpdk-dev] " Dmitry Kozlyuk
2020-09-26  1:23 ` [dpdk-dev] [EXTERNAL] " Khoa To
2020-10-05  7:23   ` Thomas Monjalon [this message]
2020-09-28 19:53 ` [dpdk-dev] " Kadam, Pallavi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2725375.LzpstL7bX6@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=dmitrym@microsoft.com \
    --cc=khot@microsoft.com \
    --cc=navasile@linux.microsoft.com \
    --cc=pallavi.kadam@intel.com \
    --cc=stable@dpdk.org \
    --cc=talshn@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).