From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74DC4A04BA; Mon, 5 Oct 2020 09:24:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 27CA11B679; Mon, 5 Oct 2020 09:23:59 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id C82BC1B664; Mon, 5 Oct 2020 09:23:56 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 4072C5C0148; Mon, 5 Oct 2020 03:23:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 05 Oct 2020 03:23:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= hdDKV7YBf54F7QdlXwnLPVFf0ykSQj2DsfoVnqxZI00=; b=d5D/4ugg3pxcWAx5 qiwkaNkr2qmGyqwdQ4h4HQhu7z2eMB6G+5+uWwifaCOPikVGdy2PAdD9o40uNfhY S9NBwn+05xdfW+in19f6rzGNHK0vEhSVLGuftga+QVJWV/hmDb2FWEQghiwP/rU6 DAFJBXEs/RWHQeiUj4m1Sl3qyCIc7mDkUdpW3swQsO1A2PGsDqV3uPM7WRsw5Y0j 7hxsxlFjZHlrJ8MyV95FEc70kRaNWK87kIumKoommcLH9SRqwDHFzhuw2V2NtN8P 55P6rUW7CGxoRKzYnQKqftG8BKtTm1LWb7ANyxqnd9XNbO9fZ17cg+qj6copPlw6 nIC8jg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=hdDKV7YBf54F7QdlXwnLPVFf0ykSQj2DsfoVnqxZI 00=; b=b+unRNDNAY9EaCddnOU9ETPApPYUlrH+FZ0iK02J4M9h3hmeKpphU7js2 gJEwIOoEdcYHTbwOUAq/qkpCsLBvJiLmWJM+qYaec59aRRpkAwBZ8YwxQGejQ6VZ /9RwIIm9KjXf6ISbHWeSrkLP1fpm5lPtGjFDD7QHk7dbhDy+tkM4r7xomWl149QN U+qBuCc1CeJj+r95oFMmyN3lEZws2lVBtJHy98qAq/SVyV2vqi5AvXwK+YFA20kp XIHfxT/Og0LzBNmNvYeXnfPH8n8ya3WYi4jj8LZK2Sirz6iEj1xV10kFJdziLxRW 5Pvak/tverMaS6KKUWos8cbD0cmSA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrgedugdduvdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepueffjeehjeevfeegtddvlefgueeutdffffduteetgeelfedttdeu ieeuvedvheejnecuffhomhgrihhnpehouhhtlhhoohhkrdgtohhmpdguphgukhdrohhrgh enucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D647A3064680; Mon, 5 Oct 2020 03:23:51 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: "dev@dpdk.org" , stable@dpdk.org, Tal Shnaiderman , Narcisa Ana Maria Vasile , "Dmitry Malloy (MESHCHANINOV)" , Pallavi Kadam , Khoa To Date: Mon, 05 Oct 2020 09:23:48 +0200 Message-ID: <2725375.LzpstL7bX6@thomas> In-Reply-To: References: <20200924231707.23554-1-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [EXTERNAL] [PATCH] eal/windows: use bundled getopt with MinGW X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > Clang builds use getopt.c in librte_eal while MinGW provides > > implementation as part of the toolchain. Statically linking librte_eal > > to an application that depends on getopt results in undefined reference > > errors with MinGW. There are no such errors with Clang, because with > > Clang librte_eal actually defines getopt functions. > > > > Use getopt.c in EAL with Clang and MinGW to get identical behavior. > > Adjust code for MinGW. Incidentally, this removes a bug when free() is > > called on uninitialized memory. > > > > Fixes: 5e373e456e6 ("eal/windows: add getopt implementation") > > Cc: stable@dpdk.org > > > > Signed-off-by: Dmitry Kozlyuk > > Reported-by: Khoa To > > Reported-by: Tal Shnaiderman > > --- > > > > This patch probably supesedes > > https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch > > work.dpdk.org%2Fpatch%2F78574%2F&data=02%7C01%7Ckhot%40micr > > osoft.com%7C7f6e47a7db0945b2c93708d860dffaa3%7C72f988bf86f141af91a > > b2d7cd011db47%7C1%7C0%7C637365862839491238&sdata=%2BQPJ2US > > hknxQLV97rQRVc0sT55TpTNjNTq1m9oj9eFs%3D&reserved=0. > > Acked-by: Khoa To Applied, thanks