From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3AD3FA0A02; Fri, 26 Mar 2021 10:22:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BED2D40685; Fri, 26 Mar 2021 10:22:43 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 7711B4067B for ; Fri, 26 Mar 2021 10:22:42 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id F2F5A5C00E2; Fri, 26 Mar 2021 05:22:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 26 Mar 2021 05:22:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= UL6fj/Jkjgfv4gxiaJJCNkTCMYG1xqzaMKGcSV2Gdvo=; b=xL3Q4PHxxvziv66z fYdBWYqtBCx3SCH0JQ+j+uf7VcAK7bP5AeHvrD4326SNlDVgMaM7l4rjUSOs9TPM WaY276n8baftXSdLQ2W5jXRoJoxm0xTSTvOUg1ZCWeIza+RcXvASLIcYx1GfMuHS Hz22zUt3yQEJh7sjWdSRmDaFGO/ccMARJfXMkZKMslPNOCCJQ4lvIIROswkTqhs3 n1TTsNRC+hGVTVoAuno4gdTkIurzGD0frAjW3v1IOaIyuayG2JFpg/whaT0ZkNJA Z4pv5YvXXWQUMyVfgYixPf6LuzJLOxh+jUYSuxaBVTa2dHrLbNTbPx0uqEFpuoJR qeRGww== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=UL6fj/Jkjgfv4gxiaJJCNkTCMYG1xqzaMKGcSV2Gd vo=; b=Fp37xdqYOrt1BZOqlJzJVpqLbXaKz6VcXzsRUGmRbOsF7ZO48oBWWA7Zl lwMO1aWlho4ueqCKn/sMR4das7Kjf0HsSWFeRXxjpJutO3IpM9Y/J7NfcFAJZaFA oDkrZRDoATzY0PJLKH1SLJtyl8vUaJmOcwY+nQ+Hn06y95tVqUD1jdolokbIc1SO +wKlMZ7BQKwnTTquNP+HWTcWKAw/zxEnJazOIR8z4Nle3ZrhwCSGHz/SOcT5QotA 6bE/QqzrshJPQDNO4mYzclvOnYcceRCSzoYTSDwXk9bqNL1GdAC86cxpIVHRcbBd vmjjfCQM6w5higyw5wPDHSCYEGA3Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudehvddgtdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeekuddrudekhedrudeihedrudektdenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (180.165.185.81.rev.sfr.net [81.185.165.180]) by mail.messagingengine.com (Postfix) with ESMTPA id 24E6524005E; Fri, 26 Mar 2021 05:22:37 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, Tyler Retzlaff , Jie Zhou , Matan Azrad , Viacheslav Ovsiienko , Olivier Matz , Ferruh Yigit , Andrew Rybchenko , david.marchand@redhat.com Date: Fri, 26 Mar 2021 10:22:35 +0100 Message-ID: <27286511.E3Cq6evh0R@thomas> In-Reply-To: <20210320130525.16452-5-dmitry.kozliuk@gmail.com> References: <20210320112733.13160-1-dmitry.kozliuk@gmail.com> <20210320130525.16452-1-dmitry.kozliuk@gmail.com> <20210320130525.16452-5-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 4/5] net: provide IP-related API on any OS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/03/2021 14:05, Dmitry Kozlyuk: > Users of relied on it to provide IP-related defines, > like IPPROTO_* constatns, but still had to include POSIX headers typo: constants > for inet_pton() and other standard IP-related facilities. > > Extend so that it is a single header to gain access > to IP-related facilities on any OS. Use it to replace POSIX include > in components enabled on Windows. > > Signed-off-by: Dmitry Kozlyuk [...] > --- a/drivers/net/mlx5/mlx5.h > +++ b/drivers/net/mlx5/mlx5.h > @@ -10,7 +10,7 @@ > #include > #include > #include > -#include > + > #include No need of blank space between system includes. (same comments for other files) > --- a/lib/librte_net/rte_ip.h > +++ b/lib/librte_net/rte_ip.h > #include > + That's an unneeded blank line. > +#include > #include > +#include > #include > #include The benefit is not obvious because the removal of Windows code is done in another patch. Please could you re-arrange the patch to be more atomic?