From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 6170E4CAB; Mon, 22 Apr 2019 23:13:23 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DF90F220F1; Mon, 22 Apr 2019 17:13:22 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 22 Apr 2019 17:13:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=iHDpMb6imTQw0YKX+FvzRvFi0v1Qp4pwtiefjXuj5BM=; b=o1pxKD5aquBm e1YAwFWAxSheAwBcGqTwDZrrJNrofT/LkzxLJFGfa81ZC1Up3DPmYV3JIdFfJiEp RgL9+fxfRUuhrz/C9kPZW2sLN6e3/yCoCvVSzIaEPFSrD35QnZHEioMq0EOekMYp E7djggBnjnXSa8Qx+YCg545UWFEVNNE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=iHDpMb6imTQw0YKX+FvzRvFi0v1Qp4pwtiefjXuj5 BM=; b=CTl5S7IrFKwIcUmzqpi7WsOeyyuHPkyTw84fOprfelR/05CL+mQCQ/Z+a tg2/pQ9L3fhTnpTCUoo8v/X+Kfgh1GEWy13sTPrXNkZPr661E6LWJEPEAd/LG2HG kuUoYwJrBFeyekRyWh0FxAaXdjEhvnfCzl02vte19xEUxdSijyyNvtidaGcZADaM 7SS8uNPECTE35lJ7B44rZVLGJqwiokvLXe4ICYotpJxrvKpxGtn7gbY4olql0aOL AOC1nN/7aLBFaUT/cMLq1EO0PTR16hxzG8XIU8aInwwQDiXl++2HdRc6EpXbObqZ oNTkHpfFQOVhBOY0nUtWXRBO29N4g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrgeeigddugeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeekfedrudduhedrudehhedrudefkeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedu X-ME-Proxy: Received: from xps.localnet (acaen-257-1-30-138.w83-115.abo.wanadoo.fr [83.115.155.138]) by mail.messagingengine.com (Postfix) with ESMTPA id 736D8103CD; Mon, 22 Apr 2019 17:13:20 -0400 (EDT) From: Thomas Monjalon To: Reshma Pattan Cc: dev@dpdk.org, "Hunt, David" , stable@dpdk.org Date: Mon, 22 Apr 2019 23:13:17 +0200 Message-ID: <2737559.yID1egLt6L@xps> In-Reply-To: References: <20190409160024.40431-1-reshma.pattan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples/vm_power_manager: fix string null termination X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Apr 2019 21:13:23 -0000 15/04/2019 16:50, Hunt, David: > On 9/4/2019 5:00 PM, Reshma Pattan wrote: > > After the read() the jason_data null termination is missing > > for the case "indent < 0", for "indent > 0" and "indent == 0" > > cases null termination is already handled. > > > > So add the missing case "indent < 0" to the existing "indent == 0" > > case to fix null termination. > > > > Coverity issue: 337680 > > Fixes: a63504a90f ("examples/power: add JSON string handling") > > CC: david.hunt@intel.com > > CC: stable@dpdk.org > > > > Signed-off-by: Reshma Pattan > > Acked-by: David Hunt Applied, thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 04D98A05D3 for ; Mon, 22 Apr 2019 23:13:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 173CE1B105; Mon, 22 Apr 2019 23:13:25 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 6170E4CAB; Mon, 22 Apr 2019 23:13:23 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DF90F220F1; Mon, 22 Apr 2019 17:13:22 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 22 Apr 2019 17:13:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=iHDpMb6imTQw0YKX+FvzRvFi0v1Qp4pwtiefjXuj5BM=; b=o1pxKD5aquBm e1YAwFWAxSheAwBcGqTwDZrrJNrofT/LkzxLJFGfa81ZC1Up3DPmYV3JIdFfJiEp RgL9+fxfRUuhrz/C9kPZW2sLN6e3/yCoCvVSzIaEPFSrD35QnZHEioMq0EOekMYp E7djggBnjnXSa8Qx+YCg545UWFEVNNE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=iHDpMb6imTQw0YKX+FvzRvFi0v1Qp4pwtiefjXuj5 BM=; b=CTl5S7IrFKwIcUmzqpi7WsOeyyuHPkyTw84fOprfelR/05CL+mQCQ/Z+a tg2/pQ9L3fhTnpTCUoo8v/X+Kfgh1GEWy13sTPrXNkZPr661E6LWJEPEAd/LG2HG kuUoYwJrBFeyekRyWh0FxAaXdjEhvnfCzl02vte19xEUxdSijyyNvtidaGcZADaM 7SS8uNPECTE35lJ7B44rZVLGJqwiokvLXe4ICYotpJxrvKpxGtn7gbY4olql0aOL AOC1nN/7aLBFaUT/cMLq1EO0PTR16hxzG8XIU8aInwwQDiXl++2HdRc6EpXbObqZ oNTkHpfFQOVhBOY0nUtWXRBO29N4g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrgeeigddugeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeekfedrudduhedrudehhedrudefkeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedu X-ME-Proxy: Received: from xps.localnet (acaen-257-1-30-138.w83-115.abo.wanadoo.fr [83.115.155.138]) by mail.messagingengine.com (Postfix) with ESMTPA id 736D8103CD; Mon, 22 Apr 2019 17:13:20 -0400 (EDT) From: Thomas Monjalon To: Reshma Pattan Cc: dev@dpdk.org, "Hunt, David" , stable@dpdk.org Date: Mon, 22 Apr 2019 23:13:17 +0200 Message-ID: <2737559.yID1egLt6L@xps> In-Reply-To: References: <20190409160024.40431-1-reshma.pattan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] examples/vm_power_manager: fix string null termination X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190422211317.xU7849oELgIp3fe0d3oDv7GfUza-LvJylBA5xoc2pGo@z> 15/04/2019 16:50, Hunt, David: > On 9/4/2019 5:00 PM, Reshma Pattan wrote: > > After the read() the jason_data null termination is missing > > for the case "indent < 0", for "indent > 0" and "indent == 0" > > cases null termination is already handled. > > > > So add the missing case "indent < 0" to the existing "indent == 0" > > case to fix null termination. > > > > Coverity issue: 337680 > > Fixes: a63504a90f ("examples/power: add JSON string handling") > > CC: david.hunt@intel.com > > CC: stable@dpdk.org > > > > Signed-off-by: Reshma Pattan > > Acked-by: David Hunt Applied, thanks