* [dpdk-dev] [PATCH] examples/vm_power_manager: fix string null termination
@ 2019-04-09 16:00 Reshma Pattan
2019-04-09 16:00 ` Reshma Pattan
2019-04-15 14:50 ` Hunt, David
0 siblings, 2 replies; 6+ messages in thread
From: Reshma Pattan @ 2019-04-09 16:00 UTC (permalink / raw)
To: dev; +Cc: Reshma Pattan, david.hunt, stable
After the read() the jason_data null termination is missing
for the case "indent < 0", for "indent > 0" and "indent == 0"
cases null termination is already handled.
So add the missing case "indent < 0" to the existing "indent == 0"
case to fix null termination.
Coverity issue: 337680
Fixes: a63504a90f ("examples/power: add JSON string handling")
CC: david.hunt@intel.com
CC: stable@dpdk.org
Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
---
examples/vm_power_manager/channel_monitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c
index 74df0fe20..c67ca4710 100644
--- a/examples/vm_power_manager/channel_monitor.c
+++ b/examples/vm_power_manager/channel_monitor.c
@@ -807,7 +807,7 @@ read_json_packet(struct channel_info *chan_info)
indent--;
if ((indent > 0) || (idx > 0))
idx++;
- if (indent == 0)
+ if (indent <= 0)
json_data[idx] = 0;
if (idx >= MAX_JSON_STRING_LEN-1)
break;
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH] examples/vm_power_manager: fix string null termination
2019-04-09 16:00 [dpdk-dev] [PATCH] examples/vm_power_manager: fix string null termination Reshma Pattan
@ 2019-04-09 16:00 ` Reshma Pattan
2019-04-15 14:50 ` Hunt, David
1 sibling, 0 replies; 6+ messages in thread
From: Reshma Pattan @ 2019-04-09 16:00 UTC (permalink / raw)
To: dev; +Cc: Reshma Pattan, david.hunt, stable
After the read() the jason_data null termination is missing
for the case "indent < 0", for "indent > 0" and "indent == 0"
cases null termination is already handled.
So add the missing case "indent < 0" to the existing "indent == 0"
case to fix null termination.
Coverity issue: 337680
Fixes: a63504a90f ("examples/power: add JSON string handling")
CC: david.hunt@intel.com
CC: stable@dpdk.org
Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
---
examples/vm_power_manager/channel_monitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c
index 74df0fe20..c67ca4710 100644
--- a/examples/vm_power_manager/channel_monitor.c
+++ b/examples/vm_power_manager/channel_monitor.c
@@ -807,7 +807,7 @@ read_json_packet(struct channel_info *chan_info)
indent--;
if ((indent > 0) || (idx > 0))
idx++;
- if (indent == 0)
+ if (indent <= 0)
json_data[idx] = 0;
if (idx >= MAX_JSON_STRING_LEN-1)
break;
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] examples/vm_power_manager: fix string null termination
2019-04-09 16:00 [dpdk-dev] [PATCH] examples/vm_power_manager: fix string null termination Reshma Pattan
2019-04-09 16:00 ` Reshma Pattan
@ 2019-04-15 14:50 ` Hunt, David
2019-04-15 14:50 ` Hunt, David
2019-04-22 21:13 ` Thomas Monjalon
1 sibling, 2 replies; 6+ messages in thread
From: Hunt, David @ 2019-04-15 14:50 UTC (permalink / raw)
To: Reshma Pattan, dev; +Cc: stable
On 9/4/2019 5:00 PM, Reshma Pattan wrote:
> After the read() the jason_data null termination is missing
> for the case "indent < 0", for "indent > 0" and "indent == 0"
> cases null termination is already handled.
>
> So add the missing case "indent < 0" to the existing "indent == 0"
> case to fix null termination.
>
> Coverity issue: 337680
> Fixes: a63504a90f ("examples/power: add JSON string handling")
> CC: david.hunt@intel.com
> CC: stable@dpdk.org
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
> examples/vm_power_manager/channel_monitor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c
> index 74df0fe20..c67ca4710 100644
> --- a/examples/vm_power_manager/channel_monitor.c
> +++ b/examples/vm_power_manager/channel_monitor.c
> @@ -807,7 +807,7 @@ read_json_packet(struct channel_info *chan_info)
> indent--;
> if ((indent > 0) || (idx > 0))
> idx++;
> - if (indent == 0)
> + if (indent <= 0)
> json_data[idx] = 0;
> if (idx >= MAX_JSON_STRING_LEN-1)
> break;
Acked-by: David Hunt <david.hunt@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] examples/vm_power_manager: fix string null termination
2019-04-15 14:50 ` Hunt, David
@ 2019-04-15 14:50 ` Hunt, David
2019-04-22 21:13 ` Thomas Monjalon
1 sibling, 0 replies; 6+ messages in thread
From: Hunt, David @ 2019-04-15 14:50 UTC (permalink / raw)
To: Reshma Pattan, dev; +Cc: stable
On 9/4/2019 5:00 PM, Reshma Pattan wrote:
> After the read() the jason_data null termination is missing
> for the case "indent < 0", for "indent > 0" and "indent == 0"
> cases null termination is already handled.
>
> So add the missing case "indent < 0" to the existing "indent == 0"
> case to fix null termination.
>
> Coverity issue: 337680
> Fixes: a63504a90f ("examples/power: add JSON string handling")
> CC: david.hunt@intel.com
> CC: stable@dpdk.org
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
> examples/vm_power_manager/channel_monitor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c
> index 74df0fe20..c67ca4710 100644
> --- a/examples/vm_power_manager/channel_monitor.c
> +++ b/examples/vm_power_manager/channel_monitor.c
> @@ -807,7 +807,7 @@ read_json_packet(struct channel_info *chan_info)
> indent--;
> if ((indent > 0) || (idx > 0))
> idx++;
> - if (indent == 0)
> + if (indent <= 0)
> json_data[idx] = 0;
> if (idx >= MAX_JSON_STRING_LEN-1)
> break;
Acked-by: David Hunt <david.hunt@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] examples/vm_power_manager: fix string null termination
2019-04-15 14:50 ` Hunt, David
2019-04-15 14:50 ` Hunt, David
@ 2019-04-22 21:13 ` Thomas Monjalon
2019-04-22 21:13 ` Thomas Monjalon
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2019-04-22 21:13 UTC (permalink / raw)
To: Reshma Pattan; +Cc: dev, Hunt, David, stable
15/04/2019 16:50, Hunt, David:
> On 9/4/2019 5:00 PM, Reshma Pattan wrote:
> > After the read() the jason_data null termination is missing
> > for the case "indent < 0", for "indent > 0" and "indent == 0"
> > cases null termination is already handled.
> >
> > So add the missing case "indent < 0" to the existing "indent == 0"
> > case to fix null termination.
> >
> > Coverity issue: 337680
> > Fixes: a63504a90f ("examples/power: add JSON string handling")
> > CC: david.hunt@intel.com
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
>
> Acked-by: David Hunt <david.hunt@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] examples/vm_power_manager: fix string null termination
2019-04-22 21:13 ` Thomas Monjalon
@ 2019-04-22 21:13 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2019-04-22 21:13 UTC (permalink / raw)
To: Reshma Pattan; +Cc: dev, Hunt, David, stable
15/04/2019 16:50, Hunt, David:
> On 9/4/2019 5:00 PM, Reshma Pattan wrote:
> > After the read() the jason_data null termination is missing
> > for the case "indent < 0", for "indent > 0" and "indent == 0"
> > cases null termination is already handled.
> >
> > So add the missing case "indent < 0" to the existing "indent == 0"
> > case to fix null termination.
> >
> > Coverity issue: 337680
> > Fixes: a63504a90f ("examples/power: add JSON string handling")
> > CC: david.hunt@intel.com
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
>
> Acked-by: David Hunt <david.hunt@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-22 21:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-09 16:00 [dpdk-dev] [PATCH] examples/vm_power_manager: fix string null termination Reshma Pattan
2019-04-09 16:00 ` Reshma Pattan
2019-04-15 14:50 ` Hunt, David
2019-04-15 14:50 ` Hunt, David
2019-04-22 21:13 ` Thomas Monjalon
2019-04-22 21:13 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).