From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E23FDA04A4; Sun, 24 May 2020 17:27:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0919D1D42B; Sun, 24 May 2020 17:27:23 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id E20331C1C3; Sun, 24 May 2020 17:27:20 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 3A226509; Sun, 24 May 2020 11:27:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Sun, 24 May 2020 11:27:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= xpV/nYp5MqOFK60ieqq9qkXn1jdZ4b0DdqqzCg8UkNs=; b=WZYuWQgmGDIogE9e IAIX78JVwSLawTHKC0MTlcHoiocsXMkAzW5eKQiw2yKSlwSLbMHL1PqvjfuXxK1M 5orLhJtOkk3Ll8kX8v7fZius9Rh7MjWOoN8F5wVxX2F1cBG/0gJgGcTdLfnJAc2Q /YMLDa4JGvwEzFM785W7+fkY5BPq4nO1cKF1tJ/EEdvP0T1cnKfb0/EaWaAsl1tB BwD48Mh25EcJbDesP3sAQAiK0SUx6UmulZC2nRvtsVBJhzOab3q0Wee96XBFo8Lo 1dtpu5sLLshJ0zzlXnjBDmFdIejXVPsBTs4zKFNuqMNDb9dlaGs/tdebtEq6wtKS Nxn2rg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=xpV/nYp5MqOFK60ieqq9qkXn1jdZ4b0DdqqzCg8Uk Ns=; b=H0jMtEg+tDwPS3Onr9SdpYSB/A6MqoLfBj2qZo1XKkbwFnGt7b6vYHrXQ NHXtcZi2rvUhjEjM+oVtpfCsZzSm5xxzS32cUSTco93u/FMrWIFZa6LaFFwD+PCn Ao9NSi4TUzRzaCfS7izuhI8qJfoEKVPv1mCI0Z4xxV/8xpC62pVLxYa9byQI842R vFIQtUE1ffEJNOSfhrLg6apKWFo4kjfYAGsNedxBvhAN0Jp8juXgS6AGqmOscnwf QiSUl65C31l5zq2tRWFakWc0AG/mEVA+VF4HyLmbW/Dr2ML80ZtP46OueM5Ye7uZ iTVn7rQspasloN0tBSKWbLPDYOwgg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddukedgkeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrd dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 93C7C3280059; Sun, 24 May 2020 11:27:17 -0400 (EDT) From: Thomas Monjalon To: Pu Xu <583493798@qq.com> Cc: "cuanduo@126.com" , dev@dpdk.org, "Burakov, Anatoly" , "stable@dpdk.org" , "Ananyev, Konstantin" Date: Sun, 24 May 2020 17:27:16 +0200 Message-ID: <27420753.GspcrUYuLZ@thomas> In-Reply-To: References: <20200501161107.33786-1-583493798@qq.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ip_frag: fix fragmenting ipv4 packet with header option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 01/05/2020 22:43, Ananyev, Konstantin: > > > > > When fragmenting ipv4 packet, the data offset should be calculated through > > the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr). > > > > Fixes: 4c38e5532a07 ("ip_frag: refactor IPv4 fragmentation into a proper library") > > Cc: anatoly.burakov@intel.com > > Cc: stable@dpdk.org > > --- > > Acked-by: Konstantin Ananyev The patch cannot be merged because it is missing a Signed-off-by line. In general, please follow the contributions guideline here: http://core.dpdk.org/contribute/#send Would be appreciated to number subsequent versions of the patches, and use --in-reply-to to keep them threaded.