From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 6715A8EA1 for ; Fri, 22 Jan 2016 15:45:03 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id r129so216105121wmr.0 for ; Fri, 22 Jan 2016 06:45:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=Jpm7e1y0Gz3C0LLOkNG/a7EbOeAjVLZK6xKvahvEsGs=; b=WSFtJK/X+pbNPx6LrvQTfKcapp7jF03Lzvv3Gln0cqqpOe7QAgFP6g3oKOL8Zj0/G3 /20PvDCMo1byqbf42S9jeq7+DP8O89wDNy5Funjw3jTO4r1HKbrsL98Jf+tDUAs54gjv M1ENvi9YywlbT/CxWkmYRNlqEWeFllT92IeEeY7oKwZath7Has+4blzGwdsQrXAWRnMw j+C07zeLFAsTXOWzq2GsXmb+xNnNnp5Nu1JSk8/uDlkzh0rcASwD2LhrpZu8Qc6GNF/p /U+eeYHipUsx4n0dv3hOL/uNjShE9EDgCv5SOznRBbIrRZYo2gwZaEWEUs3kQNF9Asfj o/YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Jpm7e1y0Gz3C0LLOkNG/a7EbOeAjVLZK6xKvahvEsGs=; b=VRnl6a1LR0OsjNrsXRy2TTkS0unCcbRFT94iRYa3mJ4VRb0DgdvNXmKzfj7eEb6qbb rh19qBEely1sjEJzveSMplX24fN4FC7UXDRdfvF0Ri50xzSSaxrAw+PHXCyeFFYonGoC dn3zdk/cyTKv3La098bddfjhX2aSN73Yg91zLukgo8rPhJLvjm+6ALEN1A+ragoX937Y HTc9vQh5J6vsv8dr8HAsz9IKLH2rvnnqmsTtPwhai8KXRgltkN3rc9j7b8bLyY9dpo0e f6Ac0wpLUi9rF3BUDpUsa1htzs6GsM53l5pa/QE5+u47mn/KUxbNTdk3lcaqfH8XqhMO 4tPQ== X-Gm-Message-State: AG10YOQFEN5Jqtq/dvMmX73zOl/64D0sEuJAsHGvFDdc59ORdNgyjaY3bEDbCsDH+LlJIOxU X-Received: by 10.194.21.163 with SMTP id w3mr3560599wje.58.1453473903141; Fri, 22 Jan 2016 06:45:03 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id q6sm6259909wja.19.2016.01.22.06.45.01 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 22 Jan 2016 06:45:02 -0800 (PST) From: Thomas Monjalon To: "Tahhan, Maryam" , "David Harton (dharton)" Date: Fri, 22 Jan 2016 15:44:02 +0100 Message-ID: <27428043.8pduO1a1Qt@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1A27633A6DA49C4A92FCD5D4312DBF536B09F7A4@IRSMSX106.ger.corp.intel.com> References: <74583418c4374c349bfdea0c59b84118@XCH-RCD-016.cisco.com> <1A27633A6DA49C4A92FCD5D4312DBF536B09F7A4@IRSMSX106.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] Future Direction for rte_eth_stats_get() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jan 2016 14:45:03 -0000 2016-01-22 14:18, Tahhan, Maryam: > So what can be enabled again in struct rte_eth_stats from what was already there is the equivalent of: > * rx_length_errors > * rx_crc_errors > * rx_missed_errors - the deprecation notice was removed for this field. > * multicast > > What should be added in to distinguish between errors and drops. struct rte_eth_stats : > * rx_errors > * tx_errors > > As for the detailed rx errors and tx errors I'm open to feedback from you folks as to what should go in and what is too detailed. These weren't in struct rte_eth_stats previously, they are available through xstats and are uniformly named across the drivers. Oliver + Harry any thoughts? > > David I assume you are looking for all the missing fields to be added? They are not missing. They just not exactly match ones having a long history in Linux kernel. Please let's avoid to blindly mimic others without thinking about modern needs. > > > From: David Harton > > > > Is there a reason the stats have been deprecated? Why not keep > > > > the stats in line with the standard linux practices such as > > > > rtnl_link_stats64?