From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 5C0FC199AF for ; Tue, 24 Oct 2017 11:50:38 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BE2B020BE8; Tue, 24 Oct 2017 05:50:37 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 24 Oct 2017 05:50:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=9QlzhsmATgs14Eatf0kdmhdbAH hpi2NFTlyrh9ya5yo=; b=q+3Qy4eZcOwn9heiSREabffpL8TTsPrXDAduVHX5IY nz6kyVyP10RHraFIx2DsIWjrDnAEsioWUXGoYm9sN2+Cu/muH/GfTIIOiPqiRkxN eAD8x4vQFY0UxLC18hcvZOzy8qLJAGoBoblTQ35kNjRebZJ62oHHzLJ0RTQ3SOg7 A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=9Qlzhs mATgs14Eatf0kdmhdbAHhpi2NFTlyrh9ya5yo=; b=nLKep5T78gKyfgAfDyntja ICggNs8BfWUh/iid7aWkj0p9A0KKmQoG1oe5kcDGrS81PvRV99wunHMxKO6jc08Z mF394IoPYaRQ3azjSc/8nP9BjuXEIGhljE5JCvMTMmZEFbKjIWAh754ot0uP64YT q7j/uhPqY/nq47KsybRQK1oYk9/oK1zl7jr6wY7Ce/0jJEvrkdKVjn9sc4tgYsqh Lk0c7JtYpMrfRZ18Tbg5UIOLObb8m2XhcKGY3VTxdK0wHGj2v2yV82XDi31GSvRm hYsOi0V+/Yc/75PAzBeJ5yLtzKtAdNy+1gLDLPv7LkDBEbw7AdBHFuP7FiyN925w == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 68287247D8; Tue, 24 Oct 2017 05:50:37 -0400 (EDT) From: Thomas Monjalon To: Bernard Iremonger Cc: dev@dpdk.org, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, cristian.dumitrescu@intel.com, adrien.mazarguil@6wind.com, jasvinder.singh@intel.com Date: Tue, 24 Oct 2017 11:50:36 +0200 Message-ID: <2744961.4TGXLb1DrC@xps> In-Reply-To: <1508771778-617-2-git-send-email-bernard.iremonger@intel.com> References: <1508679124-5922-1-git-send-email-bernard.iremonger@intel.com> <1508771778-617-2-git-send-email-bernard.iremonger@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v10 1/4] librte_flow_classify: add flow classify library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 09:50:39 -0000 Hi, Few comments detailed below. The new compilation dependencies management needs changes in the Makefile. And the new log system should be used. > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -739,6 +739,13 @@ F: doc/guides/prog_guide/pdump_lib.rst > F: app/pdump/ > F: doc/guides/tools/pdump.rst > > +Flow classify > +M: Bernard Iremonger > +F: lib/librte_flow_classify/ > +F: test/test/test_flow_classify* > +F: examples/flow_classify/ > +F: doc/guides/sample_app_ug/flow_classify.rst > +F: doc/guides/prog_guide/flow_classify_lib.rst I don't how to classify this classify library :) If it is using librte_table, it should be part of Packet Framework? If not part of Packet Framework, please move it before "Distributor". The library is missing in the release notes (.so section and new features). > --- a/lib/librte_eal/common/include/rte_log.h > +++ b/lib/librte_eal/common/include/rte_log.h > @@ -88,6 +88,7 @@ struct rte_logs { > #define RTE_LOGTYPE_EFD 18 /**< Log related to EFD. */ > #define RTE_LOGTYPE_EVENTDEV 19 /**< Log related to eventdev. */ > #define RTE_LOGTYPE_GSO 20 /**< Log related to GSO. */ > +#define RTE_LOGTYPE_CLASSIFY 21 /**< Log related to flow classify. */ We must stop adding the legacy log types. Please switch to dynamic logs and remove CONFIG_RTE_LIBRTE_CLASSIFY_DEBUG. > +CFLAGS += -O3 > +CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) Now the dependencies to internal libraries must be explicitly declared in LDLIBS. > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -58,6 +58,7 @@ _LDLIBS-y += -L$(RTE_SDK_BIN)/lib > # > # Order is important: from higher level to lower level > # > +_LDLIBS-$(CONFIG_RTE_LIBRTE_FLOW_CLASSIFY) += -lrte_flow_classify > _LDLIBS-$(CONFIG_RTE_LIBRTE_PIPELINE) += -lrte_pipeline > _LDLIBS-$(CONFIG_RTE_LIBRTE_TABLE) += -lrte_table > _LDLIBS-$(CONFIG_RTE_LIBRTE_PORT) += -lrte_port Yes, rte_flow_classify is on top of packet framework.