From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from m97173.mail.qiye.163.com (m97173.mail.qiye.163.com [220.181.97.173]) by dpdk.org (Postfix) with ESMTP id 833C67EDC for ; Wed, 26 Sep 2018 10:16:24 +0200 (CEST) Received: from faicker.mo$ucloud.cn ( [120.132.1.226] ) by ajax-webmail-wmsvr13 (Coremail) ; Wed, 26 Sep 2018 16:15:36 +0800 (CST) X-Originating-IP: [120.132.1.226] Date: Wed, 26 Sep 2018 16:15:36 +0800 (CST) From: mocan To: "Zhang, Qi Z" Cc: "dev@dpdk.org" X-Priority: 3 X-Mailer: Coremail Webmail Server Version SP_ntes V3.5 build 20150911(74783.7961) Copyright (c) 2002-2018 www.mailtech.cn 163-hosting In-Reply-To: <039ED4275CED7440929022BC67E70611532A1A27@SHSMSX103.ccr.corp.intel.com> References: <1537249732-7530-1-git-send-email-faicker.mo@ucloud.cn> <039ED4275CED7440929022BC67E70611532A1A27@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Message-ID: <27452153.f1c7.16614f29e5f.Coremail.faicker.mo@ucloud.cn> X-CM-TRANSID: reCowAA3_3goQKtbNBejAA--.4593W X-CM-SenderInfo: pprft0w6xfz0lxgou0/1tbigwPNf1sflJvoPwACss X-Coremail-Antispam: 1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU== Content-Type: text/plain; charset=GBK Content-Transfer-Encoding: base64 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: put 5tuple check in front to jump over ntuple filter case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2018 08:16:25 -0000 SGkgUWksCgpJbiBpeGdiZV9mbG93X2NyZWF0ZSBmdW5jdGlvbiwgbnR1cGxlIGZpbHRlciBpcyBw YXJzZWQgZmlyc3QuIApJZiB0aGUgZmxvdyBpcyBjb25zaWRlcmVkIHRvIGJlIG50dXBsZSBmaWx0 ZXIsIGl0IHdpbGwgbm90IGdvIG9uIHRvIGp1ZGdlIGV0aGVydHlwZSBmaWx0ZXIsIHN5biBmaWx0 ZXIgYW5kIGZkaXIgZmlsdGVyLgpJbiB0aGUgZnVuY3Rpb24gbnR1cGxlX2ZpbHRlcl90b181dHVw bGUsIDUgdHVwbGUgaW5mbyBpcyBjaGVja2VkLCBidXQgaXQncyB0b28gbGF0ZSB0byBqdW1wIG92 ZXIgdGhlIG50dXBsZSBmaWx0ZXIgaWYgaXQncyBhIGZkaXIgZmlsdGVyLgoKCgoKCgoKCgpBdCAy MDE4LTA5LTIxIDIzOjQ4OjM3LCAiWmhhbmcsIFFpIFoiIDxxaS56LnpoYW5nQGludGVsLmNvbT4g d3JvdGU6Cj5IaSBGYWlja2VyOgo+Cj4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4+IEZy b206IGRldiBbbWFpbHRvOmRldi1ib3VuY2VzQGRwZGsub3JnXSBPbiBCZWhhbGYgT2YgZmFpY2tl ci5tbwo+PiBTZW50OiBUdWVzZGF5LCBTZXB0ZW1iZXIgMTgsIDIwMTggMTo0OSBQTQo+PiBUbzog ZGV2QGRwZGsub3JnCj4+IENjOiBmYWlja2VyLm1vIDxmYWlja2VyLm1vQHVjbG91ZC5jbj4KPj4g U3ViamVjdDogW2RwZGstZGV2XSBbUEFUQ0hdIG5ldC9peGdiZTogcHV0IDV0dXBsZSBjaGVjayBp biBmcm9udCB0byBqdW1wIG92ZXIKPj4gbnR1cGxlIGZpbHRlciBjYXNlCj4+IAo+PiBGcm9tOiAi ZmFpY2tlci5tbyIgPGZhaWNrZXIubW9AdWNsb3VkLmNuPgo+PiAKPj4gQ2hlY2sgaW4gZnVuYyBu dHVwbGVfZmlsdGVyX3RvXzV0dXBsZSBpcyB0b28gbGF0ZSBmb3IgZmRpciBmaWx0ZXIgcnVsZSwg YWRkIGNoZWNrCj4+IGluIGZ1bmMgY29uc19wYXJzZV9udHVwbGVfZmlsdGVyLgo+Cj5Xb3VsZCB5 b3UgZXhwbGFpbiBtb3JlIGFib3V0IHRoZSBpbnRlbnRpb24gZm9yIHRoaXMgcGF0Y2g/Cj5UaG91 Z2ggaXQgY2FuIGJlIG1vcmUgZmFzdCB0byByZWplY3QgYW4gaW52YWxpZCBmbG93LCBidXQgd2h5 IGl0IGlzIHRvbyBsYXRlIGluIHlvdXIgY2FzZT8gCj4KPlRoYW5rcwo+UWkKPgo+Cj4+IAo+PiBT aWduZWQtb2ZmLWJ5OiBmYWlja2VyLm1vIDxmYWlja2VyLm1vQHVjbG91ZC5jbj4KPj4gLS0tCj4+ ICBkcml2ZXJzL25ldC9peGdiZS9peGdiZV9mbG93LmMgfCAyOSArKysrKysrKysrKysrKysrKysr KysrKysrKysrKwo+PiAgMSBmaWxlIGNoYW5nZWQsIDI5IGluc2VydGlvbnMoKykKPj4gCj4+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL25ldC9peGdiZS9peGdiZV9mbG93LmMgYi9kcml2ZXJzL25ldC9p eGdiZS9peGdiZV9mbG93LmMKPj4gaW5kZXggMWFkZjFiOC4uZjBmYWZlYiAxMDA2NDQKPj4gLS0t IGEvZHJpdmVycy9uZXQvaXhnYmUvaXhnYmVfZmxvdy5jCj4+ICsrKyBiL2RyaXZlcnMvbmV0L2l4 Z2JlL2l4Z2JlX2Zsb3cuYwo+PiBAQCAtMzYzLDYgKzM2MywxNyBAQCBjb25zdCBzdHJ1Y3QgcnRl X2Zsb3dfYWN0aW9uICpuZXh0X25vX3ZvaWRfYWN0aW9uKAo+PiAgCQkJCWl0ZW0sICJOb3Qgc3Vw cG9ydGVkIGJ5IG50dXBsZSBmaWx0ZXIiKTsKPj4gIAkJCXJldHVybiAtcnRlX2Vycm5vOwo+PiAg CQl9Cj4+ICsJCWlmICgoaXB2NF9tYXNrLT5oZHIuc3JjX2FkZHIgIT0gMCAmJgo+PiArCQkJaXB2 NF9tYXNrLT5oZHIuc3JjX2FkZHIgIT0gVUlOVDMyX01BWCkgfHwKPj4gKwkJCShpcHY0X21hc2st Pmhkci5kc3RfYWRkciAhPSAwICYmCj4+ICsJCQlpcHY0X21hc2stPmhkci5kc3RfYWRkciAhPSBV SU5UMzJfTUFYKSB8fAo+PiArCQkJKGlwdjRfbWFzay0+aGRyLm5leHRfcHJvdG9faWQgIT0gVUlO VDhfTUFYICYmCj4+ICsJCQlpcHY0X21hc2stPmhkci5uZXh0X3Byb3RvX2lkICE9IDApKSB7Cj4+ ICsJCQlydGVfZmxvd19lcnJvcl9zZXQoZXJyb3IsCj4+ICsJCQkJRUlOVkFMLCBSVEVfRkxPV19F UlJPUl9UWVBFX0lURU0sCj4+ICsJCQkJaXRlbSwgIk5vdCBzdXBwb3J0ZWQgYnkgbnR1cGxlIGZp bHRlciIpOwo+PiArCQkJcmV0dXJuIC1ydGVfZXJybm87Cj4+ICsJCX0KPj4gCj4+ICAJCWZpbHRl ci0+ZHN0X2lwX21hc2sgPSBpcHY0X21hc2stPmhkci5kc3RfYWRkcjsKPj4gIAkJZmlsdGVyLT5z cmNfaXBfbWFzayA9IGlwdjRfbWFzay0+aGRyLnNyY19hZGRyOyBAQCAtNDMyLDYgKzQ0MywxNQo+ PiBAQCBjb25zdCBzdHJ1Y3QgcnRlX2Zsb3dfYWN0aW9uICpuZXh0X25vX3ZvaWRfYWN0aW9uKAo+ PiAgCQkJCWl0ZW0sICJOb3Qgc3VwcG9ydGVkIGJ5IG50dXBsZSBmaWx0ZXIiKTsKPj4gIAkJCXJl dHVybiAtcnRlX2Vycm5vOwo+PiAgCQl9Cj4+ICsJCWlmICgodGNwX21hc2stPmhkci5zcmNfcG9y dCAhPSAwICYmCj4+ICsJCQl0Y3BfbWFzay0+aGRyLnNyY19wb3J0ICE9IFVJTlQxNl9NQVgpIHx8 Cj4+ICsJCQkodGNwX21hc2stPmhkci5kc3RfcG9ydCAhPSAwICYmCj4+ICsJCQl0Y3BfbWFzay0+ aGRyLmRzdF9wb3J0ICE9IFVJTlQxNl9NQVgpKSB7Cj4+ICsJCQlydGVfZmxvd19lcnJvcl9zZXQo ZXJyb3IsCj4+ICsJCQkJRUlOVkFMLCBSVEVfRkxPV19FUlJPUl9UWVBFX0lURU0sCj4+ICsJCQkJ aXRlbSwgIk5vdCBzdXBwb3J0ZWQgYnkgbnR1cGxlIGZpbHRlciIpOwo+PiArCQkJcmV0dXJuIC1y dGVfZXJybm87Cj4+ICsJCX0KPj4gCj4+ICAJCWZpbHRlci0+ZHN0X3BvcnRfbWFzayAgPSB0Y3Bf bWFzay0+aGRyLmRzdF9wb3J0Owo+PiAgCQlmaWx0ZXItPnNyY19wb3J0X21hc2sgID0gdGNwX21h c2stPmhkci5zcmNfcG9ydDsgQEAgLTQ2Nyw2Cj4+ICs0ODcsMTUgQEAgY29uc3Qgc3RydWN0IHJ0 ZV9mbG93X2FjdGlvbiAqbmV4dF9ub192b2lkX2FjdGlvbigKPj4gIAkJCQlpdGVtLCAiTm90IHN1 cHBvcnRlZCBieSBudHVwbGUgZmlsdGVyIik7Cj4+ICAJCQlyZXR1cm4gLXJ0ZV9lcnJubzsKPj4g IAkJfQo+PiArCQlpZiAoKHVkcF9tYXNrLT5oZHIuc3JjX3BvcnQgIT0gMCAmJgo+PiArCQkJdWRw X21hc2stPmhkci5zcmNfcG9ydCAhPSBVSU5UMTZfTUFYKSB8fAo+PiArCQkJKHVkcF9tYXNrLT5o ZHIuZHN0X3BvcnQgIT0gMCAmJgo+PiArCQkJdWRwX21hc2stPmhkci5kc3RfcG9ydCAhPSBVSU5U MTZfTUFYKSkgewo+PiArCQkJcnRlX2Zsb3dfZXJyb3Jfc2V0KGVycm9yLAo+PiArCQkJCUVJTlZB TCwgUlRFX0ZMT1dfRVJST1JfVFlQRV9JVEVNLAo+PiArCQkJCWl0ZW0sICJOb3Qgc3VwcG9ydGVk IGJ5IG50dXBsZSBmaWx0ZXIiKTsKPj4gKwkJCXJldHVybiAtcnRlX2Vycm5vOwo+PiArCQl9Cj4+ IAo+PiAgCQlmaWx0ZXItPmRzdF9wb3J0X21hc2sgPSB1ZHBfbWFzay0+aGRyLmRzdF9wb3J0Owo+ PiAgCQlmaWx0ZXItPnNyY19wb3J0X21hc2sgPSB1ZHBfbWFzay0+aGRyLnNyY19wb3J0Owo+PiAt LQo+PiAxLjguMy4xCj4+IAo+Cg== >From alejandro.lucero@netronome.com Wed Sep 26 10:18:16 2018 Return-Path: Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by dpdk.org (Postfix) with ESMTP id 900447CCA for ; Wed, 26 Sep 2018 10:18:16 +0200 (CEST) Received: by mail-ed1-f52.google.com with SMTP id h4-v6so1090550edi.6 for ; Wed, 26 Sep 2018 01:18:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uAiuDa61h+n31Z4E4OdK8DXYpKLoP5YvAxrNwB9xC3w=; b=L2b8d/0Ae66e2rNGsvjMn0VC1EZEZu0nv7Vx4Ws3DPJJ71b/1VftIMRvwAJVEpv0HJ ru3aFnJohN4CXXYMt7WFvtgYCIaa3T5WREP9hmxZntDPQZac3GUeyetevhNh42NYjpU+ 0i6KkAN3cJCvyADeHTbGE1XuKoQUnCK6u0O0STK+tsL61E+dY5qbHlaEXXe6qVZ4oe+h ODr++HUiEs6B+IhTZlTFXAztHb+dkJ4OPl6h1bL890Bh4y8i7MWA94pUAySvoIL9M3Mp HF5G24dtYyLj/sOrk4b99YugE/TDqFdPBMhsQrDCMIOnBSkiD117jWWdyClLEbluvP/3 BRNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uAiuDa61h+n31Z4E4OdK8DXYpKLoP5YvAxrNwB9xC3w=; b=nue/AvUisj3ALYFpAlgXOtHvOk3PH2EHUOOY37JdMkujiYh4E9d/eQGAVea36Ay+tw bkeRqe6ZxCp9a5mGJZ2aDFxe3Y0zv6SWeqPl0prlFG+BYyjWHsxqa2FFll9sEDNqG6ya wPGeq/0tCY2hmiSYnkfTQ5We1EsqJtpq4VjWLoaTcv8p7TpCTI/OeTH/yP/xSabLM9gA kMwd2viLja2UnG45ECFpSs+NeORvEfLfWq+HLzZfOWyv5iK64YTesu06AKMUJDOz5EkA 6WMcy4yDVAfrWNFtwquxqbddMYilsmpwwoAUhJJYg9voeHEQUteRoM6ZArrlMvdPk8FC HLlg== X-Gm-Message-State: ABuFfogJsbSiP1ZYKx/BXPnvZ2xUtxJWggYCHiSrQQbzRRZb3vH1RjyF 0NpEEQJmXTjfepbKF0I/P23a86f/YXc1uVI1z7cE2g== X-Google-Smtp-Source: ACcGV62RgHizUU5mzpVimUTq5ClEkCziVWMAlmbfZt5wKq/wBvbFPoMvPMByBWCrBo1e3qpqWCNiqXFvQOMRK/xpSYE= X-Received: by 2002:a50:f05e:: with SMTP id u30-v6mr7577301edl.91.1537949896240; Wed, 26 Sep 2018 01:18:16 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alejandro Lucero Date: Wed, 26 Sep 2018 09:18:02 +0100 Message-ID: To: "Burakov, Anatoly" Cc: dev , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] secondary processes and private data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2018 08:18:16 -0000 On Tue, Sep 25, 2018 at 3:20 PM Burakov, Anatoly wrote: > On 25-Sep-18 3:10 PM, Alejandro Lucero wrote: > > I've a problem when part of device private data needs to be private per > > process. > > > > Current multiprocess support shares device private data between primary > > and secondaries but it is all dependent on a pointer initialized to the > > same memory address by the multiprocess support code. If there is a > > per-process data, If a secondary process changes it the primary gets > > affected, and the same for additional secondaries which will affect not > > just the primary but other previous secondaries. > > > > The solution is to add support for this inside struct rte_eth_dev, > > something like > > > > void *secondary_priv_data; > > > > so it is up to the secondaries to use this field if necessary. > > > > NFP PMD creates the required rte_eth_devs specifically, similar to what > > is done inside rte_ethdev.c but adding initialization for an interface > > needed when calling device ethdev_init function. There are other PMDs > > doing this but none has this requirement for per-process private data. > > > > Please, let me know what you think about this change to struct > > rte_ethdev or if you have a better idea for solving this problem. > > > > Thanks > > > > Perhaps "private data" is a bad name for data that is shared across > primary and secondary processes... > > I don't have anything against the idea. > > I will add some comments in the struct for leaving it cleat private applies to device but not process. It will make easier to understand the new field. Thanks > -- > Thanks, > Anatoly >