From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D65CCA0526; Mon, 20 Jan 2020 23:52:48 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CF7551BFFC; Mon, 20 Jan 2020 23:52:47 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 1768B1BFF6 for ; Mon, 20 Jan 2020 23:52:47 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6087A217DD; Mon, 20 Jan 2020 17:52:46 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 20 Jan 2020 17:52:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=1H3TDe1PZKr/WWLoDohlTW1VwUwcqoSz7rGCoRmn5Kg=; b=gVXxRYYDGQ0v /93d5EAMICgBEgMyjSw1X9IXc4Ur+7xtk63dcgeiULlUteFR+MhSLbdOIYw+A16I uwfMbOFih/s7F5Lb5/vee/msMFFYUT6/5ZBdBverda/ZcAtowYBceBCbDYt0Qdqe ckE+K+dXM/hoF9QyIDCWGL1UYqQIdfQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=1H3TDe1PZKr/WWLoDohlTW1VwUwcqoSz7rGCoRmn5 Kg=; b=KPSkyDgHe5B4k7Pi0lYy8pH+DrLnB6956mY8JauVjsi4Nc0vaDEjN4RE9 HC2fNLmBwvVvvclGNtFSXsi4rDeYeX6qQmB38tsJmCZ8SPSaJtVER2zn16hNb7CK oaCfmr5gpfJyLv+ESi2AIvj9RSaTVdZIeEeBVhFlY4c1zqszvAMbY+YlcjP9o6km 9CbQEib8bRwoDGEpoXEOC3CcEmWGmtLO4K9q6yikVuRQv0a4+EJJwGIHkaRvlFtC 6uOb4uZ2Z8NyeUl4KJ9mbibM8e8QFvBA3Xpf744Wv3PPWQd66XoqV0reEp4uTq3i P58huSiQjpiWTGg+J36t6c3fXW5mQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudejgddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1EA9A306098F; Mon, 20 Jan 2020 17:52:45 -0500 (EST) From: Thomas Monjalon To: Viacheslav Ovsiienko , olivier.matz@6wind.com, Stephen Hemminger Cc: dev@dpdk.org, matan@mellanox.com, rasland@mellanox.com, orika@mellanox.com, shahafs@mellanox.com Date: Mon, 20 Jan 2020 23:52:44 +0100 Message-ID: <2748118.A7TYtsqqnE@xps> In-Reply-To: <20200120124342.6b308e18@hermes.lan> References: <20191118094938.192850-1-shahafs@mellanox.com> <1579541003-2399-2-git-send-email-viacheslavo@mellanox.com> <20200120124342.6b308e18@hermes.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 1/5] mbuf: introduce routine to get private mbuf pool flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/01/2020 21:43, Stephen Hemminger: > On Mon, 20 Jan 2020 17:23:19 +0000 > Viacheslav Ovsiienko wrote: > > > The routine rte_pktmbuf_priv_flags is introduced to fetch > > the flags from the mbuf memory pool private structure > > in unified fashion. > > > > Signed-off-by: Viacheslav Ovsiienko > > Acked-by: Olivier Matz > > --- > > --- a/lib/librte_mbuf/rte_mbuf.h > > +++ b/lib/librte_mbuf/rte_mbuf.h > > +static inline uint32_t > > +rte_pktmbuf_priv_flags(struct rte_mempool *mp) > > +{ > > + struct rte_pktmbuf_pool_private *mbp_priv; > > + > > + mbp_priv = (struct rte_pktmbuf_pool_private *)rte_mempool_get_priv(mp); > > + return mbp_priv->flags; > > +} > > Looks fine, but a couple of minor suggestions. > > > Since this doesn't modify the mbuf, the arguments should be const. > Since rte_mempool_get_priv returns void *, the cast is unnecessary. It makes sense. Please let's make these minor changes in a separate patch as I am closing -rc1 with the v6 of this series included. Thanks