From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nbfkord-smmo04.seg.att.com (nbfkord-smmo04.seg.att.com [209.65.160.86]) by dpdk.org (Postfix) with ESMTP id 40FD0FA3B for ; Fri, 2 Dec 2016 16:03:57 +0100 (CET) Received: from unknown [193.34.186.16] (EHLO webmail.solarflare.com) by nbfkord-smmo04.seg.att.com(mxl_mta-7.2.4-7) with ESMTP id d5d81485.2b81b5481940.1408568.00-2449.1524282.nbfkord-smmo04.seg.att.com (envelope-from ); Fri, 02 Dec 2016 15:03:57 +0000 (UTC) X-MXL-Hash: 58418d5d38b61b09-56e79e77f34553a37f5f145519fd9999b1bd310d Received: from unknown [193.34.186.16] (EHLO webmail.solarflare.com) by nbfkord-smmo04.seg.att.com(mxl_mta-7.2.4-7) over TLS secured channel with ESMTP id a5d81485.0.1408560.00-2375.1524266.nbfkord-smmo04.seg.att.com (envelope-from ); Fri, 02 Dec 2016 15:03:55 +0000 (UTC) X-MXL-Hash: 58418d5b427c996b-07e1fe99180e2338d684e255d674856bc6c25f7a Received: from [192.168.38.17] (84.52.89.52) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Fri, 2 Dec 2016 15:03:49 +0000 To: Ferruh Yigit , References: <1479740470-6723-1-git-send-email-arybchenko@solarflare.com> <1480436367-20749-1-git-send-email-arybchenko@solarflare.com> <1480436367-20749-2-git-send-email-arybchenko@solarflare.com> <1e5503bf-8150-a4db-fd16-8c3e4c8e9737@intel.com> From: Andrew Rybchenko Message-ID: <27521ea0-8151-311f-1889-16fcb30d217a@solarflare.com> Date: Fri, 2 Dec 2016 18:03:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1e5503bf-8150-a4db-fd16-8c3e4c8e9737@intel.com> X-Originating-IP: [84.52.89.52] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.000.1202-22736.003 X-TM-AS-Result: No--7.598100-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-AnalysisOut: [v=2.1 cv=TYuQwEkh c=1 sm=1 tr=0 a=8P+NB+fYZDP74ap4g4d9Kw==] X-AnalysisOut: [:17 a=RB3BGLmKESwA:10 a=n5n_aSjo0skA:10 a=zRKbQ67AAAAA:8 a] X-AnalysisOut: [=OG3GkQMsWlk0x1yufsYA:9 a=pILNOxqGKmIA:10 a=QyXUC8HyAAAA:8] X-AnalysisOut: [ a=Mvp-r7xByZU0HVEps7UA:9 a=JZJiqjeo0k-VjazX:21 a=_W_S_7Ve] X-AnalysisOut: [coQA:10 a=PA03WX8tBzeizutn5_OT:22 a=avl4LiGQNoF5OB0DmCJ7:2] X-AnalysisOut: [2] X-Spam: [F=0.2000000000; CM=0.500; S=0.200(2015072901)] X-MAIL-FROM: X-SOURCE-IP: [193.34.186.16] Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 01/55] net/sfc: libefx-based PMD stub sufficient to build and init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Dec 2016 15:03:57 -0000 On 12/02/2016 05:54 PM, Ferruh Yigit wrote: > On 11/29/2016 4:18 PM, Andrew Rybchenko wrote: >> The PMD is put into the sfc/efx subdirectory to have a place for > .. into sfc subdirectory .. > >> the second PMD and library shared by both. > Since all will go into same (sfc) folder, should mention from this? This > looks like justification of previous sfc/efx. I think it should go away now since we have no efx subdirectory. It was necessary to explain unusual structure, but right now we have usual structure. Should I send v3 or will you simply remove it before pushing? Thanks for noticing it, Andrew. >> Enable the PMD by default on supported configuratons. >> >> Reviewed-by: Andy Moreton >> Signed-off-by: Andrew Rybchenko >> ---