From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 487DE2956 for <dev@dpdk.org>; Wed, 6 Apr 2016 11:23:49 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id 191so51046049wmq.0 for <dev@dpdk.org>; Wed, 06 Apr 2016 02:23:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Q0qwE6K9XlJqfy4ICzms772dU5r6SMKE+CI8GKuzUgo=; b=WMcLWjHNL+/TjcL4BdcJTB+dtRXUiLjg8clldbiSOjiGCrU57rovgL5Pqdi3dSWyVh ebVi1AgjQApOS8pKQcExdDdjyJrBAp6rcjSV1fAUJ/Fggi04A2ZSeNOhmYvz7l0mxtNs WhLAg+32575gnlkD2wUyk5PhHpvLa9qR6p9m7PvNs0+RvsM/jrU24nT2gEP39N4G8d5J YP0kiWKZmkN+1YVHYmYCfPTLeOo7gGq3GqahQB7oEdRvLv8mQezCp3nkuMWB+TvLAAoV WIYxf19mGsnRKe0ocAxC6ULZ6PRzyseDwYACK9yO75fnzaGyW9UdpXDbViKRp61Ayoq6 qZMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=Q0qwE6K9XlJqfy4ICzms772dU5r6SMKE+CI8GKuzUgo=; b=JVEYGH9eHlyuAVe88l6MeTphCWl6eVbwCO9loa0I4OUxsxGL2aFUwk1S7PWqW2OQct iueMbgn0kc9NdeHSEwcMXk9haUh4PeW4SWIPwYK/+f77GM6PUYbiytalDjB+6BjoWmwv ghxmsznRsIzs0SyvHXeHKsvWA4bJBcsJgAs/04kUfLTmMbdsfT82b+5Y1FXEtGnRvlrF 1/PH3cLpcN6x82xuZ6D0ir0laMotNJJh4uIcRoifh0zUoPzhZSgEeaCi+sesgoOzER3y We8iCDXFZYx1wp1UlDQt3pd1iXY3I/pUGDB76CvSAY9c7TDUPC5KY16OhWavU7Qgyxpk Rf9Q== X-Gm-Message-State: AD7BkJJh6jBlAT94eSDpQWJkeSA4cicM/rmorf4Z2NPsP2TRQvy6zDBL71fBWyeFN4lwRAtO X-Received: by 10.28.230.69 with SMTP id d66mr3538037wmh.54.1459934629099; Wed, 06 Apr 2016 02:23:49 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id gl8sm2213148wjb.30.2016.04.06.02.23.48 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 06 Apr 2016 02:23:48 -0700 (PDT) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: "Van Haaren, Harry" <harry.van.haaren@intel.com> Cc: "'David Harton (dharton)'" <dharton@cisco.com>, dev@dpdk.org, "Tahhan, Maryam" <maryam.tahhan@intel.com>, olivier.matz@6wind.com Date: Wed, 06 Apr 2016 11:22:10 +0200 Message-ID: <27546869.TpcjJvEkXE@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <E923DB57A917B54B9182A2E928D00FA6128A41B7@IRSMSX102.ger.corp.intel.com> References: <1459879089-3430-1-git-send-email-harry.van.haaren@intel.com> <1955261.zYXyGahjVu@xps13> <E923DB57A917B54B9182A2E928D00FA6128A41B7@IRSMSX102.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: announce xstats api change for 16.07 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 06 Apr 2016 09:23:49 -0000 2016-04-06 09:02, Van Haaren, Harry: > + David Harton, > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Subject: Re: [dpdk-dev] [PATCH] doc: announce xstats api change for 16.07 > > 2016-04-05 18:58, Harry van Haaren: > > > +* ABI change is planned for the xstats API > > > Have you already submitted a RFC patch to let us have an opinion on the change? > > We need, at least, to see the structure changes. > > This API break is to allow changing the API of xstats given the conversation that was on-list, as discussed in this thread: > > http://thread.gmane.org/gmane.comp.networking.dpdk.devel/31728/focus=31903 > > The issue we are going to fix is that currently PMDs copy strings when retrieving statistics, which causes unnecessary overhead. The implementation is not decided yet, but using an int->value mapping seems logical. I am not sure performance is so much critical when retrieving statistics. The extended stats can be infinitely extended. So a string identifier seems a lot more natural. I do not agree to add a new numeric identifier in the API each time a driver wants to report a specific statistic for debugging purpose. > The rte_eth_xstats struct size may be modified, and the API to retrieve statistics will be modified.