From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23CA4A04B5; Wed, 30 Sep 2020 18:53:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 85CFC1D589; Wed, 30 Sep 2020 18:52:58 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 3BB8C1D585 for ; Wed, 30 Sep 2020 18:52:57 +0200 (CEST) IronPort-SDR: lpgiLAm6mYqyEEKGJwu/nIKA3CisSs6nDMScknIlSsqTcghceIWottzfSundzz6BG0diJKPkjK 4j8RwuKcFq3A== X-IronPort-AV: E=McAfee;i="6000,8403,9760"; a="159879131" X-IronPort-AV: E=Sophos;i="5.77,322,1596524400"; d="scan'208";a="159879131" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2020 09:52:55 -0700 IronPort-SDR: n6hTZwqBGG19kjD7+g082FHLv3gAsbzWpZ0CouLY3BjUxW4/h9XHcBFcLMiKkOwbRr+HuiGLLp K/FBXW7W0IpA== X-IronPort-AV: E=Sophos;i="5.77,322,1596524400"; d="scan'208";a="312653254" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.229.39]) ([10.213.229.39]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2020 09:52:53 -0700 To: "Min Hu (Connor)" , dev@dpdk.org Cc: konstantin.ananyev@intel.com, thomas@monjalon.net, arybchenko@solarflare.com, linuxarm@huawei.com References: <1599534347-20430-1-git-send-email-humin29@huawei.com> <1601341419-15870-1-git-send-email-humin29@huawei.com> <1601341419-15870-4-git-send-email-humin29@huawei.com> From: Ferruh Yigit Message-ID: <27557195-5b72-9db5-f1b2-924139243b37@intel.com> Date: Wed, 30 Sep 2020 17:52:49 +0100 MIME-Version: 1.0 In-Reply-To: <1601341419-15870-4-git-send-email-humin29@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH V15 3/3] app/testpmd: add FEC command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/29/2020 2:03 AM, Min Hu (Connor) wrote: > This commit adds testpmd capability to query and config FEC > function of device. This includes: > - show FEC capabilities, example: > testpmd> show port 0 fec capabilities > - show FEC mode, example: > testpmd> show port 0 fec_mode > - config FEC mode, example: > testpmd> set port 0 > I guess it is: set port fec_mode > where: > > auto|off|rs|baser are four kinds of FEC mode which dev > support according to MAC link speed. > > Signed-off-by: Min Hu (Connor) > Reviewed-by: Wei Hu (Xavier) > Reviewed-by: Chengwen Feng > Reviewed-by: Chengchang Tang > --- > v12->v13: > change fec get capa interface. > > --- > v10->v11: > change mode to capa bitmask. > > --- > v8->v9: > added acked-by. > > --- > v6->v7: > used RTE_DIM(fec_mode_name) instead of RTE_ETH_FEC_NUM > > --- > v5->v6: > fixed code styles according to DPDK coding style. > added _eth prefix. > > --- > v4->v5: > Add RTE_ prefix for public FEC mode enum. > > --- > v3->v4: > adjust the display format of FEC mode > > --- > v2->v3: > adjust the display format of FEC capability. > > --- > app/test-pmd/cmdline.c | 223 +++++++++++++++++++++++++++++++++++++++++++++++++ > app/test-pmd/config.c | 91 ++++++++++++++++++++ > app/test-pmd/testpmd.h | 2 + > 3 files changed, 316 insertions(+) Can you please update the testpmd documenatation for the new commands? Also can add the new command to the --help output? ('cmd_help_long_parsed()') <...> > +cmdline_parse_inst_t cmd_set_fec_mode = { > + .f = cmd_set_port_fec_mode_parsed, > + .data = NULL, > + .help_str = "set port fec_mode ", Can you please update the help string as: "set port fec_mode auto|off|rs|baser" '<>' is to define the variable name, like in '' you expect numbers like 0,1,2 .. but 'auto|off|rs|baser' are keywords, not variables.