From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 61F13A0524;
	Wed, 14 Apr 2021 04:16:22 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 355611615AE;
	Wed, 14 Apr 2021 04:12:51 +0200 (CEST)
Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191])
 by mails.dpdk.org (Postfix) with ESMTP id 9EF6216147B
 for <dev@dpdk.org>; Wed, 14 Apr 2021 04:12:49 +0200 (CEST)
Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60])
 by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FKmCX1tqQztW6x;
 Wed, 14 Apr 2021 10:10:32 +0800 (CST)
Received: from [10.67.103.128] (10.67.103.128) by
 DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id
 14.3.498.0; Wed, 14 Apr 2021 10:12:47 +0800
From: "Min Hu (Connor)" <humin29@huawei.com>
To: David Marchand <david.marchand@redhat.com>
CC: dev <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, "Bruce
 Richardson" <bruce.richardson@intel.com>, Thomas Monjalon
 <thomas@monjalon.net>
References: <1617877043-11025-1-git-send-email-humin29@huawei.com>
 <CAJFAV8xExySu_ybA7fNzY+9YS6zckF9GnhN-zK7SVVNKXpD=CA@mail.gmail.com>
 <6ffcacd6-b14e-9628-6953-f64549e36792@huawei.com>
Message-ID: <27561131-9f2f-2799-7c3c-567d53e0a35f@huawei.com>
Date: Wed, 14 Apr 2021 10:12:47 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.1
MIME-Version: 1.0
In-Reply-To: <6ffcacd6-b14e-9628-6953-f64549e36792@huawei.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.103.128]
X-CFilter-Loop: Reflected
Subject: Re: [dpdk-dev] [PATCH] examples/helloworld: add eal clean up to the
 example
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



在 2021/4/8 21:09, Min Hu (Connor) 写道:
> 
> 
> 在 2021/4/8 19:21, David Marchand 写道:
>> On Thu, Apr 8, 2021 at 12:17 PM Min Hu (Connor) <humin29@huawei.com> 
>> wrote:
>>>
>>> From: Chengchang Tang <tangchengchang@huawei.com>
>>>
>>> According to the programming guide, the rte_eal_init should be used 
>>> pairs
>>> with rte_eal_cleanup.
>>>
>>> So, we should add the use of clean up to the hello world example to
>>> encourage new users of DPDK to use it.
>>>
>>> Fixes: af75078fece3 ("first public release")
>>
>> rte_eal_cleanup() was introduced with aec9c13c5257 ("eal: add function
>> to release internal resources") from v18.02.
>>
>> Other examples probably need fixes too.
>> $ git grep -l rte_eal_init examples/ |xargs grep -L rte_eal_cleanup |wc
>>       52      52    1623
>>
> Thanks David,
>      I will fix other examples in next patches.
>>
Hi, David and all,
	I have sent one set of patches to fix it, the headline is
	"[PATCH 00/45] add eal clean up to the example"
	Please review it, thanks.
> .