From: Thomas Monjalon <thomas@monjalon.net>
To: Huisong Li <lihuisong@huawei.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, david.marchand@redhat.com,
lihuisong@huawei.com
Subject: Re: [dpdk-dev] [RFC V1] examples/l3fwd-power: fix memory leak for rte_pci_device
Date: Tue, 07 Sep 2021 10:53:44 +0200 [thread overview]
Message-ID: <2757246.qzpMWD9H8a@thomas> (raw)
In-Reply-To: <20210907034108.58763-1-lihuisong@huawei.com>
07/09/2021 05:41, Huisong Li:
> Calling rte_eth_dev_close() will release resources of eth device and close
> it. But rte_pci_device struct isn't released when app exit, which will lead
> to memory leak.
That's a PMD issue.
When the last port of a PCI device is closed, the device should be freed.
> + /* Retrieve device address in eth device before closing it. */
> + eth_dev = &rte_eth_devices[portid];
You should not access this array, considered internal.
> + rte_dev = eth_dev->device;
> rte_eth_dev_close(portid);
> + ret = rte_dev_remove(rte_dev);
next prev parent reply other threads:[~2021-09-07 8:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 3:41 Huisong Li
2021-09-07 8:53 ` Thomas Monjalon [this message]
2021-09-08 2:01 ` Huisong Li
2021-09-08 7:20 ` Thomas Monjalon
2021-09-16 8:01 ` Huisong Li
2021-09-16 10:36 ` Thomas Monjalon
2021-09-17 2:13 ` Huisong Li
2021-09-17 12:50 ` Thomas Monjalon
2021-09-18 3:24 ` Huisong Li
2021-09-18 8:46 ` Thomas Monjalon
2021-09-26 12:20 ` Huisong Li
2021-09-26 19:16 ` Thomas Monjalon
2021-09-27 1:44 ` Huisong Li
2021-09-30 6:28 ` Huisong Li
2021-09-30 7:50 ` Thomas Monjalon
2021-10-08 6:26 ` lihuisong (C)
2021-10-08 6:29 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2757246.qzpMWD9H8a@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=lihuisong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).