From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] eal: pci probe and adjust_config should be void
Date: Mon, 20 Apr 2015 15:14:15 +0200 [thread overview]
Message-ID: <2757566.zEsJEgcNg7@xps13> (raw)
In-Reply-To: <1429284934-3261-3-git-send-email-stephen@networkplumber.org>
2015-04-17 08:35, Stephen Hemminger:
> This functions always returned 0 and therefore should be void.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> lib/librte_eal/common/eal_common_options.c | 3 +--
> lib/librte_eal/common/eal_common_pci.c | 7 ++-----
> lib/librte_eal/common/eal_options.h | 2 +-
> lib/librte_eal/common/include/rte_pci.h | 6 +-----
> lib/librte_eal/linuxapp/eal/eal.c | 6 ++----
> 5 files changed, 7 insertions(+), 17 deletions(-)
Why bsdapp is not changed?
You posted a similar patch few days before which was modifying bsdapp:
http://dpdk.org/dev/patchwork/patch/4306/
next prev parent reply other threads:[~2015-04-20 13:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 15:35 [dpdk-dev] [PATCH 0/2] functions with useless return Stephen Hemminger
2015-04-17 15:35 ` [dpdk-dev] [PATCH 1/2] log: rte_openlog_stream should be void Stephen Hemminger
2015-05-19 10:24 ` Bruce Richardson
2015-07-30 0:35 ` Stephen Hemminger
2015-04-17 15:35 ` [dpdk-dev] [PATCH 2/2] eal: pci probe and adjust_config " Stephen Hemminger
2015-04-20 13:14 ` Thomas Monjalon [this message]
2015-04-17 15:53 ` [dpdk-dev] [PATCH 0/2] functions with useless return Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2757566.zEsJEgcNg7@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).