From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7474A41CDD; Sun, 19 Feb 2023 12:06:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0EA4B42B8B; Sun, 19 Feb 2023 12:06:01 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id C73F540698 for ; Sun, 19 Feb 2023 12:05:59 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 5A5755C0116; Sun, 19 Feb 2023 06:05:58 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 19 Feb 2023 06:05:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1676804758; x= 1676891158; bh=tXpX2VNZjPpsqB4A017bfhqR9xnFZ0OBMqU4JQ53R4E=; b=X kFRSR6y0OwQH+Yy0uz2bgubjYNpYwgLthRSh1zSkrYryQeBiFMUMxIpnOtIv2ZfC yaUSwV+42Jz4eoeB8lf6647CPjqH32AHQ/xPvcw6n8+3k9HNuMuPDTd3zzGG5ogy um70z1dGau63K9mPaqkXjLOCalUTkSjD5f2Cjo/5A3mZvOGLrZpraEB1P0A0uuPh EfAYvEJ3GS60IvlY1gQ7/mcemNLhb+YGNSgNQaaOMKKxkX5Nbag3tNlqSR2wcs1r 7yDmrDRRlBpS3NO+7F9TIvuioHIqpw8PuA06rod8PLmcFKhvjYc+ZvrhxEvXymcu Ukha7bC7nzQyLCulwzM/w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1676804758; x= 1676891158; bh=tXpX2VNZjPpsqB4A017bfhqR9xnFZ0OBMqU4JQ53R4E=; b=f qLzGF++KiGZVk4yjd/lS4ck62KULv6QZm2Ts5aGEf/9l3MKoAvurY9TBpaA7meY8 9BTPUHgYAOtKm8GH+VMM1HbDWtTEi6vy3oo9OW9JI5rWXbjh3HTxVbm/Se2PXc64 rL/yhjo1Hf7iP9RWxZMPasIYKJ/gKqHj21NMpe/rLGmYnlmvZteBDc/L3AHQPwzB Hcc8FNLjKKvmpkQpwy7DqrYPid/HaYPrxtI1zwJ1TGgTrmXC4KVXxoHtmM8aAcs6 4HGo1zeLv6dk1XCC6n5sgUvCNJ+hQ82PzP4/UtfoPFgGL+zQLxBPdq1N9kPhoOzw D807BnY/gQ4mPUR1coSqQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejfedgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 Feb 2023 06:05:56 -0500 (EST) From: Thomas Monjalon To: Shijith Thotton , "Wu, Jingjing" , "Xing, Beilei" , Morten =?ISO-8859-1?Q?Br=F8rup?= Cc: dev@dpdk.org, Bruce Richardson , fengchengwen , david.marchand@redhat.com Subject: Re: Building DPDK with IOVA_AS_VA Date: Sun, 19 Feb 2023 12:05:55 +0100 Message-ID: <2759826.XrmoMso0CX@thomas> In-Reply-To: <16603912.Ash8RoxBsO@thomas> References: <98CBD80474FA8B44BF855DF32C47DC35D8755E@smartserver.smartshare.dk> <16603912.Ash8RoxBsO@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 19/02/2023 11:01, Thomas Monjalon: > 09/12/2022 10:33, fengchengwen: > > The hns3 and idpf both use static_library to build advanced vector (e.g. SVE for hns3 and AVX512 for idpf). > > The static-library is still compiled even the PMD is not compiled, and this lead to the compile fail problem. > > > > Although the following could solve the problem, but is there a better plan? > > +if dpdk_conf.get('RTE_IOVA_AS_PA') == 0 > > + build = false > > + reason = 'driver does not support disabling IOVA as PA mode' > > + subdir_done() > > +endif > > Yes there is a better plan: fix drivers/meson.build. > We must move the "continue" to skip the driver as soon as possible. Scratch that, it's a stupid idea. The problem is generating sub-libraries inside the driver in order to map some specific compiler options with some files. Looks like we must disable the build inside the driver: +if not get_option('enable_iova_as_pa') + subdir_done() +endif No need to give reason or disable build as it will be done anyway in drivers/meson.build.