From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 50CB0BB76 for ; Wed, 26 Oct 2016 16:25:35 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP; 26 Oct 2016 07:25:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,551,1473145200"; d="scan'208";a="184075999" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.146]) ([10.237.220.146]) by fmsmga004.fm.intel.com with ESMTP; 26 Oct 2016 07:25:33 -0700 To: Shreyansh Jain , thomas.monjalon@6wind.com References: <1477485486-20433-1-git-send-email-shreyansh.jain@nxp.com> <1477486817-1284-1-git-send-email-shreyansh.jain@nxp.com> <8ed305c5-92aa-a169-533e-47057ea3e6fd@nxp.com> From: Ferruh Yigit Message-ID: <275ffc52-acb0-c177-da32-fb8c3fee497a@intel.com> Date: Wed, 26 Oct 2016 15:25:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <8ed305c5-92aa-a169-533e-47057ea3e6fd@nxp.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] eal: fix libabi macro for device generalization patches X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Oct 2016 14:25:35 -0000 Hi Shreyansh, On 10/26/2016 2:12 PM, Shreyansh Jain wrote: > On Wednesday 26 October 2016 06:30 PM, Shreyansh Jain wrote: >> rte_device/driver generalization patches [1] were merged without a change >> in the LIBABIVER macro. This patches bumps the macro of affected libs. >> >> Also, deprecation notice from 16.07 has been removed and release notes for >> 16.11 added. >> >> Signed-off-by: Shreyansh Jain >> -- >> v2: >> - Mark bumped libraries in release_16_11.rst file >> - change code symbol names from text to code layout >> >> --- <...> >> .. code-block:: diff >> >> - libethdev.so.4 >> + + libethdev.so.4 > > Just noticed: > Should the '4' here reflect the current LIBABIVER number? > If so, I will send this patch again. Yes, as you guessed, it should be: - libethdev.so.4 + + libethdev.so.5 <...> >> diff --git a/lib/librte_eal/bsdapp/eal/Makefile b/lib/librte_eal/bsdapp/eal/Makefile >> index a15b762..122798c 100644 >> --- a/lib/librte_eal/bsdapp/eal/Makefile >> +++ b/lib/librte_eal/bsdapp/eal/Makefile >> @@ -48,7 +48,7 @@ LDLIBS += -lgcc_s >> >> EXPORT_MAP := rte_eal_version.map >> >> -LIBABIVER := 3 >> +LIBABIVER := 4 eal version seems already increased for this release, 2 => 3, in: d7e61ad3ae36 ("log: remove deprecated history dump") So NO need to increase it again, sorry for late notice, I just recognized it. Only librte_ether and librte_cryptodev requires the increase. <...> Thanks, ferruh