From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 0739E919D for ; Fri, 30 Oct 2015 15:32:31 +0100 (CET) Received: by wmeg8 with SMTP id g8so13386897wme.1 for ; Fri, 30 Oct 2015 07:32:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=R5mOdc8Bp50r8bY56lWQLe7v1xhK581jN7psizsyiOQ=; b=sl/7RjQ5CnJxmQEgLZHQaxZb+IBTTEsgvtL7oZhDf3IYmC8WmmLm0WROl49/9QfLvK Hm8LbGMyV2SH4yDw932BqbBGmrNcpETTpEh+eWp7khU5dhYWO9pYwA8MW1hRMOMDoKar q7kg/QAR2jCOfRqpy+m81Df5KWx038fGebLT+4CXaXtVmhWm6A6HU0T5XGdSIkzmmmM0 yw/Ry7EZTxTxbnAM7fjHJ4Ni7z7Q6mFRWkPQbDscogTU92N2jBFo1GhfehyYQUin2McF EBeCw8RoSmNOykv6Pi74wQjdiYBrP3key++08tSBGLYB3nAR7Eu7IsVetgPrEc2TyT28 qwMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=R5mOdc8Bp50r8bY56lWQLe7v1xhK581jN7psizsyiOQ=; b=IfAT8heOZ+P5SiwadxYpqzq49p1nZ8vwgLK+QuL2M0Q+HQyK3CWGm80QLH/9dOG2ex EyFOY1sgn0QyeTKFdmlqIxK1+zXH5sxHW7xvBQStvFKCjSCAw5YFZNZDvVz4U7V3sn5p 90xQSV5PJrMHUJW5YJPbThT3nG15wh4nve7AL/sHt29yQ/1suX+oqW77f6pVScIi1RZR LCxZ1DaS1J0aJIIup8bw3RM0zqAUmM7LrWWJSDqLXEoM8JwlmwAroZIBSASrbXZYoNop vXCszx/TMIIDNWzYPOZrP72N9zO90QOLiHyJ7731PPe1Ux4nA+KOJmwNQ3dr9SD4+ZoS t+XQ== X-Gm-Message-State: ALoCoQlVZ841LHRA/a/S7hS0l8QkU74hSKS9WJEWpYDjfV8Beh9hhusrK52FtkuVHJT6rFDLgayQ X-Received: by 10.28.10.132 with SMTP id 126mr3636018wmk.97.1446215550777; Fri, 30 Oct 2015 07:32:30 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id bf8sm7349784wjc.22.2015.10.30.07.32.29 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 30 Oct 2015 07:32:30 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson Date: Fri, 30 Oct 2015 15:31:19 +0100 Message-ID: <2760784.4fBWi2jOBS@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20151030142425.GC10520@bricha3-MOBL3> References: <1446210879-14242-1-git-send-email-jijiang.liu@intel.com> <20151030142227.GB10520@bricha3-MOBL3> <20151030142425.GC10520@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 2/2] lib/lpm:fix an initialization issue of valid_group in the delete_depth_small() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Oct 2015 14:32:31 -0000 2015-10-30 14:24, Bruce Richardson: > On Fri, Oct 30, 2015 at 02:22:27PM +0000, Bruce Richardson wrote: > > On Fri, Oct 30, 2015 at 09:14:39PM +0800, Jijiang Liu wrote: > > > > Title can be shortened to: "lpm: fix initialization of valid_group field" > > > > > Fixes an initialization issue of 'valid_group' in the delete_depth_small function. > > > > > > In this function, use new rte_lpm_tbl8_entry we call A to replace the old rte_lpm_tbl8_entry. But the valid_group do not set VALID, so it > > > will be INVALID. > > > > > > Then when adding a new route which depth is > 24,the tbl8_alloc() function will search the rte_lpm_tbl8_entrys to find INVALID > > > valid_group, and it will return the A to the add_depth_big function, so A's data is overridden. > > > > > > > Not sure this message is entirely clear. > > How about: > > When adding an entry to a tbl8, the .valid_group field should always be set, > > so that future adds do not accidently find and use this table, thinking it is > > currently invalid, i.e. unused, and thereby overwrite existing entries. > > > > > Signed-off-by: NaNa > > > > Assuming we get a little cleanup on commit title and log message (Thomas, perhaps > just a rewrite on commit?): Giving the name of a field in the title is not really useful for the overview. It's better to talk about the use case which is fixed.