From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B60694306F; Tue, 15 Aug 2023 13:10:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F4EF40F17; Tue, 15 Aug 2023 13:10:58 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id C6A5F40E25 for ; Tue, 15 Aug 2023 13:10:56 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 4F4875C00E6; Tue, 15 Aug 2023 07:10:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 15 Aug 2023 07:10:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1692097854; x=1692184254; bh=QA8A0kB52QbRAIzQhBdJIdLSOjxb67KhRYI fsCURo74=; b=j4aEzhS/WxB5KYQMU678Ap14cAfcyAi1UKKPCo/tClNV44XwtYk M3oaQQtMt+8e9e1phpvJzxUHw157MwZGGAjYPpFGdcUFG1h4gjTO3l2mubreKnRV PMOQL0Q/qkTML55Y5caqb/vZoFd7u8h/n1dCVCzdluHECFoFrI30zheKpT7j2IRh SDGQcgSlQK7e8J4s/qw1Pq/u0fW94xW7yMANlAI0m2Gmv8T+JnlIxU50qTbFfxET 0YiZHJ/Yuy34959D1kEei1hY7XbqZ0uD2mgX3j69/75cRM0WsQqaZmJmVC3UvNjL WsOw/DT1J4IcWxOXBTv+r30P/Lc2OA+wt3g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1692097854; x=1692184254; bh=QA8A0kB52QbRAIzQhBdJIdLSOjxb67KhRYI fsCURo74=; b=QUpyoCuKOpqWmWoYkTmIzrLzMf0Ev/oRfXe6Zxg9ErPYjUvaK8z KRUA6guUzimwCyALDdHYS2TmQY/P775yW3qNTnvFzYNeqY+129xmSMeu/C4ViKN3 I9gn01n7cqElG6hcdlGs9sXAA7fJuLT9zoaygMkGQ+mKuSd7/di+OUIzoIMnWwIJ hTLdS1+I82IDD10DAzeiDQshr9brm7YR8qrIm2mQJbXSNdN3Q3I9/QhmfryYX4Qu r7EIyezgx1k8gZRuJ0wOcUipHGzz5BEwiYWjkDDrxXHHoSKSnwD+YF3oaHoemjJ0 Mzr9ri2BQNNym2HyZ4uhKSoLmS9V0xKIbyg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddtjedgfeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeeggeffieehledtuefhudelveduhedvfeekvdeuuedvtdduteel ffduhffgieehudenucffohhmrghinhepmhhutghsvgdrtghomhenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 15 Aug 2023 07:10:52 -0400 (EDT) From: Thomas Monjalon To: Wenbo Cao Cc: dev@dpdk.org, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, yaojun@mucse.com Subject: Re: [PATCH v5 1/8] net/rnp: add skeleton Date: Tue, 15 Aug 2023 13:10:50 +0200 Message-ID: <2763426.X9hSmTKtgW@thomas> In-Reply-To: <20230807021615.3663034-2-caowenbo@mucse.com> References: <20230807021615.3663034-1-caowenbo@mucse.com> <20230807021615.3663034-2-caowenbo@mucse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Wenbo Cao: > --- /dev/null > +++ b/doc/guides/nics/rnp.rst > @@ -0,0 +1,43 @@ > +.. SPDX-License-Identifier: BSD-3-Clause > + Copyright(c) 2023 Mucse IC Design Ltd. > + > +RNP Poll Mode driver > +========================== Please keep underlining the same size as the text above. > + > +The RNP ETHDEV PMD (**librte_net_rnp**) provides poll mode ethdev > +driver support for the inbuilt network device found in the **Mucse RNP** > + > +Prerequisites > +------------- > +More information can be found at `Mucse, Official Website > +`_. > + > +Supported RNP SoCs > +------------------------ > + > +- N10 > + > +Driver compilation and testing > +------------------------------ > + > +Refer to the document :ref:`compiling and testing a PMD for a NIC ` > +for details. It was a mistake to originally introduce the anchor "pmd_build_and_test". You should achieve the same result with the shorter syntax :doc:`build_and_test` > + > +#. Running testpmd: > + > + Follow instructions available in the document > + :ref:`compiling and testing a PMD for a NIC ` > + to run testpmd. Do we really need that referencing the same document as above? > + > +Limitations or Known issues > +---------------------------- > +Build with ICC is not supported yet. > +CRC stripping > +~~~~~~~~~~~~~~ > +The RNP SoC family NICs strip the CRC for every packets coming into the > +host interface irrespective of the offload configuration. > +When You Want To Disable CRC_OFFLOAD The Feature Will Influence The RxCksum Offload > +VLAN Strip > +~~~~~~~~~~~ > +For VLAN Strip RNP Just Support CVLAN(0x8100) Type If The Vlan Type Is SVLAN(0X88a8) > +VLAN Filter Or Strip Will Not Effert For This Packet It Will Bypass To The Host. Please check the doc contribution guide. You should add spaces before and after titles.