DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Matthew Hall <mhall@mhcomputing.net>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] difficulty w/ RTE_NEXT_ABI
Date: Sun, 22 Nov 2015 21:59:30 +0100	[thread overview]
Message-ID: <2764108.ZoWOrsZgTX@xps13> (raw)
In-Reply-To: <20151122002518.GA7196@mhcomputing.net>

2015-11-21 19:25, Matthew Hall:
> On Sat, Nov 21, 2015 at 11:44:20AM +0100, Thomas Monjalon wrote:
> > The new mbuf provides packet type instead of flags.
> > So the processing in this function is changed and the variable name is
> > different to reflect this.
> 
> But the data type of the variable is the same, and this is an internal 
> always_inline function.

It is an example application using a mbuf feature which changes depending of
CONFIG_RTE_NEXT_ABI. The ABI is in the mbuf library not in the app.
The header of the app function is changed only for the variable name because
the semantic is changed.

> So again I am confused what advantage we got from RTE_NEXT_ABI here, and how 
> you have multiple copies of RTE_NEXT_ABI on a single symbol when it is a 
> binary variable.

I don't understand what is not clear here.

> This doesn't really answer the bigger question about the reasoning.

Probably because you don't ask clearly your question.
Please check the code and your question again.
Maybe that this reading may help: doc/guides/contributing/versioning.rst

  reply	other threads:[~2015-11-22 21:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-21  8:49 Matthew Hall
2015-11-21 10:44 ` Thomas Monjalon
2015-11-22  0:25   ` Matthew Hall
2015-11-22 20:59     ` Thomas Monjalon [this message]
2015-11-22 23:25       ` Matthew Hall
2015-11-23  0:13         ` Thomas Monjalon
2015-11-23  3:53           ` Matthew Hall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2764108.ZoWOrsZgTX@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=mhall@mhcomputing.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).