From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2376A04DD; Thu, 26 Nov 2020 17:38:06 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8AF79C9FE; Thu, 26 Nov 2020 17:38:05 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 2A8E3C9F0 for ; Thu, 26 Nov 2020 17:38:03 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id C15655C011C; Thu, 26 Nov 2020 11:38:02 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 26 Nov 2020 11:38:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= TNBs4dd9T3q5ts0RSizs6p0m9hVlA/bxhMEf2bTY0Ew=; b=jsmurwcFBVSjW1b4 J3f3+picwl0+NxV9XHdwjrZW9v+hpy9oNuo5uJ3BqE2MH4uPovAn18NDGOSodDvS mR6+FUnC1OqljY8kTyfFf85KdJYZLb+IFgHjwwHsWW8TKfURpaBJWYlkddHY1Eqe OzqPaK9OO3SI6m9s6AjrJmbkO9Qzzi6aU7dTz4cvt8uLasbzmatHZY1w1jYAbQFg OXWWHTn3Zt4OjjCPBiPQNs2vQqyrIRUZdCc6MWZoJBrQTUnpAggTf+wJ4Se9QOIH IhDdtB4c9YqrM60VWPiGT/p2bmr27DKpwnhwQl8AJiMdlRSSnWcIDM95Aov1/FyE oRp7jg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=TNBs4dd9T3q5ts0RSizs6p0m9hVlA/bxhMEf2bTY0 Ew=; b=Kuzk41DxsTEsKFhOd/pph1c8qAuF2Abvjna4Ot2r9HqCWydfbDGkTRhmj VR76Q9lWbGTJ6F5MUmHON05jVtCU6gKXpjvSwJzvNHjO1SAy1Hn4xTj8oaO9reeF Y1jryn88TDxwx+GUB6fHy5SZCmYex2Z+NPd3IXS/seNP5n1SOYSvWoHco6GF8sX9 Zq4IB9Lug+pUBVoye5gjD2Vab9hRaI9DD2FbIl6MEitaw42aMkLxjR9s15GH1ijs Ds+SI3a8LmhIH2IyxqtekP4Ly3KB4hxsHszcvveLcfhJINoIbsDXgIsvn0an13nG sWAZhhTW59HmCnYaPE++R1SX/u9rA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudehvddgleduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 11E183064AA6; Thu, 26 Nov 2020 11:38:00 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, david.marchand@redhat.com, Gregory Etelson Date: Thu, 26 Nov 2020 17:38:00 +0100 Message-ID: <2765877.Fr1KgyXq4T@thomas> In-Reply-To: <20201126162443.GG1340@bricha3-MOBL.ger.corp.intel.com> References: <20201117181746.17904-1-getelson@nvidia.com> <20201126154218.1222717-1-thomas@monjalon.net> <20201126162443.GG1340@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/1] doc: add pkg-config requirement for applications X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/11/2020 17:24, Bruce Richardson: > On Thu, Nov 26, 2020 at 04:42:18PM +0100, Thomas Monjalon wrote: > > From: Gregory Etelson > > > > DPDK relies on pkg-config(1) to provide correct parameters for > > compiler and linker used in application build. Inaccurate build > > parameters, produced by pkg-config from DPDK .pc files could fail > > application build or cause unpredicted results during application > > runtime. > > > > Update system requirements doc about a bug in pkg-config v0.27 > > used in RHEL-7. > > > > Signed-off-by: Gregory Etelson > > Signed-off-by: Thomas Monjalon > > --- > > > > v2: make a more global note about the need for pkg-config in app build > > > > --- > > doc/guides/linux_gsg/sys_reqs.rst | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/doc/guides/linux_gsg/sys_reqs.rst b/doc/guides/linux_gsg/sys_reqs.rst > > index 6ecdc04aa9..ab38284950 100644 > > --- a/doc/guides/linux_gsg/sys_reqs.rst > > +++ b/doc/guides/linux_gsg/sys_reqs.rst > > @@ -94,6 +94,19 @@ found in that driver's documentation in the relevant DPDK guide document, > > e.g. :doc:`../nics/index` > > > > > > +Building DPDK Applications > > +-------------------------- > > + > > +The tool pkg-config or pkgconf, integrated in most build systems, > > +must be used to parse options and dependencies from libdpdk.pc. > > + > > +.. note:: > > + > > + pkg-config 0.27, supplied with RHEL-7, > > + does not process correctly Libs.private section, > > "correctly process the Lib.private..." or "process the Libs.private section > correctly..." would read better, I think. > > > + resulting in misses in statically linked applications. > > "misses" is a strange term to use here, and I think it needs clarification > on what exactly is being missed. How about generalizing it a bit: > "resulting in statically linked applications not being linked properly." I agree, I'll do a v3, thanks.