From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id ABD80374F; Mon, 1 May 2017 15:18:14 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B6B62208ED; Mon, 1 May 2017 09:18:13 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 01 May 2017 09:18:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=RZVb/ezeQPm8f6t o2v4RZiK95RVBPdl+LNsU6s8oI90=; b=E2qM2UnE0pnGlCi3AH/riuJEheNKnC7 rY4QSf7ER0dItjsEJFLFGPrH8VJ/Ah/JOiAdljTwGYF3A0I4pVYVk/Tw2mTlKcJP 59gl/7abHIkI00de5UYQj5hGbKyPCHsaWuLLseXHYTr8qF7h9Up7/u145K5KEpuE dzIHJOiRvWyQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=RZVb/ezeQPm8f6to2v4RZiK95RVBPdl+LNsU6s8oI90=; b=dngprFSN eBJkFQ3HRWxD9LvBLX6s1Kxrx6nzAdh9HzAhBuRx76t5YV4i56Pg25bWDz7VTNpX AWH+feUIHzlE4mZP+EuZa7O1LhjdB5Dx6SdPScbU6PGNY94+Uz8VDE+H4CW8Xam8 ycx+UwNgDHMolsPQ7KgYn1QEStEoiC3KzRc2WX6yRChiqZZiy4dRX2ogYK3qIn8+ mkA0JxVXj5gIM9Voc7YJ+oHPkPv9XLDSnsp72wAKDAeMnNhDys8hvQbZvla3x2jo DFX+uaXjc7DUoUb6gB0IHhCxPCauhR2PWVG8gFBN9hfqHCYi0w63a9ncT/qOHfpU ZcJBURo9KCFqUQ== X-ME-Sender: X-Sasl-enc: 4FsPPD81tdJkhe/Nx9o9N6UKekuZUHrD+PsRYNnIY1Ky 1493644693 Received: from xps.localnet (245.114.118.80.rev.sfr.net [80.118.114.245]) by mail.messagingengine.com (Postfix) with ESMTPA id 528AC7E0A4; Mon, 1 May 2017 09:18:13 -0400 (EDT) From: Thomas Monjalon To: Olivier Matz Cc: stable@dpdk.org, "Wu, Jingjing" , dev@dpdk.org, "Richardson, Bruce" Date: Mon, 01 May 2017 15:18:11 +0200 Message-ID: <2767337.ChMh6S42Js@xps> In-Reply-To: <9BB6961774997848B5B42BEC655768F810D5A14D@SHSMSX103.ccr.corp.intel.com> References: <20170424123358.5959-1-olivier.matz@6wind.com> <9BB6961774997848B5B42BEC655768F810D5A14D@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] app/testpmd: fix crash at mbuf pool creation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 May 2017 13:18:15 -0000 28/04/2017 10:51, Wu, Jingjing: > From: Olivier Matz [mailto:olivier.matz@6wind.com] > > Since > > commit 999b2ee0fe45 ("app/testpmd: enable NUMA support by default"), > > testpmd is started with numa enabled by default. This highlights a floating point > > exception when started with --total-num-mbufs without any port (division by 0). > > This bug was already triggered before this commit if the --no-numa option was > > given. > > > > This commit adds a check of the nb_ports value before doing the division. By > > looking at this code, it appears that the creation of the mbuf pool is not > > consistent for the number of mbufs depending on the configuration. This is fixed > > in the next commit. > > > > Fixes: b6ea6408fbc7 ("ethdev: store numa_node per device") > > > > CC: stable@dpdk.org > > Signed-off-by: Olivier Matz > > Acked-by: Jingjing Wu Series applied, thanks