From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E58C5A0C56; Fri, 5 Nov 2021 19:56:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C88140DFD; Fri, 5 Nov 2021 19:56:59 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id D696940151 for ; Fri, 5 Nov 2021 19:56:56 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10159"; a="255614406" X-IronPort-AV: E=Sophos;i="5.87,212,1631602800"; d="scan'208";a="255614406" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2021 11:56:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,212,1631602800"; d="scan'208";a="562109823" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga004.fm.intel.com with ESMTP; 05 Nov 2021 11:56:34 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 5 Nov 2021 11:56:33 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 5 Nov 2021 11:56:33 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 5 Nov 2021 11:56:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SrFskj1B0TTd07X6RP2zLu9O1FbsSRX2O/uRF2+92KjQCPIW7q7s2QHzYrFf7SK6kPja4Y9RPxC51ug3Vnpz0CzLmuynh+caG+n6hd3ajkyC94XuazXzy0vc1pob0f+We6yQqsVvBpaxHmEKIObu6pzoYXdEn0JS8AhPSafwxAtMSBPE2ySpIRp7qT4yYjq/uMejS2YK0pzaUgTUv4H35kal47ofbh4lSmfkTPCRb/b6BukuIKnmsPKaYKqL9OBdfku1UT7wEHTTtYtjefu5dZgiILaZcx2fCXB5KhLc6vhdb8lfnoagxsen0AzBOXKlooJ+1fJtnHWocO76Yc1eNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V25xdpgLn3FGA9TJCzTC9RdJtkGmcOFexeACdDs2zlc=; b=ZTLZK5RmgTCKVMRovpm3qr1uBRw8GR+eKxBHtNi20GOe9xQwXcW+L7dP6yqvNimBrWjWV26rHRBwzfQLE2isKAjkDoqFgJIoYtYsc1SnGAMz0w9fXw+n5/0QshGrx6Od/FPahNIFxcSyVJnk77yNCrd9yqNK7bGItPyQGS5MzKEKWkyoX4z8aCJX8mRiLA5g+13JR5WWeReSfe90+6w6LTp1rykAP3thUkpz+wmLQ3J7J8H/1EKhABcaa473n1w1shfUdVGRe4qby8Pyv7Gt4qAF4d7F1QHE0Xe+Iqy/10Ddd4zwqoUcVllceHcjWbEgWSEeb6qLvGEwOkjNF7rgfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V25xdpgLn3FGA9TJCzTC9RdJtkGmcOFexeACdDs2zlc=; b=acxuXmVKlDKxNi2k3ULAh7afZBbQIOk3vPHrAuFx+9h7g1qRV6E7taUS21Y7hEBn7GNL6y3ReSlDbIjKApR0uJA2GBKFNS43XvfJ8jIxBAkp9yhWplCikM4/waXhK1RIY6FGRQpOV4vUo1l8+eRX6no0M6rqPSrnTKj5KCtq2n8= Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5079.namprd11.prod.outlook.com (2603:10b6:510:3d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Fri, 5 Nov 2021 18:56:32 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%7]) with mapi id 15.20.4669.011; Fri, 5 Nov 2021 18:56:32 +0000 Message-ID: <276d3bf1-62a6-86e1-c822-2f97677852d2@intel.com> Date: Fri, 5 Nov 2021 18:56:24 +0000 Content-Language: en-US To: Slava Ovsiienko , Gregory Etelson , Ori Kam CC: Matan Azrad , Raslan Darawsheh , Xiaoyun Li , "dev@dpdk.org" References: <20211026152000.11665-1-getelson@nvidia.com> <489cf220-720f-985e-5982-78db17b2845d@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0007.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::19) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by LO2P265CA0007.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11 via Frontend Transport; Fri, 5 Nov 2021 18:56:30 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6a1976a4-857c-49d9-6cc7-08d9a08dfbab X-MS-TrafficTypeDiagnostic: PH0PR11MB5079: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bHFFp00AdATHIFMxQb7J0WKlGgxxc51O01h4B6ifwRHZpHaSlrmP78EAXRicrEiVK5lq25oGGDP5agER156zc371lcpBLJU1tf02tDMgaKNtqo2jYs2jt5DU37G3LP8uj09zp/uutDdiqcvo0i9e+nNcvRndNJvvByPh2uzhavCX1KdtwNy8xNrpfupI74zdJ3KHAKUu3GbimrgaSvENucCMdIAMiuH5k7jRkXDAvo1S+uOq03gKZKyHnxiSa7m3woreEXryfrXdd8kO1J2osOZvJxoj8DxbLKxlO6BZd7cviGBNDkUJs1X5zZ5UiAR5suaDQSCiPBtC7G7XAZ3wrtoQzqdWn/X/tJGSU5pvjoJswLM5odSbRoQAOSki9dmeepdB5Y+Pn63KLFUfG+QxfHELJLAFSblNFjZSYO6rQo+3HmwtEDnQyRg7PQZgPwm8E4uSNJnvQNXnSOQPDoLoGm0V7/UYykbkj6vNGeWyQW6Di90DAN5QRcYpw8+YbQ+3CNpslN6Ac/XihXRSG8F9PlR13krbi21fYYzuXOwSvzujolN8VRrkXnW1hCVLjt4Sg7f/xA6n4V+lPIKk14uwNt2HbjK/A24sO4Zb5YgSvDZsx6pl+r/RrEg4Ext1SwirSUmDxzwQO6IKcE1SYQ4+BxzoPNeXI4ZOv09NwwP1HWcUrFqOIqnOVaZa8i3q8YxNgLJ8cUaymg0L/Ovny3/ySA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(86362001)(54906003)(2616005)(110136005)(66476007)(44832011)(31686004)(2906002)(508600001)(83380400001)(956004)(26005)(4326008)(38100700002)(31696002)(5660300002)(53546011)(8936002)(186003)(6486002)(82960400001)(316002)(66556008)(66946007)(36756003)(6666004)(8676002)(16576012)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NFcxNCtaa1BzN2xvb2hNYkJYclk1dlVnYXIzRzRhdFhtU0RjMEkyQmF0cDJt?= =?utf-8?B?NUJ4MUdwS0lua0grTzdXb2hUYlBZRTNxYTlqcGtITDVNay9OZElnWUZBQXo1?= =?utf-8?B?d1V1Vkhobm5maXc4VGRIRkRaNVUvY01JbEhJdkJMVVVKMXFDa21jb1luSzRz?= =?utf-8?B?MGNJM05UYnZDWTRGTmYvaDlNNWRISUVzVzROTnBTbUMycWVud0diSVA0NStp?= =?utf-8?B?QWMzQkdVOG1haHVrMWUyK1kweUVMWnVOQTRENFEvZ1FINkVVL25la2dZTlhM?= =?utf-8?B?THFvcldoTzdWbFh0V2lLTUlJOFNjWElqL2xDOHBQTzNDaGZReHlWVTA4Ry9V?= =?utf-8?B?UkFuTDFPZlZwUEx6Y0p4eHhUSVJBTTRWVDQ4eEc0eXV1SGxEdU5NT0t4ZWto?= =?utf-8?B?RHhJek00dFlZdHJlOU5uYi9FVGxvaU8rRHgzYjNSMzVQQU9SL0dZWDM4d2JQ?= =?utf-8?B?OGQ1dGF6QWJxOG8yR2YrcHdoOEVqWkRuVFgwN0hZTkxFUE4rM0xiMnJqTmln?= =?utf-8?B?RUJ6RWZ5K2x1VmVOL1RZdjBxL0tFbldEMWV1N010S3I0YUEwZSswSzZ6MUxO?= =?utf-8?B?em92S3dZSituYzlWdGxNZE5BTG8vNWZVRzNKaENIT1dNcnBiS0xoRFNBcVJ3?= =?utf-8?B?NHJCVW1Jd1ZrcktjN1JaZUZNb0tQSnp5bDgzODdxL3ZVK05VVkI3amFEckhR?= =?utf-8?B?YUNQTFRXM00wcCt6SHF1LytCNHJCNStQU0VJdFd1MUxHa3VNVnVteURIcjA0?= =?utf-8?B?Rm0xdHJnYlNCcE8zUE9vRnpnbnJDR1B4ZTFIaUkvYUNObkk1aE0reE14anA0?= =?utf-8?B?dGE4c2d6bTdrOHZRV0E5a1YrVS9Md0k1SDVvay9KTUd2R3BWWWpOdGpEOG5F?= =?utf-8?B?NEtNSFVNQnQ5OU9NVmZjYnRBaXpnTzV6akpzZmp6RXdCSXBScmJsLzJ0UHpU?= =?utf-8?B?ZFpRczBFOW0yVjkwcXhkcExvb2lYbndNNXdFL0ZOVVFYM05BczlCVkVtV0pL?= =?utf-8?B?QmpwZklrdVdCT3JLQll5RnA3azBKNkVmSi9paHpvSGc2WkRkWWFyYXYrN2tQ?= =?utf-8?B?V1hyRUVEa0pBeENCTjg5MXFJTmFGdE5FYnUyT3RFbUVsMDU3TTZsd0s1b2U4?= =?utf-8?B?UUxMN1BzeVo3VldJSEdQYzZEVUxxZ0hEdmIrZ0NzOXd6bDEzVUxYZGl3WG9T?= =?utf-8?B?UExwTzR2d2V0aUZsWmx1RlprNlRlOWZZQXhvWHd3QXJHUERqZWRYRzMzemc4?= =?utf-8?B?a2hFQXFLb1IvOWtZb0RZZ24xbHN0S3MycUh3bVVPQTRnNThOMWUwNDFMd0Zt?= =?utf-8?B?N2R5bzNFWUdLSGM1d2V4d0J2YmlOYk1JOVpvQVpWU28vdWE2V254RlppMGRT?= =?utf-8?B?bE5lQnNvNGdwbWRLcElLZExHR2VWczdKRlQvcm45Mmdrc0VUYjV1bUVVK05m?= =?utf-8?B?TlE3bFFGMzFLRjdoVkZGZ1NTcHRIckdUM0toYkkzZkJ6Y2ttRzdRakZkRXVk?= =?utf-8?B?ZWNWVUh3L0tFVUtTalBXbXF5dTdyQzY4VGVDakpKSUZBYzRiNzBwQWVGYlNC?= =?utf-8?B?UFlNUFk3TndqYjE5L1F0Um1zemxzZ0lsMFA2Vmt5MVl6ZEE5SjVKVTl2eW9P?= =?utf-8?B?RWNwV3NhbEhOTUFtWTVPamk4WVp5R2hvR2Y5RERjL1p2TjFHOS9SYk5aT3FC?= =?utf-8?B?WlFIUTl0dk9QSTR6a21aVGhZZFdQR0I1TWZycGZWY1J5cHlWc0RTU0tZMGtz?= =?utf-8?B?TFBMNzk0cnZZL2hGanJIUlgwWHA4bGtTOFA2QTFiK0JHczdRT2t5QjZTNWc5?= =?utf-8?B?dWUvMGN1TDFEUnp5V2pqSy9yNHlTNmJoQ1BNbXBTbGNwdzUzUDNpQ2JXOUpQ?= =?utf-8?B?YmtwMFdkN3U5WFlSOXAvL0oyanRXK2xJWndvUnpMSHdlMmd3ZnVLbHljdUor?= =?utf-8?B?QWQrN0tkVE5pOUo2Rm85UmR4aWpPdFlhSFkyUnJaZlFoektBVGVjekpHdVJC?= =?utf-8?B?MHdTZ252VUE3aDB5M0wvSnBBOVh0R0lnK0VBMnRBRTBmUThQM3RobWppRzBu?= =?utf-8?B?U3lHdjNLaU9KVitlKzNTTDNvRlliUEswMHhmZWg1YkZhNHRjeGtVR2lpTllJ?= =?utf-8?B?d3VlbHpJME5heW5obDhUaFgxMEpVZ29DN3M2M1BYQWlCYWljWGVmeStVeUtr?= =?utf-8?Q?+Nl/C8/4mvF4yn7tloieyOU=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6a1976a4-857c-49d9-6cc7-08d9a08dfbab X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2021 18:56:32.5612 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QY+GxWh1rq1WDA6xW53252R70gXBy4ewEotT3Yw+PYiyRDocsslHcv348oT68V58aD3T8+FjBAqXteIBmdOZgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5079 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix flex item flush X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/5/2021 5:03 PM, Slava Ovsiienko wrote: >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Friday, November 5, 2021 17:57 >> To: Gregory Etelson ; Slava Ovsiienko >> ; Ori Kam >> Cc: Matan Azrad ; Raslan Darawsheh >> ; Xiaoyun Li ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix flex item flush >> >> On 10/26/2021 4:20 PM, Gregory Etelson wrote: >>> Testpmd provides 2 sets of flex item create and destroy functions One >>> for hosts with JSON library. These functions parse flex item >>> configuration stored in JSON file and create or destroy flex item >>> object. The second functions set is for hosts without JSON library for >>> compilation compatibility. >>> >>> On hosts without JSON library, current implementation issues "no JSON >>> library" notification on port close. >>> The notification was triggered by port destructors that include flex >>> items flush routine. >>> >>> The patch introduces single implementation for testpmd flex item >>> destroy. >>> >>> Fixes: 59f3a8acbcdb ("app/testpmd: add flex item commands") >>> Signed-off-by: Gregory Etelson >> >> Hi Viacheslav, Ori, >> >> Can you please help on reviewing this patch? > Reviewed-by: Viacheslav Ovsiienko > > I've already reviewed this one internally, so just posting the confirmation. > As for maintainership of cmd_flex_item.c - we talked with Ori, he don't > mind if I would take the responsibility for this. What should we do for that? Send patch > to update MAINTAINERS ? > Great, thanks. Yes a maintainers file update is required.