From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, alejandro.lucero@netronome.com
Subject: Re: [dpdk-dev] [PATCH] mem: fix use after free in legacy mem init
Date: Wed, 07 Nov 2018 00:08:18 +0100 [thread overview]
Message-ID: <2772758.S30zqRuoYT@xps> (raw)
In-Reply-To: <e6f96c0a1a26b2c73e19ef6f9be55a12f87f190e.1541513401.git.anatoly.burakov@intel.com>
06/11/2018 15:13, Anatoly Burakov:
> Adding an additional failure path in DMA mask check has exposed an
> issue where `hugepage` pointer may point to memory that has already
> been unmapped, but pointer value is still not NULL, so failure
> handler will attempt to unmap it second time if DMA mask check
> fails. Fix it by setting `hugepage` pointer to NULL once it is no
> longer needed.
>
> Coverity ID: 325730
>
> Fixes: 165c89b84538 ("mem: use DMA mask check for legacy memory")
> Cc: alejandro.lucero@netronome.com
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
prev parent reply other threads:[~2018-11-06 23:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 14:13 Anatoly Burakov
2018-11-06 23:08 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2772758.S30zqRuoYT@xps \
--to=thomas@monjalon.net \
--cc=alejandro.lucero@netronome.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).