From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 6BC512BC7
 for <dev@dpdk.org>; Tue,  2 Oct 2018 12:41:21 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 9F7AA21FB6;
 Tue,  2 Oct 2018 06:41:20 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Tue, 02 Oct 2018 06:41:20 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=I2wsGu/i/wbEYYnFNAued/8lH1
 UpaWdsSTyoAQxDYN8=; b=WPgHw9RxBMy41Z+kkGy3nmT8jDF8k0+7HpsmufuRd7
 AU0YzxM8cra+QnA319BQS3bqHqYf3Z8nQTMHgSUzrdeErBO097zYKxjNLUbD7kOj
 xP6TzNKV2IUANoCGFzAiGM1wW04TgEpgRh8rtn0qlJQIGjuWOs7PSAr23Q5HTppo
 8=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=I2wsGu
 /i/wbEYYnFNAued/8lH1UpaWdsSTyoAQxDYN8=; b=FelS92xAIrS7RX0amsT3Gr
 Q8R86FXnybs8boCZMGhYGpaiv0sfEdsUrjt3hkCFzIQjaYkiD5OHhNxFQ4VCuKQz
 LW+YKZN+kZMPsHSeMF3HSN8EcR0CV2C5fjGmMazAnjrrpeH1joT8fR5lzouaWkiE
 Tx8QUMf9AkYicd9V9srJFCGlH0L5xsZU4WXbYVwI2C0CC8/JG5uFN9EAN/YPnf77
 qwIpoU6z9Zqw6VPQ+h89BppOnkD4zVGS31G9T7SMm2cy40UrRDf5Gmn5PD4081YS
 AJr9MwAqc5kJIufsef3ZPSYGIiVjFBPuC59/9mhXlysotgxv2vGE9fHQWxo+2Tsw
 ==
X-ME-Sender: <xms:UEuzW9I_8DDOXpDBI0fjF7qU3dFYV6zZfWlM6KkUCVB5synmPozvlQ>
X-ME-Proxy: <xmx:UEuzW-AGGJdsvhj5B6SsuJN87SP4XSWzIyUqG8JdXSF7EsJ8AD4XZQ>
 <xmx:UEuzW9n76W50bOptoIVZlAsV15sARVbIukkfUaNjuP8iO0eta5zUpA>
 <xmx:UEuzW-l2F7cKBzD6Hb3AfFx3oQI-VqqR6j4Nec7ZRIIYAm9Z76OdsQ>
 <xmx:UEuzW6eYzSvaUf1utcpcsngwgYU2BrzYqpHl5suS5SCzSPU6guY4Vg>
 <xmx:UEuzW0ygNKXazzRl5ZwjmcUZvz5Gh7LUrTxR5kT7XYu39Uue0Ln6Ow>
 <xmx:UEuzW9jt3qye-PaRiL0pvKX2qD78TIe0DC5kWLolnogDd9QCFvr9Kw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 3A928102DB;
 Tue,  2 Oct 2018 06:41:19 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Raslan Darawsheh <rasland@mellanox.com>
Cc: dev@dpdk.org, "keith.wiles@intel.com" <keith.wiles@intel.com>,
 Shahaf Shuler <shahafs@mellanox.com>, Ori Kam <orika@mellanox.com>
Date: Tue, 02 Oct 2018 12:41:18 +0200
Message-ID: <2772955.aHLSG1IVkg@xps>
In-Reply-To: <1538476438-20891-2-git-send-email-rasland@mellanox.com>
References: <1538047196-13789-2-git-send-email-rasland@mellanox.com>
 <1538476438-20891-1-git-send-email-rasland@mellanox.com>
 <1538476438-20891-2-git-send-email-rasland@mellanox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v4 2/2] net/tap: add queues when attaching
	from secondary process
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Oct 2018 10:41:21 -0000

02/10/2018 12:34, Raslan Darawsheh:
> @@ -2056,6 +2179,13 @@ rte_pmd_tap_probe(struct rte_vdev_device *dev)
>         TAP_LOG(NOTICE, "Initializing pmd_tap for %s as %s",
>                 name, tap_name);
>  
> +       /* Register IPC feed callback */
> +       ret = rte_mp_action_register(TAP_MP_KEY, tap_mp_sync_queues);
> +       if (ret < 0 && rte_errno != EEXIST) {
> +               TAP_LOG(ERR, "%s: Failed to register IPC callback: %s",
> +                       tuntap_name, strerror(rte_errno));
> +               goto leave;
> +       }
>         ret = eth_dev_tap_create(dev, tap_name, remote_iface, &user_mac,
>                 ETH_TUNTAP_TYPE_TAP);

Is it an issue registering tap_mp_sync_queues at each tap probing?
Should we do it only once?