From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C39BA046B for ; Fri, 28 Jun 2019 10:40:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3AA811B4B6; Fri, 28 Jun 2019 10:40:23 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 3310E58C4; Fri, 28 Jun 2019 10:40:21 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 49D3E3453; Fri, 28 Jun 2019 04:40:20 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 28 Jun 2019 04:40:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=BToe5PGS1Aqcf26b0bvniWl1gH6OXhQStjbmWN5pnNo=; b=i11c4w86n2YY gcllfdvLUkyWjxzQJ/+VxeVnrWWQSFrfgYCtccgc+j81MptWNrpyWvY5nSvKdllm Hcud9bV2x1JGMqwdxgoMJGZgy7+BrfrsgVahwF6OyvqOM/jt8wf+t1Lc4GGubWCn Ihc7b0bSYc+0npE88ocMBFi1AMM2E08= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=BToe5PGS1Aqcf26b0bvniWl1gH6OXhQStjbmWN5pn No=; b=s2nqHrJ7WhLkK++6E/mDQA6pMKMgs86w6XynJz7CTUVXYJ9iTfy3+Yj6+ lPu9SzpsTUPspf36soiIXUjzLvtDF0ElEP9r8e+cvLxe4fto6kPcZEHoGVyYtJ5X 9hoh758WAgg1pPMa40n7J5xQicnIJVSqH5RPxKlmOPhc0/MmOQtqbpjiyjIyaZAc B0Az3gm3umFvlwuKudMGFvBeX05GmzhNteQ/TYsFmijsBFsC9mD6vrL7lgLmg8dO FVWaLVLvI6R3Pr6cPZUu7TROuA/fqGo7ilKBjQkKgbwbInJqcD08vkuHoqYt845S B/Eze5bqTAm/ZWnbU9CQJGQpWMYhQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrvddtgddtkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3FD928005C; Fri, 28 Jun 2019 04:40:17 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Kollanukkaran , Anoob Joseph Cc: dev@dpdk.org, Mattias =?ISO-8859-1?Q?R=F6nnblom?= , Nikhil Rao , Erik Gabriel Carrillo , Abhinandan Gujjar , Bruce Richardson , Pablo de Lara , Narayana Prasad Raju Athreya , Lukas Bartosik , Pavan Nikhilesh Bhagavatula , Hemant Agrawal , Nipun Gupta , Harry van Haaren , Liang Ma , "techboard@dpdk.org" Date: Fri, 28 Jun 2019 10:40:15 +0200 Message-ID: <2775383.qy1u6QUkDx@xps> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 00/39] adding eventmode helper library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/06/2019 05:37, Jerin Jacob Kollanukkaran: > From: Anoob Joseph > > From: Jerin Jacob Kollanukkaran > > > From: Anoob Joseph > > > > The helper library will be experimental while we add event-mode > > > > support for other applications like l3fwd & ipsec-secgw. I expect > > > > the helper library to be complete over the course of those > > > > applications also using the helper library. You are doing a copy of l2fwd example to add event mode. It was the decision from the techboard to not complicate the original l2fwd. But it makes me nervous to see some code duplicated, especially if you plan to do the same for l3fwd and ipsec-secgw. We are not going to duplicate every examples. We should re-consider. > > > I have only concern about moving this as library inside eventdev that > > > till we have mature version of helper library the eventdev library ABI > > > will not stable(i.e .so file version needs to be incremented as when a > > > change needed). Which align with Mattias thoughts for some other > > > reason:. How about moving this code to > > > 1) example/common or > > > 2) to specific application itself, once at least two applications > > > starts using it then move to Eventdev library. > > > > > > Thoughts? > > > > [Anoob] Either location is not a problem if there is a consensus. Earlier the > > suggestion was to move it to library (when the patch was submitted with > > changes added in app). If there is only one user, making it grow in the application looks to be the best thing to do. Should we use it in more applications before it is more mature? If not, we could move the code in eventdev library when we will use it in more examples. > If there NO objections then lets move to example/common. If we really want to have this library standalone in examples, I suggest to give it a name and not use a "common" directory.