From: Thomas Monjalon <thomas@monjalon.net>
To: "Pattan, Reshma" <reshma.pattan@intel.com>
Cc: "Parthasarathy, JananeeX M" <jananeex.m.parthasarathy@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
"Jain, Deepak K" <deepak.k.jain@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] app/test: enhance sanity script
Date: Mon, 14 May 2018 17:29:41 +0200 [thread overview]
Message-ID: <27756474.fd2W5nfMBH@xps> (raw)
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A2F0B5C@irsmsx110.ger.corp.intel.com>
14/05/2018 17:26, Pattan, Reshma:
> Hi Thomas,
>
> > > 2. Fixed in autotest_test_funcs.py to handle test cases which returns
> > > "Skipped" as result.
> > > The issue was skipped test cases got timed out, causing delay in
> > > sanity script execution.
> > > 3. Enhanced support for FreeBSD,
> > > as FreeBSD doesn't support socket-mem, file-prefix options.
> >
> > Please do 3 patches.
>
> Why do we need 3 patches here? Any reason?
Because it's easier to review and better for the history to have
patches with only one goal.
It is a basic rule: one fix = one patch.
It is also easier to backport.
next prev parent reply other threads:[~2018-05-14 15:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 13:20 [dpdk-dev] [PATCH] " Reshma Pattan
2018-04-27 13:41 ` Burakov, Anatoly
2018-04-27 13:56 ` Burakov, Anatoly
2018-05-03 10:03 ` Parthasarathy, JananeeX M
2018-05-03 10:54 ` Burakov, Anatoly
2018-05-10 10:36 ` [dpdk-dev] [PATCH v2] " Jananee Parthasarathy
2018-05-13 22:12 ` Thomas Monjalon
2018-05-14 15:26 ` Pattan, Reshma
2018-05-14 15:29 ` Thomas Monjalon [this message]
2018-05-15 16:14 ` Parthasarathy, JananeeX M
2018-05-15 16:17 ` Thomas Monjalon
2018-05-18 13:32 ` Parthasarathy, JananeeX M
2018-05-18 13:48 ` Thomas Monjalon
2018-05-20 17:41 ` Parthasarathy, JananeeX M
2018-05-20 19:21 ` Thomas Monjalon
2018-05-15 15:58 ` [dpdk-dev] [PATCH v3 0/3] enhance sanity scripts Jananee Parthasarathy
2018-05-15 15:58 ` [dpdk-dev] [PATCH v3 1/3] app/test: add new test cases to sanity script Jananee Parthasarathy
2018-05-15 16:12 ` Burakov, Anatoly
2018-05-15 15:58 ` [dpdk-dev] [PATCH v3 2/3] app/test: update result for skipped test cases Jananee Parthasarathy
2018-05-15 15:58 ` [dpdk-dev] [PATCH v3 3/3] app/test: enhance freebsd support in sanity script Jananee Parthasarathy
2018-05-23 11:41 ` [dpdk-dev] [PATCH v4 0/4] enhance autotest config and test targets Jananee Parthasarathy
2018-05-23 11:41 ` [dpdk-dev] [PATCH v4 1/4] app/test: enhance autotest config Jananee Parthasarathy
2018-05-23 11:41 ` [dpdk-dev] [PATCH v4 2/4] app/test: update result for skipped test cases Jananee Parthasarathy
2018-05-23 11:41 ` [dpdk-dev] [PATCH v4 3/4] app/test: enhance freebsd support in autotest config Jananee Parthasarathy
2018-05-23 11:41 ` [dpdk-dev] [PATCH v4 4/4] mk: update make targets for classified testcases Jananee Parthasarathy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27756474.fd2W5nfMBH@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).