From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f180.google.com (mail-wj0-f180.google.com [209.85.210.180]) by dpdk.org (Postfix) with ESMTP id 19ECF2C36 for ; Thu, 5 Jan 2017 14:44:58 +0100 (CET) Received: by mail-wj0-f180.google.com with SMTP id tn15so35407799wjb.1 for ; Thu, 05 Jan 2017 05:44:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=+7kNvvQ6xYkFOwmIgGAjIOcdMQTxP5V9v7R0Gt+UvFM=; b=RmW2R4tzMkLlMnTjONA7uyQgT/K/87oHWADCtz1kn/t5PnV0bRJ1S59ugAAKJSI86W 5gE64MNSX041q1k5H8WDxPYNNs9jASY9yfyob0WMqSE9B7mSGI/ipRNYcOLsjlqMhnPn k+1zaK/f5gHxKlDzISIXwE0hy4znXIdkbNsQ68xl/4idlqKZBUxWfF+rhfg0GmFi1rok YqK1+gzrBiNafhuo1/WzDOYe5Ox8fd5OQqBFhJOfief4IoS3Oxip0rTRm4C3IFCQsDfw AL6sPKrcScPeq8ZYKXRyo9gbdfa9/B56H2UpgSZhXKTINNaG7S9+eV8uTc3WLMbg6q8P 0qyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=+7kNvvQ6xYkFOwmIgGAjIOcdMQTxP5V9v7R0Gt+UvFM=; b=SRwzGVfq6xavIoqHsLjFc8ZnBY6mk6+QqsmSKWGZn/EodavwuJKugUcLHoyfU89o/U ijlGuXa79zjoUDX9QG31hXyvz701YiRzkq6RF1V9Y5QO3u4giSqt3hX33Kmn8uDp8E+l PCZniLGL9rY7+rabJaa3IpRNOlgQiIeiGU5N49BF8CaGi+IBBn3qErch2+wxt2yHYeR0 ZYnbuptwhDt5r/kLjG9MwQnrhrn+ZjdxeqQmRdUzTpLpdg3BJ7tJx1KAcI923zHbDNm5 CtCBWjOZJ/PCb6F+DB2hc0SlfeNoT/zLkjHtPepWd+/rx+ch6u6w2RxVKEoCu0mQ7SPi mu4Q== X-Gm-Message-State: AIkVDXLtmaD6T9J2yKnqI9qUuOH2CrV7/huNhqow4ZJDFFMoulL0a9u9R4xOikOFIzL+JKeB X-Received: by 10.194.93.104 with SMTP id ct8mr73427365wjb.87.1483623897826; Thu, 05 Jan 2017 05:44:57 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id w79sm100315349wmw.0.2017.01.05.05.44.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Jan 2017 05:44:57 -0800 (PST) From: Thomas Monjalon To: Qiming Yang Cc: dev@dpdk.org, ferruh.yigit@intel.com, helin.zhang@intel.com, remy.horton@intel.com Date: Thu, 05 Jan 2017 14:44:56 +0100 Message-ID: <2775891.n5HL0JQtYk@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1483531428-14481-2-git-send-email-qiming.yang@intel.com> References: <1482841816-54143-1-git-send-email-qiming.yang@intel.com> <1483531428-14481-1-git-send-email-qiming.yang@intel.com> <1483531428-14481-2-git-send-email-qiming.yang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 1/5] ethdev: add firmware version get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jan 2017 13:44:58 -0000 2017-01-04 20:03, Qiming Yang: > This patch adds a new API 'rte_eth_dev_fw_version_get' for > fetching firmware version related information by a given device. [...] > /** > + * Retrieve the firmware version of a device. > + * > + * @param port_id > + * The port identifier of the device. > + * @param fw_major > + * A pointer to store the major firmware version of a device. > + * @param fw_minor > + * A pointer to store the minor firmware version of a device. > + * @param fw_patch > + * A pointer to store the firmware patch number of a device. > + * @param etrack_id > + * A pointer to store the nvm version of a device. > + */ > +void rte_eth_dev_fw_version_get(uint8_t port_id, uint32_t *fw_major, > + uint32_t *fw_minor, uint32_t *fw_patch, uint32_t *etrack_id); After reading few comments, I think it should just fill a string. There is no way the firmware version can be generalized or standardized. If the application wants to do some processing like number comparisons, it has to be aware of the specific firmware version string format. If you want to help the application to parse this string, it should be a PMD specific API.