From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 062682142 for ; Fri, 10 Jun 2016 17:14:22 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id n184so271021044wmn.1 for ; Fri, 10 Jun 2016 08:14:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=5n6+BQuoUXSciuBqIfjh/pkxpXLJ8ClyH5nBiqoi/z8=; b=rBEGuYYHHcIPB7vVdG53Ufbc0TU3qniNYx2u1I0yu3OtvYOZ7j+V2w+dZmQ0WzrQsq nm+RktEUIFu5Y3H/xaDNO3eaMqRDFJm87YiELcESXGSBJuX7J6ZUmqMye0fFT1fkYgP8 DNBklRr9nVkDXfMAaqumTzEXOfqfGIO4SeGeJk0f2vQQ6h0uA9rd3L2jDJNsY0Omt4uT G93it+RtNcjYtM8YToGZm2uqJdsorcxywNdw3MG2PpjmWt3CYgDhE/FuyDyXHJcz16ls QyBBITTJ63AYs35apaYQdYW9uVXI8LRQ7IMjNJFpPQ9kg++E9hFCmfK5w/N9mkmF9mhT cJtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=5n6+BQuoUXSciuBqIfjh/pkxpXLJ8ClyH5nBiqoi/z8=; b=bFUyZ8k4a15sypYN9iOFkUahbnxkU6wFHQEQ59ZoVi6GFhsVwNulAYKVbVxe68psgy nkIrsdSUd2UPNyqvUWD/VDVyOFzTohzMRQiU1XNTNBy2Ul14Uug0gsatfV2tnM4dhHXx TvkcfspG0TkoJyaqy99yxHOxzw7Rs8UzAdlv12H5ntGc47IDKWqZOnGiQXsFaVf85+37 OU5zl5jwpoJEfQgH3eBLTJweCukmPVp6PXRtw18UimfzT90FBgwqBMSQS6VVyiuUrubc KdCc5iVOoPNqTuOi28nMtiHYYAI8l7w0vDHHzrZRMc0Qy/DhyqSn9bD7Si5cJpSB1Dbi sQJg== X-Gm-Message-State: ALyK8tJ8AL3pVpkLUY99vtjFMHtwbRp+rMCp5u4qhg0FPUIyh2C3GGFMIQ7MAlT/KBcP8m1N X-Received: by 10.28.169.66 with SMTP id s63mr14416221wme.87.1465571661720; Fri, 10 Jun 2016 08:14:21 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id ib10sm8567603wjb.31.2016.06.10.08.14.20 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 10 Jun 2016 08:14:20 -0700 (PDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org Date: Fri, 10 Jun 2016 17:14:19 +0200 Message-ID: <2776716.9PsBryk3kK@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <575AD4A2.9070108@intel.com> References: <1464367686-3475-1-git-send-email-ferruh.yigit@intel.com> <1465564749-1405-4-git-send-email-thomas.monjalon@6wind.com> <575AD4A2.9070108@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 3/6] mk: remove library grouping during application linking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jun 2016 15:14:22 -0000 2016-06-10 15:54, Ferruh Yigit: > On 6/10/2016 2:19 PM, Thomas Monjalon wrote: > > From "man ld": > > Using this option has a significant performance cost. > > It is best to use it only when there are unavoidable > > circular references between two or more archives. > > > > Remove the option since it does not seem necessary. > > > > Signed-off-by: Thomas Monjalon > > To remove this, I think we should order libraries in a way: > > pmd -> librte -> external libraries. > Than we can remove --whole-archive too. > > And perhaps keep it still to wrap around librte_eal and librte_mempool, > which still has cyclic dependencies. OK looks good I let you do a v3