From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: david.marchand@redhat.com, ferruh.yigit@intel.com,
bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] eal: reword logs for CPU and NUMA counts
Date: Thu, 16 Sep 2021 12:39:20 +0200 [thread overview]
Message-ID: <2777321.BUEC3fTb5M@thomas> (raw)
In-Reply-To: <20210916103209.3710442-1-thomas@monjalon.net>
16/09/2021 12:32, Thomas Monjalon:
> Some logs about cores and nodes were using hypotetic plural (s) form.
> A fixed plural form with value at the end is preferred.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> v2: keep plural form as suggested by Bruce
> ---
> lib/eal/common/eal_common_lcore.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/lib/eal/common/eal_common_lcore.c b/lib/eal/common/eal_common_lcore.c
> index 66d6bad1a7..b38bb46d44 100644
> --- a/lib/eal/common/eal_common_lcore.c
> +++ b/lib/eal/common/eal_common_lcore.c
> @@ -191,9 +191,9 @@ rte_eal_cpu_init(void)
> /* Set the count of enabled logical cores of the EAL configuration */
> config->lcore_count = count;
> RTE_LOG(DEBUG, EAL,
> - "Support maximum %u logical core(s) by configuration.\n",
> - RTE_MAX_LCORE);
> - RTE_LOG(INFO, EAL, "Detected %u lcore(s)\n", config->lcore_count);
> + "Maximum logical cores by configuration: %u\n",
> + RTE_MAX_LCORE);
> + RTE_LOG(INFO, EAL, "Detected CPU lcores: %u\n",config->lcore_count);
space missing above, consider it as fixed ;)
>
> /* sort all socket id's in ascending order */
> qsort(lcore_to_socket_id, RTE_DIM(lcore_to_socket_id),
> @@ -208,7 +208,7 @@ rte_eal_cpu_init(void)
> socket_id;
> prev_socket_id = socket_id;
> }
> - RTE_LOG(INFO, EAL, "Detected %u NUMA nodes\n", config->numa_node_count);
> + RTE_LOG(INFO, EAL, "Detected NUMA nodes: %u\n", config->numa_node_count);
>
> return 0;
> }
>
next prev parent reply other threads:[~2021-09-16 10:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 14:32 [dpdk-dev] [PATCH] eal: remove plural syntax for single resource Thomas Monjalon
2021-09-15 14:52 ` Bruce Richardson
2021-09-16 10:32 ` [dpdk-dev] [PATCH v2] eal: reword logs for CPU and NUMA counts Thomas Monjalon
2021-09-16 10:39 ` Thomas Monjalon [this message]
2021-09-16 10:41 ` Bruce Richardson
2021-09-23 6:51 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2777321.BUEC3fTb5M@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).