From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 43938558C for ; Tue, 22 Mar 2016 23:07:35 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id l68so455707wml.1 for ; Tue, 22 Mar 2016 15:07:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=vmeDya7+4Shy8DaJPldhhz6+GwVXK4/3pDb76Ikl7nw=; b=zYFYW7YPLF7TfBQhIiyh8MwFJrTEbxWT/9Eg1LGTqDiQVmJP8z5UgH7V81mJ2hWv0L DeTmHCNv81L68GJwgqOuOL3/IqxKxkN7OacmEnhLsDI0waaMV8eyCTPx5N7WMuoJXjXL DPAgIuGztuaeH3UN7DBt3wlw3bf3E2Zg4+UrMk2J04O8IoE/njY9UNszcc1fKZGTj5wc +omW9TUTz/d3yKaAA9G8Y1SENCfRvGsmq43ajCouJRuWi5AVY/RnSmG1w7f57d7Wvajl tRRtBxAsNz02nqTvNY8K4EEUVmOAkscea44/B6w/ulxelGmPRJNzD/9ZlsjtNi2fFo3d oh9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=vmeDya7+4Shy8DaJPldhhz6+GwVXK4/3pDb76Ikl7nw=; b=CcvVtPfyzaA0b8Le2/0/uE3hJZ2zQNi0FcMK5JC2KX1h/92Eyj27pfNpwFlXal5soM FztgaxeInn74fD2rYVMUT2jo1WgmfLJ2YU/kb1CSLQ6MSTnKmKUyyDIOilhMdjnFj/MQ W0/JvD6+XglEVSyDjar0cjAgw2ZHZUK0+sRwyfFmuzfUKtTmV+cQ1rlzW+VlGb0LMZ4z IWwrwoYGYf7flehp9hqq3XGsMc3jBHVNSQo7en0j5XlmV3wdeMfQYjVMsFGfyUvPbx9U 11VR/JPsTroq47burC17i+KpnDjlKachj5T8jx0FCre1SU+0VlkuWzUXRYy2aCGXWPU8 hEUg== X-Gm-Message-State: AD7BkJI56nDY0rF/7CtBBBU+pCgZ2DI0qpoKNeobCWuDy8OWq+vjiVBbGovzfr1znF/OPNol X-Received: by 10.194.71.177 with SMTP id w17mr44091000wju.36.1458684454996; Tue, 22 Mar 2016 15:07:34 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id v82sm19225192wmv.6.2016.03.22.15.07.34 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 22 Mar 2016 15:07:34 -0700 (PDT) From: Thomas Monjalon To: Jingjing Wu Cc: dev@dpdk.org, helin.zhang@intel.com Date: Tue, 22 Mar 2016 23:05:54 +0100 Message-ID: <2777481.Ou9arTG791@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1458541132-11953-2-git-send-email-jingjing.wu@intel.com> References: <1457580346-18550-1-git-send-email-jingjing.wu@intel.com> <1458541132-11953-1-git-send-email-jingjing.wu@intel.com> <1458541132-11953-2-git-send-email-jingjing.wu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 1/9] ethdev: extend flow director for input selection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2016 22:07:35 -0000 2016-03-21 14:18, Jingjing Wu: > This patch added RTE_ETH_INPUT_SET_L3_IP4_TTL, > RTE_ETH_INPUT_SET_L3_IP6_HOP_LIMITS input field type and extended > struct rte_eth_ipv4_flow and rte_eth_ipv6_flow to support filtering > by tos, protocol and ttl. [...] > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -22,10 +22,6 @@ Deprecation Notices > * The ethdev structures rte_eth_link, rte_eth_dev_info and rte_eth_conf > must be updated to support 100G link and to have a cleaner link speed API. > > -* ABI changes are planned for struct rte_eth_fdir_flow in order to support > - extend flow director's input set. The release 2.2 does not contain these ABI > - changes, but release 2.3 will, and no backwards compatibility is planned. The changed structures are part of rte_eth_fdir_flow. So this deprecation notice apply to this patch. > * ABI changes are planned for rte_eth_ipv4_flow and rte_eth_ipv6_flow to > include more fields to be matched against. The release 2.2 does not > contain these ABI changes, but release 2.3 will. These are the structures changed in this patch. I think this section must be also removed. > --- a/doc/guides/rel_notes/release_16_04.rst > +++ b/doc/guides/rel_notes/release_16_04.rst > @@ -435,6 +435,8 @@ ABI Changes > > * The cmdline buffer size has been increase from 256 to 512. > > +* The ethdev flow director structure ``rte_eth_fdir_flow`` structure was > + changed. New fields were added to extend flow director's input set. For reading ease, it's better to group ethdev changes (before cmdline change). > --- a/lib/librte_ether/rte_eth_ctrl.h > +++ b/lib/librte_ether/rte_eth_ctrl.h > @@ -343,6 +343,8 @@ enum rte_eth_input_set_field { > RTE_ETH_INPUT_SET_L3_IP4_PROTO, > RTE_ETH_INPUT_SET_L3_IP6_TC, > RTE_ETH_INPUT_SET_L3_IP6_NEXT_HEADER, > + RTE_ETH_INPUT_SET_L3_IP4_TTL, > + RTE_ETH_INPUT_SET_L3_IP6_HOP_LIMITS, > > /* L4 */ > RTE_ETH_INPUT_SET_L4_UDP_SRC_PORT = 257, > @@ -410,6 +412,9 @@ struct rte_eth_l2_flow { > struct rte_eth_ipv4_flow { > uint32_t src_ip; /**< IPv4 source address to match. */ > uint32_t dst_ip; /**< IPv4 destination address to match. */ > + uint8_t tos; /**< Type of service to match. */ > + uint8_t ttl; /**< Time to live to match. */ > + uint8_t proto; /**< Protocol, next header to match. */ > }; > > /** > @@ -446,6 +451,9 @@ struct rte_eth_sctpv4_flow { > struct rte_eth_ipv6_flow { > uint32_t src_ip[4]; /**< IPv6 source address to match. */ > uint32_t dst_ip[4]; /**< IPv6 destination address to match. */ > + uint8_t tc; /**< Traffic class to match. */ > + uint8_t proto; /**< Protocol, next header to match. */ > + uint8_t hop_limits; /**< Hop limits to match. */ > }; This extension of the existing API looks OK.