From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16E05A054F; Tue, 16 Mar 2021 10:16:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CAA7C2428A0; Tue, 16 Mar 2021 10:16:33 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 05B5740F35 for ; Tue, 16 Mar 2021 10:16:33 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 589AF5C0106; Tue, 16 Mar 2021 05:16:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 16 Mar 2021 05:16:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= 00PWhp/0CscAQ/Okp0kQtxevJ8WV2Hx4W3pSNj7qx48=; b=bLK9V9Js1FGYbKn5 9eMDYgV6/HDQzXPjmKG1A/5QN3jfBphV0cMW/1jqNsiMu7zvM9ggDFdvrZ0MWQlT /Ii3ska+MQ1ZHKnEx4M58EbBGUIPhv74wT7PFaHaoPgt83pu1XwTU6XtdZbDxHGy 38V+hR0Tr2Geo0aw7VrCGu6RQ2w21J/yXh4SKavINI+ZEbUnl2L8bFDqSNfzHcMK jVT9om4irsttMNxaa6aNTs3rQqxqQucySit5TsNocUmiEONbQ/aZTpQEV797+ykS O8xqw+T592WaPkp0d+YpfaeEaHoO+DEW9KLAQpPlYKt+hFlp4wp2rqavK1cSuaGD XjhB7g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=00PWhp/0CscAQ/Okp0kQtxevJ8WV2Hx4W3pSNj7qx 48=; b=B/P26wfM8f0O3AoJnplFqmFJAax2Y5zyreJ8Bt78rtnllcInTrim+H/7c FZv9AAd/Ww0kuKbymFDHLFxEHpI08R1TUHhm5C5n5OXK+xAcJWHTiRbOm4n0T65v fq94+Zwswqq/ZkIQYFx/LjhpU9yLw8CHvnRWwqBwO3svCoarLhhHTFPPVFNVOhRb SLPSuCoE/GBk2ocsNE0yCswr1KZWgQJVyMnVULNzPKOIz0u70jtNiX8yXGOCFpgh qBHixpYqK6S3vmfn5d6cP3zdgNYNZZT8aXH4u+kHIOwtnbf5MWbgKexQUkHGJlaW oCi/r8cI628UBXT7UMk1p1nm3/tYA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudefvdcutefuodetggdotefrodftvfcurf hrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfo ohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtffrrg htthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueeiiedv ffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdr nhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B02EE1080063; Tue, 16 Mar 2021 05:16:30 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: Bruce Richardson , dev@dpdk.org, Ferruh Yigit , Tyler Retzlaff , Mike Wells Date: Tue, 16 Mar 2021 10:16:28 +0100 Message-ID: <2777528.d7l0ZQ1OWI@thomas> In-Reply-To: <20210225204230.117a41fe@sovereign> References: <20210214012013.23165-1-dmitry.kozliuk@gmail.com> <20210225163337.GA1575@bricha3-MOBL.ger.corp.intel.com> <20210225204230.117a41fe@sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 5/6] config: discover libpcap on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/02/2021 18:42, Dmitry Kozlyuk: > 2021-02-25 16:33, Bruce Richardson: > > On Thu, Feb 25, 2021 at 07:04:38PM +0300, Dmitry Kozlyuk wrote: > > > 2021-02-25 15:02, Ferruh Yigit: > > > > On 2/14/2021 2:16 AM, Dmitry Kozlyuk wrote: > > > > > WinPcap or Npcap, can be installed anywhere. > > > > > Add a Meson option to specify SDK path. > > > > > > > > > > > > > I am not sure if it is OK to add a meson option for this, can't we use the > > > > default path? > > > > > > > > And does this mean we will need to add an option for each dependent library in > > > > Windows? If not, why pcap is special? > > > > > > There are some meson options for SDK paths already. Are they exceptions? > > > > > Right now, yes, they are exceptions, but there is work underway to remove > > them and just replace them with use of pkg-config. Is there some automatic > > path discovery mechanism on windows, similar to pkg-config, that can be > > used rather than having to add explicit dependency paths? > > pkg-config itself works on Windows if installed and given a PKG_CONFIG_PATH. > > Npcap doesn't provide a .pc file, despite libpcap commit 4f6b2b99 having it. Please work with them to provide a .pc. > Another quirk is that library is named libpcap.a/wpcap.lib on Unix/Windows. > I can just handle the name difference and assume it's in the search path. Yes please avoid adding a meson option for a path.