From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E7A6A00E6 for ; Mon, 2 Sep 2019 11:20:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 399CD1D44D; Mon, 2 Sep 2019 11:20:10 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 80A071D44C for ; Mon, 2 Sep 2019 11:20:08 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Sep 2019 02:20:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,457,1559545200"; d="scan'208";a="198548164" Received: from rnicolau-mobl1.ger.corp.intel.com (HELO [10.237.221.62]) ([10.237.221.62]) by fmsmga001.fm.intel.com with ESMTP; 02 Sep 2019 02:20:02 -0700 To: Stephen Hemminger Cc: dev@dpdk.org, akhil.goyal@nxp.com, konstantin.ananyev@intel.com, bernard.iremonger@intel.com, declan.doherty@intel.com References: <1567156760-29520-1-git-send-email-radu.nicolau@intel.com> <20190830073327.71b0a997@hermes.lan> From: "Nicolau, Radu" Message-ID: <277bf644-c3b5-0907-5414-68d8515df345@intel.com> Date: Mon, 2 Sep 2019 10:20:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: <20190830073327.71b0a997@hermes.lan> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH] security: add statistics definitions and update API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/30/2019 3:33 PM, Stephen Hemminger wrote: > On Fri, 30 Aug 2019 10:19:20 +0100 > Radu Nicolau wrote: > >> >> struct rte_security_ipsec_stats { >> + uint64_t ipackets; /**< Successfully received IPsec packets. */ >> + uint64_t opackets; /**< Successfully transmitted IPsec packets.*/ >> + uint64_t ibytes; /**< Successfully received IPsec bytes. */ >> + uint64_t obytes; /**< Successfully transmitted IPsec bytes. */ >> + uint64_t ierrors; /**< IPsec packets receive/decrypt errors. */ >> + uint64_t oerrors; /**< IPsec packets transmit/encrypt errors. */ >> uint64_t reserved; >> >> }; > Why not a second reserved field, then it will be 8*8 64 bytes long > which is cache aligned. And you will have a pair for future counters. Yes, I will add a second reserved field.