DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Bernard Iremonger <bernard.iremonger@intel.com>
Cc: dev@dpdk.org, rahul.r.shah@intel.com, wenzhuo.lu@intel.com,
	az5157@att.com
Subject: Re: [dpdk-dev] [PATCH v7 2/2] net/ixgbe: add callback to user app on VF to PF mbox msg
Date: Sat, 08 Oct 2016 00:44:19 +0200	[thread overview]
Message-ID: <2780407.hr2q20cLcS@xps13> (raw)
In-Reply-To: <1475858784-5303-3-git-send-email-bernard.iremonger@intel.com>

2016-10-07 17:46, Bernard Iremonger:
> +struct rte_pmd_ixgbe_mb_event_param {
> +	uint16_t vfid;     /**< Virtual Function number */
> +	uint16_t msg_type; /**< message type */
> +	uint16_t retval;   /**< return value */
> +	void *userdata;    /**< pointer to user data */

Generally speaking, the user data is a pointer passed by the application
when registering the callback and must be untouched.
It should be the name of the parameter that you are overriding with
this structure.
So this "userdata" pointer could probably be better defined.

By the way, it is far from trivial to understand how to write the callback.
I think it deserves more explanations.

  reply	other threads:[~2016-10-07 22:44 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-30 15:45 [dpdk-dev] [PATCH v3 0/2] add callbacks for VF management Bernard Iremonger
2016-09-30 15:45 ` [dpdk-dev] [PATCH v3 1/2] librte_ether: add internal callback functions Bernard Iremonger
2016-10-02  9:12   ` Stephen Hemminger
2016-10-03 15:29     ` Iremonger, Bernard
2016-09-30 15:45 ` [dpdk-dev] [PATCH v3 2/2] net/ixgbe: add callback to user app on VF to PF mbox msg Bernard Iremonger
2016-10-04 14:52 ` [dpdk-dev] [PATCH v4 0/2] add callbacks for VF management Bernard Iremonger
2016-10-06 11:26   ` [dpdk-dev] [PATCH v5 00/13] modify callback " Bernard Iremonger
2016-10-06 16:48     ` [dpdk-dev] [PATCH v6 0/2] " Bernard Iremonger
2016-10-07 16:46       ` [dpdk-dev] [PATCH v7 " Bernard Iremonger
2016-10-07 22:52         ` Thomas Monjalon
2016-10-10 14:34         ` [dpdk-dev] [PATCH v8 " Bernard Iremonger
2016-10-14  0:07           ` Thomas Monjalon
2016-10-10 14:34         ` [dpdk-dev] [PATCH v8 1/2] librte_ether: modify internal callback function Bernard Iremonger
2016-10-10 14:34         ` [dpdk-dev] [PATCH v8 2/2] net/ixgbe: add callback to user app on VF to PF mbox msg Bernard Iremonger
2016-10-12 15:03         ` [dpdk-dev] [PATCH v8 0/2] add API's for VF management Bernard Iremonger
2016-10-12 17:54           ` [dpdk-dev] [PATCH v9 " Bernard Iremonger
2016-10-13 13:47             ` Bruce Richardson
2016-10-12 17:54           ` [dpdk-dev] [PATCH v9 1/2] net/ixgbe: " Bernard Iremonger
2016-10-12 17:54           ` [dpdk-dev] [PATCH v9 2/2] app/test_pmd: add tests for new API's Bernard Iremonger
2016-10-12 15:03         ` [dpdk-dev] [PATCH v8 1/2] net/ixgbe: add API's for VF management Bernard Iremonger
2016-10-12 15:03         ` [dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new API's Bernard Iremonger
2016-10-12 15:11           ` Thomas Monjalon
2016-10-12 15:27             ` Iremonger, Bernard
2016-10-12 15:36               ` Thomas Monjalon
2016-10-12 15:48                 ` Iremonger, Bernard
2016-10-12 16:06                   ` Thomas Monjalon
2016-10-12 16:21                     ` Iremonger, Bernard
2016-10-12 16:31                       ` Thomas Monjalon
2016-10-12 16:50                         ` Iremonger, Bernard
2016-10-12 17:20                           ` Iremonger, Bernard
2016-10-07 16:46       ` [dpdk-dev] [PATCH v7 1/2] librte_ether: modify internal callback function Bernard Iremonger
2016-10-07 16:46       ` [dpdk-dev] [PATCH v7 2/2] net/ixgbe: add callback to user app on VF to PF mbox msg Bernard Iremonger
2016-10-07 22:44         ` Thomas Monjalon [this message]
2016-10-10 14:31           ` Iremonger, Bernard
2016-10-06 16:48     ` [dpdk-dev] [PATCH v6 1/2] librte_ether: modify internal callback function Bernard Iremonger
2016-10-07 12:29       ` Thomas Monjalon
2016-10-07 16:57         ` Iremonger, Bernard
2016-10-06 16:48     ` [dpdk-dev] [PATCH v6 2/2] net/ixgbe: add callback to user app on VF to PF mbox msg Bernard Iremonger
2016-10-07 12:14       ` Thomas Monjalon
2016-10-07 12:19         ` Iremonger, Bernard
2016-10-06 11:26   ` [dpdk-dev] [PATCH v5 01/13] librte_ether: modify internal callback function Bernard Iremonger
2016-10-06 12:56     ` Thomas Monjalon
2016-10-06 14:33       ` Iremonger, Bernard
2016-10-06 14:56         ` Thomas Monjalon
2016-10-06 15:32           ` Iremonger, Bernard
2016-10-06 15:41             ` Thomas Monjalon
2016-10-06 15:45               ` Iremonger, Bernard
2016-10-06 11:26   ` [dpdk-dev] [PATCH v5 02/13] net/ixgbe: add callback to user app on VF to PF mbox msg Bernard Iremonger
2016-10-06 11:26   ` [dpdk-dev] [PATCH v5 03/13] app/test: add parameter to callback process function Bernard Iremonger
2016-10-06 11:26   ` [dpdk-dev] [PATCH v5 04/13] net/bonding: " Bernard Iremonger
2016-10-06 11:26   ` [dpdk-dev] [PATCH v5 05/13] net/e1000: " Bernard Iremonger
2016-10-06 11:26   ` [dpdk-dev] [PATCH v5 06/13] net/i40e: update call " Bernard Iremonger
2016-10-06 11:26   ` [dpdk-dev] [PATCH v5 07/13] net/mlx4: add parameter " Bernard Iremonger
2016-10-06 11:26   ` [dpdk-dev] [PATCH v5 08/13] net/mlx5: " Bernard Iremonger
2016-10-06 11:26   ` [dpdk-dev] [PATCH v5 09/13] net/nfp: " Bernard Iremonger
2016-10-06 11:26   ` [dpdk-dev] [PATCH v5 10/13] net/thunderx: " Bernard Iremonger
2016-10-06 11:26   ` [dpdk-dev] [PATCH v5 11/13] net/vhost: " Bernard Iremonger
2016-10-06 11:26   ` [dpdk-dev] [PATCH v5 12/13] net/virtio: " Bernard Iremonger
2016-10-06 11:26   ` [dpdk-dev] [PATCH v5 13/13] net/enic: " Bernard Iremonger
2016-10-04 14:52 ` [dpdk-dev] [PATCH v4 1/2] librte_ether: add internal callback functions Bernard Iremonger
2016-10-05 16:10   ` Thomas Monjalon
2016-10-05 17:04     ` Iremonger, Bernard
2016-10-05 17:19       ` Thomas Monjalon
2016-10-04 14:52 ` [dpdk-dev] [PATCH v4 2/2] net/ixgbe: add callback to user app on VF to PF mbox msg Bernard Iremonger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2780407.hr2q20cLcS@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=az5157@att.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=rahul.r.shah@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).