From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A76941CC1; Fri, 17 Feb 2023 18:27:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 30C7B42C54; Fri, 17 Feb 2023 18:27:17 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 7CC1440EE3 for ; Fri, 17 Feb 2023 18:27:15 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 1E9075C0075; Fri, 17 Feb 2023 12:27:15 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 17 Feb 2023 12:27:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1676654835; x= 1676741235; bh=qV/KQCSGsTA/zwWZCXFWDyawAXqsrileCVeZUs1PGuc=; b=B hC4AmaMtMd7eN1Ojt/ZkoI0PebaSHVjgRJ9qvAZiKRMBPlu+VqmNY55Ns1moD2aq rK4fNYn08VWFM5iRstA7Z9Zdgswt5X2+9NFa0qxUqfv8qgC+BlTLpMgdqneGMy3/ ptIh0RC+A6pTkbqrhIEBSnCD+CrjJ34sXkE//2/cxK2y19Bvvs0H6jo1ONG7+vdY /S+N/ZLoDpaEeOBMIQk6j3voUOJyX21XmeCptLrctBGJDl+PiI7lvNx6P5Ka9LwT 6Yr8vnN2EPRPPJupuJxs4da4xYPxsn9MfwtAnvBFXvdHQhAM6DM6Ya539z0+Dtgb 13VTpZ81rVCqcEIotKbOA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1676654835; x= 1676741235; bh=qV/KQCSGsTA/zwWZCXFWDyawAXqsrileCVeZUs1PGuc=; b=I SE4AsyUbGPB5C8M8PgKlwjkHpjEaOC/xLHVnwzlIkjds7A5X402Bh0+OpriRwx8C q7WxPfB+oIMZKHnAh9Ig6j+2VU+9x/34/XA40+HvS2S/ArbzE5cnewfgKvNnMfkl vn+ph6dkwaBFG1L6Gtn5BiAY4oaaC/ATpObmVVHa3E/+i+jKerO7HVOWIS7xolxw 7DqUzOQs9FE3oS9yGwCLVMUYyUdvwiNbFE+Y7JTC8qHAyrcYpTesKGWKIG4bi1GS uji13yG1JhrvPSaS6CEoj0U5bLs4WeRxjPs66Vt5sx8ktYY5dmpfwFwZMNZrUOXB kbJC2+hc3aOvqyRUs4ehA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeiledgleekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 17 Feb 2023 12:27:14 -0500 (EST) From: Thomas Monjalon To: dev@dpdk.org, weix.ling@intel.com, Maxime Coquelin Cc: chenbo.xia@intel.com, david.marchand@redhat.com Subject: Re: [PATCH] net/virtio-user: fix vhost-kernel initialization Date: Fri, 17 Feb 2023 18:27:12 +0100 Message-ID: <2782446.AiC22s8V5E@thomas> In-Reply-To: <20230217123119.145894-1-maxime.coquelin@redhat.com> References: <20230217123119.145894-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 17/02/2023 13:31, Maxime Coquelin: > This patch fixes a regression causing devices with > Vhost-kernel backends initialization to fail. > > Indeed, Vhost-kernel backend init expects > dev->max_queue_pairs to be set at setup time, while its > assignment was moved after backend setup when adding > control queue support for Vhost-vdpa backends. > > It is safe to set dev->max_queue_pairs early for > Vhost-kernel backends as if the backend does not support > multiqueue, its setup will fail. > > Bugzilla ID: 1161 > Fixes: 7be724856315 ("net/virtio-user: get max number of queue pairs from device") > > Reported-by: Wei Ling > Signed-off-by: Maxime Coquelin Applied, thanks.