DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Gregory Etelson <getelson@nvidia.com>,
	aman.deep.singh@intel.com, dev@dpdk.org,
	Praveen Shetty <praveen.shetty@intel.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Cc: david.marchand@redhat.com, mkashani@nvidia.com,
	thomas@monjalon.net, yuying.zhang@intel.com,
	Dariusz Sosnowski <dsosnowski@nvidia.com>
Subject: Re: [PATCH v5 1/1] testpmd: add hairpin-map parameter
Date: Tue, 29 Oct 2024 21:51:40 +0000	[thread overview]
Message-ID: <2785a2fb-2daf-4da4-9da3-0528740addde@amd.com> (raw)
In-Reply-To: <20240922065053.996568-1-getelson@nvidia.com>

On 9/22/2024 7:50 AM, Gregory Etelson wrote:
> Hairpin offloads packet forwarding between ports.
> Packet is expected on Rx port <rp>, Rx queue <rq> and is forwarded
> to Tx port <tp> Tx queue <tq>.
> 
> Testpmd implements a static hairpin configuration scheme.
> 
> The new parameter allows explicit selection of Rx and Tx ports and
> queues in hairpin configuration.
> The new `hairpin-map` parameter is provided with 5 parameters,
> separated by `:`
> 
> `--hairpin-map=Rx port id:Rx queue:Tx port id:Tx queue:queues number`
> 
> Testpmd operator can provide several `hairpin-map` parameters for
> different hairpin maps.
> Example:
> 
> dpdk-testpmd <EAL params> -- \
>   <testpmd params> \
>   --rxq=2 --txq=2 --hairpinq=2 --hairpin-mode=0x12 \
>   --hairpin-map=0:2:1:2:1 \ # [1]
>   --hairpin-map=0:3:2:2:3   # [2]
> 
> Hairpin map [1] binds Rx port 0, queue 2 with Tx port 1, queue 2.
> Hairpin map [2] binds
>   Rx port 0, queue 3 with Tx port 2, queue 2,
>   Rx port 0, queue 4 with Tx port 2, queue 3,
>   Rx port 0, queue 5 with Tx port 2, queue 4.
> 
> The new `hairpin-map` parameter is optional.
> If omitted, testpmd will create "default" hairpin maps.
> 
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
>

+Praveen
cpfl is only other driver that implements hairpin, @Praveen can you
please help reviewing this patch, and confirm change works fine with
your changes.

@Stephen, if you have any free cycles, can you please help on this patch
too?

Thanks,
ferruh

  parent reply	other threads:[~2024-10-29 21:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-19 10:10 [PATCH] " Gregory Etelson
2023-09-20 12:22 ` [PATCH v2] " Gregory Etelson
2023-09-28 15:36 ` [PATCH v3] " Gregory Etelson
2023-12-14  8:06   ` Dariusz Sosnowski
2024-03-01 18:54   ` Ferruh Yigit
2024-03-05  3:04     ` Gregory Etelson
2024-09-22  6:50     ` [PATCH v5 1/1] " Gregory Etelson
2024-10-16  8:11       ` Ferruh Yigit
2024-10-28 10:23       ` Gregory Etelson
2024-10-29 21:51       ` Ferruh Yigit [this message]
2024-10-29 22:23         ` Stephen Hemminger
2024-09-11  5:08   ` [PATCH v4 " Gregory Etelson
2024-09-20 13:48     ` Singh, Aman Deep
2024-09-22  9:33       ` Etelson, Gregory

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2785a2fb-2daf-4da4-9da3-0528740addde@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=aman.deep.singh@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dsosnowski@nvidia.com \
    --cc=getelson@nvidia.com \
    --cc=mkashani@nvidia.com \
    --cc=praveen.shetty@intel.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    --cc=yuying.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).