From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FD38A0527; Mon, 20 Jul 2020 18:48:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D27DC1BFBC; Mon, 20 Jul 2020 18:48:51 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 61AE92B86 for <dev@dpdk.org>; Mon, 20 Jul 2020 18:48:50 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id E2C3D5C005D; Mon, 20 Jul 2020 12:48:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 20 Jul 2020 12:48:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= nTccFLlgXFe28WP+OBf3NkfJlQNvoaKpSsLNn2HnouI=; b=tLMYfWZ/q/RJH5BJ x5xaM1qRJW0ReC/R1Cp9yElD13KDq6M+AAu5XaOlbuIXGVbnkF6jCZFmgo1l/Gpc SZWwHJJWLFJ7nurlBwm6g56OrkAZ3tFfpRZY9NE53hSwibDmeIchKJr/Fe8WPBcl HqZBdXSH/AfRHpquaVYlroJm18GpkTJPt7ZldEMkAAZ0B86MQ6RZ4PakLLllMeVF l9sLnmOWzxIAR0xYXMUTs2P+Vdb8Eeo41348uHUkb9s1ZNKt8NZsujam3LdBch4k pLgBHEOrkIMwauP+PxpLxK2+jx/amGGaap6yWXIl0Iq2SWYyq9GmGQHCuYx/xF50 J+FMEQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=nTccFLlgXFe28WP+OBf3NkfJlQNvoaKpSsLNn2Hno uI=; b=LHnRB08NvJEogZ7M2cD5FMYaYIuPe0GfPrrRFrNqXNBYN9T56T8zKSU4f LRzjUWbMz3y79FIkt8B6d/9bZbYUVP9UPXZdZRnFhzZk3TpkH2Wx4k9kyCOcqP0i xV1n3W9yEdTuRHOyIqXDddkkz06aLCbU6M2fSh+m2omJ8k8CaAkCutsmA6HlwyiB fXl5Gpy6sAMVLuJij7rl2zhMnoWK+vrfOklQb34ZYVU8y2wbaCD1HiSr33L8OXNS ohwUdV+4ApC/ysysbLyIXPELwVMjiClMJN5Ee5SABolfJah67SPDCMZEhuyy11m/ 46l9VCfGNH/s5EVrZjIB7OV0oxBRA== X-ME-Sender: <xms:8MoVXzF2Z5Ys_-tvUpH2IxOKILNcw2vok6MpvsEOgNksi9tgdEgOnQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrgeeggdekudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: <xmx:8MoVXwV1X7lLw95zoUOSTX13Jd6Owzb9VZB43SajjdVGP3SGjCFVKQ> <xmx:8MoVX1Kpw95eaQaE6qhVacaqI2j0Ykhy0VcMZGplhgTQSuroDB1iqg> <xmx:8MoVXxEw6htma65_0jDm71mii6Ljft59Wdk8skLbKqMoSdeEAbEUwA> <xmx:8coVX3d0MNSLo3QOlL1iJ9ORcAmCERApxFtOOxI2TUT_jSNI18wTgQ> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8495830600B2; Mon, 20 Jul 2020 12:48:47 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Parav Pandit <parav@mellanox.com>, Ferruh Yigit <ferruh.yigit@intel.com> Cc: dev@dpdk.org, grive@u256.net, rasland@mellanox.com, orika@mellanox.com, matan@mellanox.com, joyce.kong@arm.com, David Marchand <david.marchand@redhat.com> Date: Mon, 20 Jul 2020 18:48:46 +0200 Message-ID: <2791231.CMBUAsGlKG@thomas> In-Reply-To: <f57100a0-52f3-ec1c-0200-9133d2964cf3@intel.com> References: <20200610171728.89-2-parav@mellanox.com> <20200717134924.922390-3-parav@mellanox.com> <f57100a0-52f3-ec1c-0200-9133d2964cf3@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 2/9] eal: introduce RTE common initialization level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 20/07/2020 18:21, Ferruh Yigit: > On 7/17/2020 2:49 PM, Parav Pandit wrote: > > Currently mlx5_common uses CLASS priority to initialize > > common code before initializing the PMD. > > However mlx5_common is not really a class, it is the pre-initialization > > code needed for the PMDs. > > > > In subsequent patch a needed initialization sequence is: > > (a) Initialize bus (say pci) > > (b) Initialize common code of a driver (mlx5_common) > > (c) Register mlx5 class PMDs (mlx5 net, mlx5 vdpa) > > Information registered by these PMDs is used by mlx5_bus_pci PMD. > > This mlx5 class PMDs should not confused with rte_class. > > (d) Register mlx5 PCI bus PMD > > > > Hence, introduce a new RTE priority level RTE_PRIO_COMMON which > > can be used for common initialization and RTE_PRIO_CLASS by mlx5 PMDs > > for class driver initialization. > > > > Signed-off-by: Parav Pandit <parav@mellanox.com> > > Acked-by: Matan Azrad <matan@mellanox.com> > > --- > > Changelog: > > v2->v3: > > - new patch > > --- > > lib/librte_eal/include/rte_common.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/librte_eal/include/rte_common.h b/lib/librte_eal/include/rte_common.h > > index 8f487a563..522afe58e 100644 > > --- a/lib/librte_eal/include/rte_common.h > > +++ b/lib/librte_eal/include/rte_common.h > > @@ -135,6 +135,7 @@ typedef uint16_t unaligned_uint16_t; > > > > #define RTE_PRIORITY_LOG 101 > > #define RTE_PRIORITY_BUS 110 > > +#define RTE_PRIORITY_COMMON 119 > > #define RTE_PRIORITY_CLASS 120 > > #define RTE_PRIORITY_LAST 65535 > > > > > > I guess the name "common" selected because of the intention to use it by the > common piece of the driver, but only from eal perspective the name > "PRIORITY_COMMON" looks so vague, it doesn't describe any purpose. You're right. > Also the value doesn't leave any gap between the class priority, what else can > be needed in the future in between, right? And we can imagine a bus requiring a common lib to be initialized before. > @Thomas, @David, I am reluctant to get this eal change through the next-net, can > you please review/ack it first? What about skipping this patch and using "RTE_PRIORITY_CLASS - 1" in the code?