From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 89B828E93 for ; Mon, 23 Nov 2015 23:18:37 +0100 (CET) Received: by wmvv187 with SMTP id v187so182800886wmv.1 for ; Mon, 23 Nov 2015 14:18:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=3pxejlQvlzVw9exS8jpStWBI8Y5pcwR4CkICZpbPojA=; b=VIR0m2goeS33enfBk3gKIs5zxAG3usFV46xST0tjVxJEYiEGsvsQ0IVV81Q4nxak43 05a3wD65d619n1TrnPEJRz7ZSf31YhmY6IHJf+WTfrUI0uh/7ISBZNiLX9kMYh0epx9X ShysDl3UF7Xn/Wxq0R3zdNgIxzS3erszeFCIWtf5I1JGK72fb8nZaxBA1kPgspz16hUk yxAK6nwR9tfcTbXF8ZXoHeGVll1s9gi1nyP66lhq/hPZxLR61yJU2girnQK0UbzV/OyU cE+uDoTgecwOoogqIThw0JKXKHd8WjsCPMzetzyAl09RI93VgoioT93ovk/w9jK5jxYV CIjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=3pxejlQvlzVw9exS8jpStWBI8Y5pcwR4CkICZpbPojA=; b=en8KROKIoyKhhDXDJ7wjfWvTszxtp90Fw6ufjzR1bs+xG30/Psablrr6JJwA+bOf6A dFXNFZ6q36i3TGKyUiB4H/roc5Gvp0cREi6G83J47hqF6qfU8d7LN7gooVHExK7rHFA1 h+RPZMqNYFNe7C+zl86v0NUvx1Q/k5nmCMymKgleWCyfUjCwV5rH6ID6EpDiORZnXox5 E7g+TJxq7r+fyb+vrapHsJsWyUTbQA4U8R2RT3SeIlOo+dCvQra0uxL7Ije6Tz2MBCLm 0XAY9S5Pqk4xnqgtVO6ZwYl53M9H0Fz8yfEDsESMfG10vGliEARXEbkq7KCfkBZku3Lm /EgQ== X-Gm-Message-State: ALoCoQntMvGNaUzToRHCVcrqOi5FBfZ+HQKOljCY/IpCfIIB0v0XPGFA/ruXgYA1Onm/78a/DTfm X-Received: by 10.28.35.66 with SMTP id j63mr22106785wmj.10.1448317117399; Mon, 23 Nov 2015 14:18:37 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id wh10sm15236081wjb.45.2015.11.23.14.18.36 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 23 Nov 2015 14:18:36 -0800 (PST) From: Thomas Monjalon To: Helin Zhang Date: Mon, 23 Nov 2015 23:17:20 +0100 Message-ID: <2795108.MCDRmV9y9P@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1447744187-32638-1-git-send-email-helin.zhang@intel.com> References: <1447744187-32638-1-git-send-email-helin.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] i40e: skip any phy config as a workaround X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Nov 2015 22:18:37 -0000 2015-11-17 15:09, Helin Zhang: > As firmware does not support any link control from software driver > side, any phy config should be ignored as a workaround. Otherwise > the link might not be up again after binding back to kernel driver. > > Signed-off-by: Helin Zhang [...] > +i40e_phy_conf_link(__rte_unused struct i40e_hw *hw, > + __rte_unused uint8_t abilities, > + __rte_unused uint8_t force_speed) > +{ > + /* Skip any phy config on both 10G and 40G interfaces, as a workaround > + * for the link control limitation of that all link control should be > + * handled by firmware. It should follow up if link control will be > + * opened to software driver in future firmware versions. > + */ > return I40E_SUCCESS; > } An error code seems more appropriate. But I guess you perfectly know what you do, so Applied, thanks