From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 5C4F71B83A for ; Wed, 11 Apr 2018 22:42:58 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CA72F216D6; Wed, 11 Apr 2018 16:42:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 11 Apr 2018 16:42:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=53kECHdUNL9CpylgQFv4Y0cqQn GHYmpEOG7wyNzXc4k=; b=PD8G3xXI6+ts7Dj613ACI40fe0GjgEpVNsAGd5bk9D WYdgTUwOA9OVkT02Tpws/l23RxhMj8Xh0TvottGiVSxSZAAgQfznkign2xBm6V4e QlyGm0LLBs+o95ijO/L/eFO4QUVG8cLv50QWvKXOJ1evy4Bna4w5lmjQ3RPkJ477 A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=53kECH dUNL9CpylgQFv4Y0cqQnGHYmpEOG7wyNzXc4k=; b=Y2y5rIjXZpgOIAPzC1jlcX 59fk2FvBmsIYsEafzhoHkyWcTTr7r//voL6bbJwLBX61s/lspG0hT78F0h35cQL+ lOvB9/GBAhXjJiB1gtwPb0FTiKgb4Y//bjfygPqcaQqKKnRgvui1Rh7SYG1oFyRm uFNtxIt6t/JzZAgL4rOiLQ13SiMhI8jUQtCY9pQDgqWBXStfH2UIWE0CSNI62oM8 GKW1e6xiEGPIW9FJn6keT+itwd+zhoQiap/9F0ON4Hb7AVn1sId308u37nu/GEjQ NglZPmFNHrEtXuRlRFwKrigJOj7/7F52z0OLifWWIjkwX1120jq+O+L2Jl7dQNdg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D5BE6E4122; Wed, 11 Apr 2018 16:42:56 -0400 (EDT) From: Thomas Monjalon To: Pavan Nikhilesh Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, ferruh.yigit@intel.com, stephen@networkplumber.org, konstantin.ananyev@intel.com Date: Wed, 11 Apr 2018 22:42:55 +0200 Message-ID: <2796123.plAjDWPncV@xps> In-Reply-To: <20180411170150.11985-1-pbhagavatula@caviumnetworks.com> References: <20180406110103.29163-1-pbhagavatula@caviumnetworks.com> <20180411170150.11985-1-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] eal: fix clang compilation error on ARM64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2018 20:42:58 -0000 11/04/2018 19:01, Pavan Nikhilesh: > Use __atomic_exchange_n instead of __atomic_exchange_(2/4/8). > The error was: > include/generic/rte_atomic.h:215:9: error: > implicit declaration of function '__atomic_exchange_2' > is invalid in C99 > include/generic/rte_atomic.h:494:9: error: > implicit declaration of function '__atomic_exchange_4' > is invalid in C99 > include/generic/rte_atomic.h:772:9: error: > implicit declaration of function '__atomic_exchange_8' > is invalid in C99 > > Fixes: ff2863570fcc ("eal: introduce atomic exchange operation") > > Signed-off-by: Pavan Nikhilesh We did not understand why this error is seen only on ARM (hopefully we won't discover it somewhere else), but it is a pragmatic fix. Applied, thanks