DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
	David Hunt <david.hunt@intel.com>,
	Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
	Jerin Jacob <jerinj@marvell.com>,
	Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
	Sameh Gobriel <sameh.gobriel@intel.com>,
	Sunil Kumar Kori <skori@marvell.com>,
	Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
	Yipeng Wang <yipeng1.wang@intel.com>
Subject: Re: [PATCH 0/5] use rte atomic thread fence
Date: Wed, 08 Nov 2023 18:04:47 +0100	[thread overview]
Message-ID: <2796747.XrmoMso0CX@thomas> (raw)
In-Reply-To: <1698894265-22963-1-git-send-email-roretzla@linux.microsoft.com>

02/11/2023 04:04, Tyler Retzlaff:
> Replace use of __atomic_thread_fence with __rte_atomic_thread_fence.
> 
> It may be appropriate to use rte_atomic_thread_fence instead but it
> will be up to maintainers to evaluate and make the change if appropriate.

I don't understand the use of __rte_atomic_thread_fence
which is supposed to be EAL-internal only, isn't it?

On x86, we have this:
static __rte_always_inline void
rte_atomic_thread_fence(rte_memory_order memorder)
{
    if (memorder == rte_memory_order_seq_cst)
        rte_smp_mb();
    else
        __rte_atomic_thread_fence(memorder);
}

This is skipped if you use __rte_atomic_thread_fence() directly.



  parent reply	other threads:[~2023-11-08 17:04 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-02  3:04 Tyler Retzlaff
2023-11-02  3:04 ` [PATCH 1/5] distributor: " Tyler Retzlaff
2023-11-02  3:04 ` [PATCH 2/5] eal: " Tyler Retzlaff
2023-11-02  3:04 ` [PATCH 3/5] hash: " Tyler Retzlaff
2023-11-02  3:04 ` [PATCH 4/5] ring: " Tyler Retzlaff
2023-11-02  3:04 ` [PATCH 5/5] stack: " Tyler Retzlaff
2023-11-02  7:42 ` [PATCH 0/5] " Morten Brørup
2023-11-08 17:04 ` Thomas Monjalon [this message]
2023-11-08 18:49   ` Tyler Retzlaff
2024-02-14 22:40     ` Thomas Monjalon
2024-02-15  6:50 ` [PATCH v2 0/6] " Tyler Retzlaff
2024-02-15  6:50   ` [PATCH v2 1/6] distributor: " Tyler Retzlaff
2024-02-15  6:50   ` [PATCH v2 2/6] eal: " Tyler Retzlaff
2024-02-15  6:50   ` [PATCH v2 3/6] hash: " Tyler Retzlaff
2024-02-15  6:50   ` [PATCH v2 4/6] ring: " Tyler Retzlaff
2024-02-15  6:50   ` [PATCH v2 5/6] stack: " Tyler Retzlaff
2024-02-15  6:50   ` [PATCH v2 6/6] lpm: " Tyler Retzlaff
2024-02-18  3:23   ` [PATCH v2 0/6] " fengchengwen
2024-02-18 12:18     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2796747.XrmoMso0CX@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=jerinj@marvell.com \
    --cc=konstantin.v.ananyev@yandex.ru \
    --cc=roretzla@linux.microsoft.com \
    --cc=sameh.gobriel@intel.com \
    --cc=skori@marvell.com \
    --cc=vladimir.medvedkin@intel.com \
    --cc=yipeng1.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).