From: "Harris, James R" <james.r.harris@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "Burakov, Anatoly" <anatoly.burakov@intel.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] vfio: free mp_reply msgs in failure cases
Date: Mon, 14 Oct 2019 14:50:47 +0000 [thread overview]
Message-ID: <27969D65-E386-4DC9-AEB9-FB8ED4215EAB@intel.com> (raw)
In-Reply-To: <CAJFAV8zwOQVKwXGk75beZ3TVtSn5s0MCukb2FAfnzB0V8L8meg@mail.gmail.com>
> On Oct 14, 2019, at 7:47 AM, David Marchand <david.marchand@redhat.com> wrote:
>
> On Mon, Oct 14, 2019 at 3:49 PM Harris, James R
> <james.r.harris@intel.com> wrote:
>> On 10/14/19, 4:18 AM, "David Marchand" <david.marchand@redhat.com> wrote:
>>
>>> On Fri, Aug 16, 2019 at 9:19 PM Jim Harris <james.r.harris@intel.com> wrote:
>>>
>>> The code checks both rte_mp_request_sync() return
>>> code and that the number of messages in the reply
>>> equals 1. If rte_mp_request_sync() succeeds but
>>> there was more than one message, those messages
>>> would get leaked.
>>>
>>> Found via code review by Anatoly Burakov of patches
>>> that used the vhost code as a template for using
>>> rte_mp_request_sync().
>>
>> The patch looks fine, I just want to make sure its title reflect what it fixes.
>> Can you give some insights of how common this issue is? If there are
>> known cases where it happens?
>>
>> Hi David,
>>
>> I don't think this issue is common at all. I don't have any known cases in mind - it was only found via code inspection.
>
> Anatoly, Jim,
>
> Not really inspired for the title, what do you think of:
> vfio: fix potential leak with multiprocess
>
> Plus, it deserves a Fixes: line.
> Fixes: 83a73c5fef66 ("vfio: use generic multi-process channel")
> Cc: stable@dpdk.org
>
> If you are okay with this, I will do the change when applying.
I am ok with those changes. Thanks!
>
> --
> David Marchand
>
next prev parent reply other threads:[~2019-10-14 14:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 12:13 Jim Harris
2019-08-20 13:13 ` Burakov, Anatoly
2019-08-20 13:16 ` Harris, James R
2019-08-20 13:22 ` Burakov, Anatoly
2019-10-14 11:17 ` David Marchand
2019-10-14 13:49 ` Harris, James R
2019-10-14 14:47 ` David Marchand
2019-10-14 14:50 ` Harris, James R [this message]
2019-10-15 18:38 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27969D65-E386-4DC9-AEB9-FB8ED4215EAB@intel.com \
--to=james.r.harris@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).