From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4366AA0A02; Thu, 25 Mar 2021 11:00:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9ACA4067B; Thu, 25 Mar 2021 11:00:40 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 4230540147 for ; Thu, 25 Mar 2021 11:00:38 +0100 (CET) IronPort-SDR: 947ZtVF0zePQZbgFQ6uns8vwpGF2XozldbleQS4A5vVL67jaD9/T9kywoIEw9PQ1jXlxTpSA7K wT/1zkijxrYw== X-IronPort-AV: E=McAfee;i="6000,8403,9933"; a="178010905" X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="178010905" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 03:00:37 -0700 IronPort-SDR: POxfR1wvg0XDuz6R9MIwJjs2AoOlZtc0W4M24m+OL90f2L4UNBnQygD6B4774UXTqZf53xC0BO z9opATa4Q3Wg== X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="391663394" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.15.136]) ([10.252.15.136]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 03:00:33 -0700 To: Andrew Rybchenko , Thomas Monjalon Cc: dev@dpdk.org, Rosen Xu , Hemant Agrawal , Sachin Saxena , Jingjing Wu , Beilei Xing , Qiming Yang , Qi Zhang , Jeff Guo , Haiyue Wang References: <20210311221742.3750589-1-thomas@monjalon.net> <20210321090002.595744-3-thomas@monjalon.net> <6076825.RBgRJtLnUj@thomas> <325e1d27-3729-0768-fc0d-ef89c1db9cf5@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy Message-ID: <27e1324b-886a-7e26-3215-08a10daf679e@intel.com> Date: Thu, 25 Mar 2021 10:00:29 +0000 MIME-Version: 1.0 In-Reply-To: <325e1d27-3729-0768-fc0d-ef89c1db9cf5@oktetlabs.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 2/2] drivers/net: remove explicit include of legacy filtering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/25/2021 5:53 AM, Andrew Rybchenko wrote: > On 3/24/21 11:00 PM, Thomas Monjalon wrote: >> 24/03/2021 19:08, Ferruh Yigit: >>> On 3/21/2021 9:00 AM, Thomas Monjalon wrote: >>>> The header file rte_eth_ctrl.h should not be needed because >>>> this legacy filtering API is completely replaced with the rte_flow API. >>>> However some definitions from this file are still used by some drivers, >>>> but such usage is already covered by an implicit include via rte_ethdev.h. >>>> >>>> Signed-off-by: Thomas Monjalon >>>> Acked-by: Rosen Xu >>>> Acked-by: Hemant Agrawal >>>> --- >>>> drivers/net/dpaa2/dpaa2_ptp.c | 1 - >>>> drivers/net/iavf/iavf_hash.c | 1 - >>>> drivers/net/ice/ice_acl_filter.c | 1 - >>>> drivers/net/ice/ice_hash.c | 1 - >>>> drivers/net/ice/ice_switch_filter.c | 1 - >>>> drivers/net/igc/igc_filter.h | 1 - >>>> drivers/net/ipn3ke/ipn3ke_flow.c | 1 - >>> >>> Although this will work, if the above drives are using the defines from the >>> header file, isn't it better to include it explicitly? >>> >>> What is the benefit of including the header implicitly? >> >> The benefit is to progressively remove rte_eth_ctrl.h. >> I want it to disappear. >> > > +1 > This is just hiding its usage, the patch is not making it less used as a step forward to remove it. But anyway I guess it doesn't worth spending more time to discuss it ...