答复: [PATCH v2 05/18] net/r8169: add support for hw config

[王颢 <howard_wang@realsil.com.cn>]

Dear Stephen,

As you can see, there are some issues with the current code regarding whitespace and CODE_INDENT. I used astyle to adjust the code format with the following command. However, I found that I could not fully meet the checkpatch requirements (unless I modify them manually). Would you mind providing some suggestions? For example, what tools do you use to standardize the code? Thank you!

astyle -A8 -t8 -p -H -U -k3 -xj -xB -xC80 -xL -n -r "*.c" "*.h"

Best Regards,
Howard Wang

-----邮件原件-----
发件人: Stephen Hemminger <stephen@networkplumber.org> 
发送时间: 2024年10月18日 0:36
收件人: 王颢 <howard_wang@realsil.com.cn>
抄送: dev@dpdk.org; pro_nic_dpdk@realtek.com
主题: Re: [PATCH v2 05/18] net/r8169: add support for hw config


External mail.



On Thu, 17 Oct 2024 14:31:47 +0800
Howard Wang <howard_wang@realsil.com.cn> wrote:

> Implement the rtl_hw_config function to configure the hardware.
>
> Signed-off-by: Howard Wang <howard_wang@realsil.com.cn>

More indent issues flagged in this patch

ERROR:CODE_INDENT: code indent should use tabs where possible
#292: FILE: drivers/net/r8169/r8169_hw.c:19:
+                                   int type, const u32 base_address)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#292: FILE: drivers/net/r8169/r8169_hw.c:19:
+                                   int type, const u32 base_address)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#299: FILE: drivers/net/r8169/r8169_hw.c:26:
+^I                                     (base_address & 0x000FFF);$