From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 406E1A046B for ; Fri, 28 Jun 2019 15:34:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C9CEC37B0; Fri, 28 Jun 2019 15:34:37 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 6532E37B0; Fri, 28 Jun 2019 15:34:36 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BED7921AC2; Fri, 28 Jun 2019 09:34:35 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 28 Jun 2019 09:34:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=W/iV65kuvmvCANY7gtsXquntCBWDaKK+VtgwhvNoIys=; b=RBPRNaAMszei QREJ09BExNmX/RX/a8acCjtUGsN+5EBvVFgniDtpq5btf0N9eN7lAlibnWx53qj9 Y5ap09ajVUQ1MEBDYwFjwdPtowLocfdLuW7k1R9vNl+qF15eg+yb1QWC66lArJLF QO0PZOsjkmvPij5TyJbIwrIy4H/BKWU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=W/iV65kuvmvCANY7gtsXquntCBWDaKK+VtgwhvNoI ys=; b=iFFaDoPz7Lo4YQmIRKaRrcsQfFJ3Ad6l7iSHSMKfNniGzcioyVufnr40L hwxLC/kha2iXIDSWrnK2PSrVAc/LZQCy25dtE1dUFmUrfu3YGQJjGr/lgbiweaKb 1u0o/IIh590db6dh3Lo5TWEvEBK3CQyUy3K4jixmy21RcWvlURHSm7509eLTKt9R fAedmRCbEKwyebTZG6dAB27zHkLciQqMOCrcbIpk0xNfp3B4xUVBmuSWlAY3VMoh DMkj3/zlEoMG8lfTQ4OYCSgUQ5TdBGI7Xt3XWJJPBpP17vGCZwAyL6qbYTvMOTKF bvGxIMbiSGbt4UtU378F665qK0UNw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrvddtgdeikecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AF7D58005A; Fri, 28 Jun 2019 09:34:33 -0400 (EDT) From: Thomas Monjalon To: Honnappa Nagarahalli Cc: stable@dpdk.org, David Marchand , dev , ruifeng.wang@arm.com, nd , ferruh.yigit@intel.com Date: Fri, 28 Jun 2019 15:34:32 +0200 Message-ID: <2800271.zs2T813PYt@xps> In-Reply-To: References: <20190628034406.5399-1-honnappa.nagarahalli@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] test/rcu: increase the size of num cores variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/06/2019 11:09, David Marchand: > On Fri, Jun 28, 2019 at 5:44 AM Honnappa Nagarahalli > > --- a/app/test/test_rcu_qsbr.c > > +++ b/app/test/test_rcu_qsbr.c > > @@ -27,7 +27,7 @@ > > #define TEST_RCU_QSBR_CNT_INIT 1 > > > > uint16_t enabled_core_ids[RTE_MAX_LCORE]; > > -uint8_t num_cores; > > +uint16_t num_cores; > > If we want to be closer to the eal API, those should be unsigned int. I agree, please use unsigned int where relevant.