From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F26DA42306; Sun, 19 Mar 2023 23:43:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7CA7441611; Sun, 19 Mar 2023 23:43:54 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id EC012410EC; Sun, 19 Mar 2023 23:43:52 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8AD475C00CD; Sun, 19 Mar 2023 18:43:52 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 19 Mar 2023 18:43:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1679265832; x=1679352232; bh=qFi/dpc0roW0t+z+/tVcS4RcrSdElu/YTJj tHHgGXEQ=; b=ONvWV+/eJut6iH8CgKzA10l6DFO4rQHChDuAGhQW94yJMbk5TuY XkBrI0cHWQFjInytHFOdfjgBRnigbNd0PuRzBXj7TyqvooySkcxyT/Mb5vZPq8ka RIfITy2JfkDj4NqnUDd2/9gsjmuJ4IPtzXY02zJD+mp+Uivm8v0pBoXgy64womjb 59cNM3h+UBsK+elkVHu6DANyknY1LCOiBh4OrsVh4AmZP4Sw6ifREQWF0xbUjaba cbohDr8BpYu6//hJ86Qypilsu8YAhGBkF+JkdaXouHZHxofu4b0La0Ba4YRKr4a0 Ixa0YWa2d8HXz9Qp5achf17u7fYKuORSMoQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679265832; x=1679352232; bh=qFi/dpc0roW0t+z+/tVcS4RcrSdElu/YTJj tHHgGXEQ=; b=GLRgZwt6SbAszhUYjZRZupEAJxa4PYcdRxDIWmHt7z7Yr8ZQSqW XLb1fCRR13KllH93jvZS12IXKD59GiDOUan6eJjmF3vRXWDkEAqSZJ3KB8HOBgzG vriE+jQyBHUBcV5polOOYsg+Fqogv/txO/C2Zw8VBUe4qgmCUuUnf+yFQM4jDT+U t/4kk25iDkAIpABkbKGfLNK+7qnni0sO47hExxc/q7x5a4+c8NNcO7amVZs/VqSK gaWfgbSd9VTS/l8J0Ao0bWs9IB2nNRiR9FDZeXCmCw0lrs8UBqMamaMx74qzGCIP OcqIfI+AZSMOW8lBsZiqLNQGJHX6eG7od4A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdefjedgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedtheevtdekiedvueeuvdei uddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 Mar 2023 18:43:51 -0400 (EDT) From: Thomas Monjalon To: Elena Agostini Cc: dev@dpdk.org, stable@dpdk.org, David Marchand Subject: Re: [PATCH] gpudev: export header file for external drivers Date: Sun, 19 Mar 2023 23:43:50 +0100 Message-ID: <2800348.88bMQJbFj6@thomas> In-Reply-To: <2906874.VdNmn5OnKV@thomas> References: <20230316085919.46500-1-thomas@monjalon.net> <2906874.VdNmn5OnKV@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 19/03/2023 23:28, Thomas Monjalon: > 16/03/2023 10:23, David Marchand: > > On Thu, Mar 16, 2023 at 9:59=E2=80=AFAM Thomas Monjalon wrote: > > > > > > In DPDK 21.05, the option driver_sdk_headers was introduced > > > to export required headers to allow building out-of-tree drivers. > > > > > > In DPDK 21.11, the gpudev driver class was introduced, > > > without this out-of-tree compatibility. > > > > > > It is fixed by exporting gpudev_driver.h as part of the driver SDK. > > > > > > Fixes: 8b8036a66e3d ("gpudev: introduce GPU device class library") > > > Cc: stable@dpdk.org > > > > > > Reported-by: David Marchand > > > Signed-off-by: Thomas Monjalon > >=20 > > LGTM, thanks. >=20 > Applied =46orgot to send the v2 merged with this addition: " As a consequence of exporting this header file, C++ "extern C" guard must be added. "